Commit 62ae386e authored by Jeremy Roman's avatar Jeremy Roman Committed by Commit Bot

ScriptPromise: Use ToV8 to convert Vector<ScriptValue> to a V8 array.

This eliminates the use of V8CallBoolean.

Bug: 670615
Change-Id: Ifaaa803e47b08018546d30ad633f861f38a8d645
Reviewed-on: https://chromium-review.googlesource.com/c/1288673Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600750}
parent fdda9f64
......@@ -133,14 +133,8 @@ class PromiseAllHandler final
if (--number_of_pending_promises_ > 0)
return;
v8::Local<v8::Array> values =
v8::Array::New(value.GetIsolate(), values_.size());
for (wtf_size_t i = 0; i < values_.size(); ++i) {
if (!V8CallBoolean(values->CreateDataProperty(value.GetContext(), i,
values_[i].V8Value())))
return;
}
v8::Local<v8::Value> values =
ToV8(values_, value.GetContext()->Global(), value.GetIsolate());
MarkPromiseSettled();
resolver_.Resolve(values);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment