Oilpan: Rename to CrossThreadPersistentRegions

Rename CrossThreadPersistentRegion to CrossThreadPersistentRegions as we will be adding a second PersistentRegion for weak persistents:

BUG=757440

Change-Id: I751747470c5ddc1481270e181cdd1edcf9ae5291
Reviewed-on: https://chromium-review.googlesource.com/882626Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531830}

third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

@@ -197,8 +197,8 @@ void OfflineAudioDestinationHandler::DoOfflineRendering() {
     // data. Detect that condition by trying to take the cross-thread
     // persistent lock which is held while a GC runs. If the lock is
     // already held, simply delay rendering until the next quantum.
-    CrossThreadPersistentRegion::LockScope gc_lock(
-        ProcessHeap::GetCrossThreadPersistentRegion(), true);
+    CrossThreadPersistentRegions::LockScope gc_lock(
+        ProcessHeap::GetCrossThreadPersistentRegions(), true);
     if (!gc_lock.HasLock()) {
       // To ensure that the rendering step eventually happens, repost.
       GetRenderingThread()->GetWebTaskRunner()->PostTask(

third_party/WebKit/Source/platform/heap/Heap.cpp

@@ -75,10 +75,10 @@ void ProcessHeap::ResetHeapCounters() {
   total_marked_object_size_ = 0;
 }
 
-CrossThreadPersistentRegion& ProcessHeap::GetCrossThreadPersistentRegion() {
-  DEFINE_THREAD_SAFE_STATIC_LOCAL(CrossThreadPersistentRegion,
-                                  persistent_region, ());
-  return persistent_region;
+CrossThreadPersistentRegions& ProcessHeap::GetCrossThreadPersistentRegions() {
+  DEFINE_THREAD_SAFE_STATIC_LOCAL(CrossThreadPersistentRegions,
+                                  persistent_regions, ());
+  return persistent_regions;
 }
 
 size_t ProcessHeap::total_allocated_space_ = 0;
@@ -535,7 +535,7 @@ bool ThreadHeap::IsAddressInHeapDoesNotContainCache(Address address) {
 void ThreadHeap::VisitPersistentRoots(Visitor* visitor) {
   DCHECK(thread_state_->IsInGC());
   TRACE_EVENT0("blink_gc", "ThreadHeap::visitPersistentRoots");
-  ProcessHeap::GetCrossThreadPersistentRegion().TracePersistentNodes(visitor);
+  ProcessHeap::GetCrossThreadPersistentRegions().TracePersistentNodes(visitor);
 
   thread_state_->VisitPersistents(visitor);
 }
@@ -672,26 +672,26 @@ void ThreadHeap::PromptlyFreed(size_t gc_info_index) {
 
 #if defined(ADDRESS_SANITIZER)
 void ThreadHeap::PoisonAllHeaps() {
-  CrossThreadPersistentRegion::LockScope persistent_lock(
-      ProcessHeap::GetCrossThreadPersistentRegion());
+  CrossThreadPersistentRegions::LockScope persistent_lock(
+      ProcessHeap::GetCrossThreadPersistentRegions());
   // Poisoning all unmarked objects in the other arenas.
   for (int i = 1; i < BlinkGC::kNumberOfArenas; i++)
     arenas_[i]->PoisonArena();
   // CrossThreadPersistents in unmarked objects may be accessed from other
-  // threads (e.g. in CrossThreadPersistentRegion::shouldTracePersistent) and
+  // threads (e.g. in CrossThreadPersistentRegions::shouldTracePersistent) and
   // that would be fine.
-  ProcessHeap::GetCrossThreadPersistentRegion()
+  ProcessHeap::GetCrossThreadPersistentRegions()
       .UnpoisonCrossThreadPersistents();
 }
 
 void ThreadHeap::PoisonEagerArena() {
-  CrossThreadPersistentRegion::LockScope persistent_lock(
-      ProcessHeap::GetCrossThreadPersistentRegion());
+  CrossThreadPersistentRegions::LockScope persistent_lock(
+      ProcessHeap::GetCrossThreadPersistentRegions());
   arenas_[BlinkGC::kEagerSweepArenaIndex]->PoisonArena();
   // CrossThreadPersistents in unmarked objects may be accessed from other
-  // threads (e.g. in CrossThreadPersistentRegion::shouldTracePersistent) and
+  // threads (e.g. in CrossThreadPersistentRegions::shouldTracePersistent) and
   // that would be fine.
-  ProcessHeap::GetCrossThreadPersistentRegion()
+  ProcessHeap::GetCrossThreadPersistentRegions()
       .UnpoisonCrossThreadPersistents();
 }
 #endif

third_party/WebKit/Source/platform/heap/Heap.h

@@ -83,7 +83,7 @@ class PLATFORM_EXPORT HeapAllocHooks {
   static FreeHook* free_hook_;
 };
 
-class CrossThreadPersistentRegion;
+class CrossThreadPersistentRegions;
 class HeapCompact;
 template <typename T>
 class Member;
@@ -124,7 +124,7 @@ class PLATFORM_EXPORT ProcessHeap {
  public:
   static void Init();
 
-  static CrossThreadPersistentRegion& GetCrossThreadPersistentRegion();
+  static CrossThreadPersistentRegions& GetCrossThreadPersistentRegions();
 
   static void IncreaseTotalAllocatedObjectSize(size_t delta) {
     AtomicAdd(&total_allocated_object_size_, static_cast<long>(delta));

third_party/WebKit/Source/platform/heap/Persistent.h

@@ -185,8 +185,8 @@ class PersistentBase {
   NO_SANITIZE_ADDRESS
   void Assign(T* ptr) {
     if (crossThreadnessConfiguration == kCrossThreadPersistentConfiguration) {
-      CrossThreadPersistentRegion::LockScope persistent_lock(
-          ProcessHeap::GetCrossThreadPersistentRegion());
+      CrossThreadPersistentRegions::LockScope persistent_lock(
+          ProcessHeap::GetCrossThreadPersistentRegions());
       raw_ = ptr;
     } else {
       raw_ = ptr;
@@ -222,7 +222,7 @@ class PersistentBase {
         TraceMethodDelegate<PersistentBase,
                             &PersistentBase::TracePersistent>::Trampoline;
     if (crossThreadnessConfiguration == kCrossThreadPersistentConfiguration) {
-      ProcessHeap::GetCrossThreadPersistentRegion().AllocatePersistentNode(
+      ProcessHeap::GetCrossThreadPersistentRegions().AllocatePersistentNode(
           persistent_node_, this, trace_callback);
       return;
     }
@@ -239,7 +239,7 @@ class PersistentBase {
   void Uninitialize() {
     if (crossThreadnessConfiguration == kCrossThreadPersistentConfiguration) {
       if (AcquireLoad(reinterpret_cast<void* volatile*>(&persistent_node_)))
-        ProcessHeap::GetCrossThreadPersistentRegion().FreePersistentNode(
+        ProcessHeap::GetCrossThreadPersistentRegions().FreePersistentNode(
             persistent_node_);
       return;
     }
@@ -819,8 +819,8 @@ template <typename T>
 struct BindUnwrapTraits<blink::CrossThreadWeakPersistent<T>> {
   static blink::CrossThreadPersistent<T> Unwrap(
       const blink::CrossThreadWeakPersistent<T>& wrapped) {
-    blink::CrossThreadPersistentRegion::LockScope persistentLock(
-        blink::ProcessHeap::GetCrossThreadPersistentRegion());
+    blink::CrossThreadPersistentRegions::LockScope persistentLock(
+        blink::ProcessHeap::GetCrossThreadPersistentRegions());
     return blink::CrossThreadPersistent<T>(wrapped.Get());
   }
 };

third_party/WebKit/Source/platform/heap/PersistentNode.cpp

@@ -125,7 +125,7 @@ void PersistentRegion::TracePersistentNodes(Visitor* visitor,
 #endif
 }
 
-bool CrossThreadPersistentRegion::ShouldTracePersistentNode(
+bool CrossThreadPersistentRegions::ShouldTracePersistentNode(
     Visitor* visitor,
     PersistentNode* node) {
   CrossThreadPersistent<DummyGCBase>* persistent =
@@ -138,7 +138,7 @@ bool CrossThreadPersistentRegion::ShouldTracePersistentNode(
   return &visitor->Heap() == &ThreadState::FromObject(raw_object)->Heap();
 }
 
-void CrossThreadPersistentRegion::PrepareForThreadStateTermination(
+void CrossThreadPersistentRegions::PrepareForThreadStateTermination(
     ThreadState* thread_state) {
   // For heaps belonging to a thread that's detaching, any cross-thread
   // persistents pointing into them needs to be disabled. Do that by clearing
@@ -175,7 +175,7 @@ void CrossThreadPersistentRegion::PrepareForThreadStateTermination(
 }
 
 #if defined(ADDRESS_SANITIZER)
-void CrossThreadPersistentRegion::UnpoisonCrossThreadPersistents() {
+void CrossThreadPersistentRegions::UnpoisonCrossThreadPersistents() {
   MutexLocker lock(mutex_);
   int persistent_count = 0;
   for (PersistentNodeSlots* slots = persistent_region_->slots_; slots;

third_party/WebKit/Source/platform/heap/PersistentNode.h

@@ -15,7 +15,7 @@
 
 namespace blink {
 
-class CrossThreadPersistentRegion;
+class CrossThreadPersistentRegions;
 
 class PersistentNode final {
   DISALLOW_NEW();
@@ -93,7 +93,7 @@ struct PersistentNodeSlots final {
   PersistentNodeSlots* next_;
   PersistentNode slot_[kSlotCount];
   friend class PersistentRegion;
-  friend class CrossThreadPersistentRegion;
+  friend class CrossThreadPersistentRegions;
 };
 
 // PersistentRegion provides a region of PersistentNodes. PersistentRegion
@@ -153,7 +153,7 @@ class PLATFORM_EXPORT PersistentRegion final {
   int NumberOfPersistents();
 
  private:
-  friend CrossThreadPersistentRegion;
+  friend CrossThreadPersistentRegions;
 
   void EnsurePersistentNodeSlots(void*, TraceCallback);
 
@@ -164,11 +164,11 @@ class PLATFORM_EXPORT PersistentRegion final {
 #endif
 };
 
-class CrossThreadPersistentRegion final {
-  USING_FAST_MALLOC(CrossThreadPersistentRegion);
+class CrossThreadPersistentRegions final {
+  USING_FAST_MALLOC(CrossThreadPersistentRegions);
 
  public:
-  CrossThreadPersistentRegion()
+  CrossThreadPersistentRegions()
       : persistent_region_(WTF::WrapUnique(new PersistentRegion)) {}
 
   void AllocatePersistentNode(PersistentNode*& persistent_node,
@@ -202,7 +202,7 @@ class CrossThreadPersistentRegion final {
     STACK_ALLOCATED();
 
    public:
-    LockScope(CrossThreadPersistentRegion& persistent_region,
+    LockScope(CrossThreadPersistentRegions& persistent_region,
               bool try_lock = false)
         : persistent_region_(persistent_region), locked_(true) {
       if (try_lock)
@@ -221,7 +221,7 @@ class CrossThreadPersistentRegion final {
     bool HasLock() const { return locked_; }
 
    private:
-    CrossThreadPersistentRegion& persistent_region_;
+    CrossThreadPersistentRegions& persistent_region_;
     bool locked_;
   };
 
@@ -231,7 +231,7 @@ class CrossThreadPersistentRegion final {
     DCHECK(mutex_.Locked());
 #endif
     persistent_region_->TracePersistentNodes(
-        visitor, CrossThreadPersistentRegion::ShouldTracePersistentNode);
+        visitor, CrossThreadPersistentRegions::ShouldTracePersistentNode);
   }
 
   void PrepareForThreadStateTermination(ThreadState*);
@@ -252,14 +252,14 @@ class CrossThreadPersistentRegion final {
 
   bool TryLock() { return mutex_.TryLock(); }
 
-  // We don't make CrossThreadPersistentRegion inherit from PersistentRegion
+  // We don't make CrossThreadPersistentRegions inherit from PersistentRegion
   // because we don't want to virtualize performance-sensitive methods
   // such as PersistentRegion::allocate/freePersistentNode.
   std::unique_ptr<PersistentRegion> persistent_region_;
 
   // Recursive as prepareForThreadStateTermination() clears a PersistentNode's
   // associated Persistent<> -- it in turn freeing the PersistentNode. And both
-  // CrossThreadPersistentRegion operations need a lock on the region before
+  // CrossThreadPersistentRegions operations need a lock on the region before
   // mutating.
   RecursiveMutex mutex_;
 };

third_party/WebKit/Source/platform/heap/ThreadState.cpp

@@ -197,7 +197,7 @@ void ThreadState::RunTerminationGC() {
 
   ReleaseStaticPersistentNodes();
 
-  ProcessHeap::GetCrossThreadPersistentRegion()
+  ProcessHeap::GetCrossThreadPersistentRegions()
       .PrepareForThreadStateTermination(this);
 
   // Do thread local GC's as long as the count of thread local Persistents
@@ -1265,13 +1265,13 @@ void ThreadState::CollectGarbage(BlinkGC::StackState stack_state,
   GCForbiddenScope gc_forbidden_scope(this);
 
   {
-    // Access to the CrossThreadPersistentRegion has to be prevented
+    // Access to the CrossThreadPersistentRegions has to be prevented
     // while in the marking phase because otherwise other threads may
     // allocate or free PersistentNodes and we can't handle
     // that. Grabbing this lock also prevents non-attached threads
     // from accessing any GCed heap while a GC runs.
-    CrossThreadPersistentRegion::LockScope persistent_lock(
-        ProcessHeap::GetCrossThreadPersistentRegion());
+    CrossThreadPersistentRegions::LockScope persistent_lock(
+        ProcessHeap::GetCrossThreadPersistentRegions());
 
     {
       TRACE_EVENT2("blink_gc,devtools.timeline", "BlinkGCMarking",