Revert "system-web-apps: better handle incognito in LaunchSystemWebApp"
This reverts commit de6bbcbc. Reason for revert: Broke SystemWebAppLaunchProfileBrowserTest tests https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/85648 Original change's description: > system-web-apps: better handle incognito in LaunchSystemWebApp > > LaunchSystemWebApp used whatever profile is provided in the parameter to > create SWA windows and launching SWAs, even if the profile may not > suitable to host a SWA window. > > This CL adds logic to determine the appropriate profile if the provided > one is unsuitable. This serves as a mid-term solution for launching > SWAs, and acts as a safety net to prevent chrome crashing if unsuitable > profiles are provided. > > Specifically, it catches these two types of profiles: > - Guest session "original" profile: launch into guest session's > primary off the record profile (which is used for guest session > browsing and SWAs). > - Normal session incognito profile: launch into the original profile, > because we don't support incognito SWAs. > > Fixed: 1109594 > Change-Id: Ibe4a3b1bf7c811ef1ee02fd967307ad9bf070ee7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423760 > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814602} TBR=ortuno@chromium.org,qjw@chromium.org Change-Id: Ie46ed4204f9c841be9d4dff8772fd2f9af85c96f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455747Reviewed-by:Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814626}
Showing
Please register or sign in to comment