Make panels turn on or off shadow effect.

This is needed for stacking panels. The foreground panel windows will turn off the shadow while the background stack window will provider the shadow.

BUG=223155,177770
TEST=none due to no functionality change yet

Review URL: https://codereview.chromium.org/13853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194615 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/ui/cocoa/panels/panel_cocoa.h

@@ -64,6 +64,7 @@ class PanelCocoa : public NativePanel {
 
   virtual void MinimizePanelBySystem() OVERRIDE;
   virtual bool IsPanelMinimizedBySystem() const OVERRIDE;
+  virtual void ShowShadow(bool show) OVERRIDE;
   virtual NativePanelTesting* CreateNativePanelTesting() OVERRIDE;
 
   Panel* panel() const;

chrome/browser/ui/cocoa/panels/panel_cocoa.mm

@@ -272,6 +272,10 @@ bool PanelCocoa::IsPanelMinimizedBySystem() const {
   return false;
 }
 
+void PanelCocoa::ShowShadow(bool show) {
+  [controller_ showShadow:show];
+}
+
 void PanelCocoa::PanelExpansionStateChanging(
     Panel::ExpansionState old_state, Panel::ExpansionState new_state) {
   [controller_ updateWindowLevel:(new_state != Panel::EXPANDED)];

chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h

@@ -137,6 +137,9 @@ class PanelCocoa;
 // Turns on user-resizable corners/sides indications and enables live resize.
 - (void)enableResizeByMouse:(BOOL)enable;
 
+// Turns on/off shadow effect around the window shape.
+- (void)showShadow:(BOOL)show;
+
 - (NSRect)frameRectForContentRect:(NSRect)contentRect;
 - (NSRect)contentRectForFrameRect:(NSRect)frameRect;
 

chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm

@@ -923,6 +923,12 @@ NSCursor* LoadWebKitCursor(WebKit::WebCursorInfo::Type type) {
   [[self window] invalidateCursorRectsForView:overlayView_];
 }
 
+- (void)showShadow:(BOOL)show {
+  if (![self isWindowLoaded])
+    return;
+  [[self window] setHasShadow:show];
+}
+
 // We have custom implementation of these because our titlebar height is custom
 // and does not match the standard one.
 - (NSRect)frameRectForContentRect:(NSRect)contentRect {

chrome/browser/ui/gtk/panels/panel_gtk.cc

@@ -326,6 +326,10 @@ bool PanelGtk::IsPanelMinimizedBySystem() const {
   return false;
 }
 
+void PanelGtk::ShowShadow(bool show) {
+  NOTIMPLEMENTED();
+}
+
 void PanelGtk::UpdateWindowShape() {
   int width = configure_size_.width();
   int height = configure_size_.height();

chrome/browser/ui/gtk/panels/panel_gtk.h

@@ -83,6 +83,7 @@ class PanelGtk : public NativePanel,
   virtual void SetWindowCornerStyle(panel::CornerStyle corner_style) OVERRIDE;
   virtual void MinimizePanelBySystem() OVERRIDE;
   virtual bool IsPanelMinimizedBySystem() const OVERRIDE;
+  virtual void ShowShadow(bool show) OVERRIDE;
 
   virtual NativePanelTesting* CreateNativePanelTesting() OVERRIDE;
 

chrome/browser/ui/panels/detached_panel_collection.cc

@@ -228,6 +228,7 @@ void DetachedPanelCollection::UpdatePanelOnCollectionChange(Panel* panel) {
       static_cast<Panel::AttentionMode>(Panel::USE_PANEL_ATTENTION |
                                         Panel::USE_SYSTEM_ATTENTION));
   panel->SetAlwaysOnTop(false);
+  panel->ShowShadow(true);
   panel->EnableResizeByMouse(true);
   panel->UpdateMinimizeRestoreButtonVisibility();
   panel->SetWindowCornerStyle(panel::ALL_ROUNDED);

chrome/browser/ui/panels/docked_panel_collection.cc

@@ -761,6 +761,7 @@ void DockedPanelCollection::CloseAll() {
 void DockedPanelCollection::UpdatePanelOnCollectionChange(Panel* panel) {
   panel->set_attention_mode(Panel::USE_PANEL_ATTENTION);
   panel->SetAlwaysOnTop(true);
+  panel->ShowShadow(true);
   panel->EnableResizeByMouse(true);
   panel->UpdateMinimizeRestoreButtonVisibility();
   panel->SetWindowCornerStyle(panel::TOP_ROUNDED);

chrome/browser/ui/panels/native_panel.h

@@ -88,6 +88,9 @@ class NativePanel {
   // iconic.
   virtual bool IsPanelMinimizedBySystem() const = 0;
 
+  // Turns on/off the shadow effect around the window shape.
+  virtual void ShowShadow(bool show) = 0;
+
   // Create testing interface for native panel. (Keep this last to separate
   // it from regular API.)
   virtual NativePanelTesting* CreateNativePanelTesting() = 0;

chrome/browser/ui/panels/panel.cc

@@ -306,6 +306,10 @@ bool Panel::IsMinimizedBySystem() const {
   return native_panel_->IsPanelMinimizedBySystem();
 }
 
+void Panel::ShowShadow(bool show) {
+  native_panel_->ShowShadow(show);
+}
+
 void Panel::Restore() {
   if (collection_)
     collection_->RestorePanel(this);

chrome/browser/ui/panels/panel.h

@@ -305,6 +305,9 @@ class Panel : public BaseWindow,
 
   bool IsMinimizedBySystem() const;
 
+  // Turns on/off the shadow effect around the window shape.
+  void ShowShadow(bool show);
+
  protected:
   // Panel can only be created using PanelManager::CreatePanel() or subclass.
   // |app_name| is the default title for Panels when the page content does not

chrome/browser/ui/panels/stacked_panel_collection.cc

@@ -522,6 +522,9 @@ void StackedPanelCollection::UpdatePanelOnCollectionChange(Panel* panel) {
       static_cast<Panel::AttentionMode>(Panel::USE_PANEL_ATTENTION |
                                         Panel::USE_SYSTEM_ATTENTION));
   panel->SetAlwaysOnTop(false);
+  // TODO(jianli): Change from true to false when the background window is used
+  // to provide the shadow.
+  panel->ShowShadow(true);
   panel->EnableResizeByMouse(true);
   panel->UpdateMinimizeRestoreButtonVisibility();
   UpdatePanelCornerStyle(panel);

chrome/browser/ui/views/panels/panel_view.cc

@@ -644,6 +644,19 @@ bool PanelView::IsPanelMinimizedBySystem() const {
   return window_->IsMinimized();
 }
 
+void PanelView::ShowShadow(bool show) {
+#if defined(OS_WIN)
+  // The overlapped window has the shadow while the popup window does not have
+  // the shadow.
+  int overlap_style = WS_OVERLAPPED | WS_THICKFRAME | WS_SYSMENU;
+  int popup_style = WS_POPUP;
+  UpdateWindowAttribute(GWL_STYLE,
+                        show ? overlap_style : popup_style,
+                        show ? popup_style : overlap_style,
+                        true);
+#endif
+}
+
 void PanelView::AttachWebContents(content::WebContents* contents) {
   web_view_->SetWebContents(contents);
 }

chrome/browser/ui/views/panels/panel_view.h

@@ -80,6 +80,7 @@ class PanelView : public NativePanel,
   virtual int TitleOnlyHeight() const OVERRIDE;
   virtual void MinimizePanelBySystem() OVERRIDE;
   virtual bool IsPanelMinimizedBySystem() const OVERRIDE;
+  virtual void ShowShadow(bool show) OVERRIDE;
   virtual NativePanelTesting* CreateNativePanelTesting() OVERRIDE;
 
   // Overridden from views::View: