Commit 6313de4b authored by Irem Uguz's avatar Irem Uguz Committed by Chromium LUCI CQ

Cert Provisioning: Improve a11y in cert provisioning details UI

Currently, screen-reader reads the field title and the values separately in the dialog page. However,the desired behaviour for screen-reader is to read out all information about a field in one-go for better user experience. This cl improves this behaviour.

Bug: 1157398
Change-Id: Icce01a076411c66c8aa667b7642fc48e9bb038b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602293Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Irem Uğuz <iremuguz@google.com>
Cr-Commit-Position: refs/heads/master@{#842444}
parent fb9bf167
...@@ -29,25 +29,41 @@ ...@@ -29,25 +29,41 @@
</div> </div>
<div slot="body"> <div slot="body">
<div class="two-line"> <div class="two-line">
<div class="label">[[i18n('certificateProvisioningProfileName')]]</div> <div class="label" aria-describedby="certProfileName">
<div class="value">[[model.certProfileName]]</div> [[i18n('certificateProvisioningProfileName')]]
</div>
<div class="value" id="certProfileName" aria-hidden="true">
[[model.certProfileName]]
</div>
</div> </div>
<div class="two-line"> <div class="two-line">
<div class="label">[[i18n('certificateProvisioningProfileId')]]</div> <div class="label" aria-describedby="certProfileId">
<div class="value">[[model.certProfileId]]</div> [[i18n('certificateProvisioningProfileId')]]
</div>
<div class="value" id="certProfileId" aria-hidden="true">
[[model.certProfileId]]
</div>
</div> </div>
<div class="button-box"> <div class="button-box">
<div class="two-line flex"> <div class="two-line flex">
<div class="label">[[i18n('certificateProvisioningStatus')]]</div> <div class="label" aria-describedby="status">
<span class="value">[[model.status]]</span> [[i18n('certificateProvisioningStatus')]]
</div>
<span class="value" id="status" aria-hidden="true">
[[model.status]]
</span>
</div> </div>
<cr-button id="refresh" role="button" on-click="onRefresh_"> <cr-button id="refresh" role="button" on-click="onRefresh_">
[[i18n('certificateProvisioningRefresh')]] [[i18n('certificateProvisioningRefresh')]]
</cr-button> </cr-button>
</div> </div>
<div class="two-line"> <div class="two-line">
<div class="label">[[i18n('certificateProvisioningLastUpdate')]]</div> <div class="label" aria-describedby="timeSinceLastUpdate">
<div class="value">[[model.timeSinceLastUpdate]]</div> [[i18n('certificateProvisioningLastUpdate')]]
</div>
<div class="value" id="timeSinceLastUpdate" aria-hidden="true">
[[model.timeSinceLastUpdate]]
</div>
</div> </div>
<hr></hr> <hr></hr>
<cr-expand-button expanded="{{advancedExpanded_}}" <cr-expand-button expanded="{{advancedExpanded_}}"
...@@ -56,12 +72,20 @@ ...@@ -56,12 +72,20 @@
</cr-expand-button> </cr-expand-button>
<iron-collapse id="advancedInfo" opened="[[advancedExpanded_]]"> <iron-collapse id="advancedInfo" opened="[[advancedExpanded_]]">
<div class="two-line"> <div class="two-line">
<div class="label">[[i18n('certificateProvisioningStatusId')]]</div> <div class="label" aria-describedby="stateId">
<div class="value">[[model.stateId]]</div> [[i18n('certificateProvisioningStatusId')]]
</div>
<div class="value" id="stateId" aria-hidden="true">
[[model.stateId]]
</div>
</div> </div>
<div class="two-line"> <div class="two-line">
<div class="label">[[i18n('certificateProvisioningPublicKey')]]</div> <div class="label" aria-describedby="publicKey">
<div class="value">[[model.publicKey]]</div> [[i18n('certificateProvisioningPublicKey')]]
</div>
<div class="value" id="publicKey" aria-hidden="true">
[[model.publicKey]]
</div>
</div> </div>
</iron-collapse> </iron-collapse>
</div> </div>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment