Commit 63246108 authored by Andrey Lushnikov's avatar Andrey Lushnikov Committed by Commit Bot

headless: create incognito profiles with Target.createBrowserContext

This patch starts creating off-the-record browser contexts in response
to the Target.createBrowserContext() command.

This should make no difference to the users, but has a few benefits for
us:
- alignes with the non-headless design of Target.createBrowserContext()
  method.
- avoids issues with cookie persistance (see BUG)
- saves some CPU cycles since we don't hit SQLite any more

BUG=836075
R=dgozman

Change-Id: I1d33c37e72bc9a2745eda0efae9947f94386417b
Reviewed-on: https://chromium-review.googlesource.com/1025402
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Reviewed-by: default avatarAlex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553657}
parent bb23fc7a
......@@ -74,8 +74,9 @@ Response TargetHandler::CloseTarget(const std::string& target_id,
}
Response TargetHandler::CreateBrowserContext(std::string* out_context_id) {
HeadlessBrowserContext* browser_context =
browser()->CreateBrowserContextBuilder().Build();
auto builder = browser()->CreateBrowserContextBuilder();
builder.SetIncognitoMode(true);
HeadlessBrowserContext* browser_context = builder.Build();
*out_context_id = browser_context->Id();
return Response::OK();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment