Commit 633cb4fe authored by dpapad's avatar dpapad Committed by Commit Bot

WebUI: Add JS type checking for more cr_elements/ tests, part 5.

Specifically:
  - cr_policy_indicator_behavior_tests.js
  - cr_policy_indicator_tests.js
  - cr_policy_pref_indicator_tests.js

Bug: 1000989
Change-Id: Iac363bccb89ca2508727ed8334b194dc867c60fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220280
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: default avatarJohn Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773445}
parent f50a6af4
......@@ -68,11 +68,12 @@ js_type_check("closure_compile") {
":cr_link_row_tests.m",
#":cr_lottie_tests",
#":cr_policy_indicator_behavior_tests",
#":cr_policy_indicator_tests",
#":cr_policy_network_indicator_tests",
#":cr_policy_pref_indicator_tests",
#":cr_policy_strings",
":cr_policy_indicator_behavior_tests.m",
":cr_policy_indicator_tests.m",
":cr_policy_pref_indicator_tests.m",
":cr_policy_strings",
#":cr_profile_avatar_selector_tests",
#":cr_radio_button_test",
#":cr_radio_group_test",
......@@ -94,6 +95,7 @@ js_type_check("closure_compile") {
deps += [
#":cr_policy_network_behavior_mojo_tests",
#":cr_policy_network_indicator_mojo_tests",
#":cr_policy_network_indicator_tests",
#":cr_searchable_drop_down_tests",
]
}
......@@ -279,3 +281,44 @@ js_library("cr_link_row_tests.m") {
externs_list = [ "$externs_path/mocha-2.5.js" ]
extra_deps = [ ":modulize" ]
}
js_library("cr_policy_indicator_behavior_tests.m") {
sources = [ "$root_gen_dir/chrome/test/data/webui/cr_elements/cr_policy_indicator_behavior_tests.m.js" ]
deps = [
"..:chai_assert",
"//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled",
"//ui/webui/resources/cr_elements/policy:cr_policy_indicator_behavior.m",
"//ui/webui/resources/js:cr.m",
]
externs_list = [ "$externs_path/mocha-2.5.js" ]
extra_deps = [ ":modulize" ]
}
js_library("cr_policy_indicator_tests.m") {
sources = [ "$root_gen_dir/chrome/test/data/webui/cr_elements/cr_policy_indicator_tests.m.js" ]
deps = [
"..:chai_assert",
"//ui/webui/resources/cr_elements/policy:cr_policy_indicator.m",
"//ui/webui/resources/cr_elements/policy:cr_policy_indicator_behavior.m",
"//ui/webui/resources/cr_elements/policy:cr_tooltip_icon.m",
"//ui/webui/resources/js:cr.m",
]
externs_list = [ "$externs_path/mocha-2.5.js" ]
extra_deps = [ ":modulize" ]
}
js_library("cr_policy_pref_indicator_tests.m") {
sources = [ "$root_gen_dir/chrome/test/data/webui/cr_elements/cr_policy_pref_indicator_tests.m.js" ]
deps = [
":cr_policy_strings",
"..:chai_assert",
"//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled",
"//ui/webui/resources/cr_elements/policy:cr_policy_pref_indicator.m",
"//ui/webui/resources/cr_elements/policy:cr_tooltip_icon.m",
]
externs_list = [ "$externs_path/mocha-2.5.js" ]
extra_deps = [ ":modulize" ]
}
js_library("cr_policy_strings") {
}
......@@ -8,7 +8,8 @@
// #import {CrPolicyIndicatorBehavior, CrPolicyIndicatorType} from 'chrome://resources/cr_elements/policy/cr_policy_indicator_behavior.m.js';
// #import {Polymer} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
// #import {isChromeOS} from 'chrome://resources/js/cr.m.js';
// #import 'chrome://test/cr_elements/cr_policy_strings.js';
// #import './cr_policy_strings.js';
// #import {assertEquals, assertFalse, assertTrue} from '../chai_assert.js';
// clang-format on
suite('CrPolicyIndicatorBehavior', function() {
......@@ -20,10 +21,13 @@ suite('CrPolicyIndicatorBehavior', function() {
});
});
/** @type {!TestIndicatorElement} */
let indicator;
setup(function() {
PolymerTest.clearBody();
indicator = document.createElement('test-indicator');
document.body.innerHTML = '';
indicator = /** @type {!TestIndicatorElement} */ (
document.createElement('test-indicator'));
document.body.appendChild(indicator);
});
......
......@@ -6,27 +6,26 @@
// #import {CrPolicyIndicatorType} from 'chrome://resources/cr_elements/policy/cr_policy_indicator_behavior.m.js';
// #import 'chrome://resources/cr_elements/policy/cr_policy_indicator.m.js';
// #import {isChromeOS} from 'chrome://resources/js/cr.m.js';
// #import 'chrome://test/cr_elements/cr_policy_strings.js';
// #import './cr_policy_strings.js';
// #import {assertEquals, assertFalse, assertTrue} from '../chai_assert.js';
// clang-format on
/** @fileoverview Suite of tests for cr-policy-indicator. */
suite('CrPolicyIndicator', function() {
/** @type {!CrPolicyIndicatorElement|undefined} */
/** @type {!CrPolicyIndicatorElement} */
let indicator;
/** @type {!CrTooltipIconElement|undefined} */
/** @type {!CrTooltipIconElement} */
let icon;
setup(function() {
PolymerTest.clearBody();
document.body.innerHTML = '';
indicator = document.createElement('cr-policy-indicator');
indicator = /** @type {!CrPolicyIndicatorElement} */ (
document.createElement('cr-policy-indicator'));
document.body.appendChild(indicator);
icon = indicator.$$('cr-tooltip-icon');
});
teardown(function() {
PolymerTest.clearBody(); // crbug.com/680169
icon =
/** @type {!CrTooltipIconElement} */ (indicator.$$('cr-tooltip-icon'));
});
test('none', function() {
......
......@@ -4,28 +4,27 @@
// clang-format off
// #import 'chrome://resources/cr_elements/policy/cr_policy_pref_indicator.m.js';
// #import 'chrome://test/cr_elements/cr_policy_strings.js';
// #import './cr_policy_strings.js';
// #import {flush} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
// #import {assertEquals, assertFalse, assertTrue} from '../chai_assert.js';
// clang-format on
/** @fileoverview Suite of tests for cr_policy-pref-indicator. */
suite('CrPolicyPrefIndicator', function() {
/** @type {!CrPolicyPrefIndicatorElement|undefined} */
/** @type {!CrPolicyPrefIndicatorElement} */
let indicator;
/** @type {!CrTooltipIconElement|undefined} */
/** @type {!CrTooltipIconElement} */
let icon;
setup(function() {
PolymerTest.clearBody();
document.body.innerHTML = '';
indicator = document.createElement('cr-policy-pref-indicator');
indicator = /** @type {!CrPolicyPrefIndicatorElement} */ (
document.createElement('cr-policy-pref-indicator'));
document.body.appendChild(indicator);
icon = indicator.$$('cr-tooltip-icon');
});
teardown(function() {
PolymerTest.clearBody(); // crbug.com/680169
icon =
/** @type {!CrTooltipIconElement} */ (indicator.$$('cr-tooltip-icon'));
});
test('none', function() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment