Commit 63495bd7 authored by Roman Arora's avatar Roman Arora Committed by Commit Bot

Tab Search: Show feedback page API

Mojo bindings and API to show the feedback page.

Bug: 1099917
Change-Id: Ie1fd176f67d069b1eb7b9bed1db79751ea4c6df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356971Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarThomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799886}
parent d572640f
...@@ -52,6 +52,7 @@ bool IsFromUserInteraction(FeedbackSource source) { ...@@ -52,6 +52,7 @@ bool IsFromUserInteraction(FeedbackSource source) {
case kFeedbackSourceDesktopTabGroups: case kFeedbackSourceDesktopTabGroups:
case kFeedbackSourceMdSettingsAboutPage: case kFeedbackSourceMdSettingsAboutPage:
case kFeedbackSourceOldSettingsAboutPage: case kFeedbackSourceOldSettingsAboutPage:
case kFeedbackSourceTabSearch:
return true; return true;
default: default:
return false; return false;
......
...@@ -65,6 +65,7 @@ enum FeedbackSource { ...@@ -65,6 +65,7 @@ enum FeedbackSource {
kFeedbackSourceHelpApp, kFeedbackSourceHelpApp,
kFeedbackSourceKaleidoscope, kFeedbackSourceKaleidoscope,
kFeedbackSourceNetworkHealthPage, kFeedbackSourceNetworkHealthPage,
kFeedbackSourceTabSearch,
// Must be last. // Must be last.
kFeedbackSourceCount, kFeedbackSourceCount,
......
...@@ -64,6 +64,9 @@ interface PageHandler { ...@@ -64,6 +64,9 @@ interface PageHandler {
// Get tab groups for the current profile. // Get tab groups for the current profile.
GetTabGroups() => (TabGroups tab_groups); GetTabGroups() => (TabGroups tab_groups);
// Show the feedback page.
ShowFeedbackPage();
// Switch to a specific tab. // Switch to a specific tab.
SwitchToTab(SwitchToTabInfo switch_to_tab_info); SwitchToTab(SwitchToTabInfo switch_to_tab_info);
}; };
......
...@@ -19,6 +19,7 @@ ...@@ -19,6 +19,7 @@
#include "chrome/browser/ui/browser_finder.h" #include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/tabs/tab_renderer_data.h" #include "chrome/browser/ui/tabs/tab_renderer_data.h"
#include "chrome/browser/ui/webui/util/image_util.h" #include "chrome/browser/ui/webui/util/image_util.h"
...@@ -125,6 +126,15 @@ void TabSearchPageHandler::GetTabGroups(GetTabGroupsCallback callback) { ...@@ -125,6 +126,15 @@ void TabSearchPageHandler::GetTabGroups(GetTabGroupsCallback callback) {
NOTIMPLEMENTED(); NOTIMPLEMENTED();
} }
void TabSearchPageHandler::ShowFeedbackPage() {
chrome::ShowFeedbackPage(browser_,
chrome::FeedbackSource::kFeedbackSourceTabSearch,
std::string() /* description_template */,
std::string() /* description_placeholder_text */,
std::string("FromTabSearch") /* category_tag */,
std::string() /* extra_diagnostics */);
}
void TabSearchPageHandler::SwitchToTab( void TabSearchPageHandler::SwitchToTab(
tab_search::mojom::SwitchToTabInfoPtr switch_to_tab_info) { tab_search::mojom::SwitchToTabInfoPtr switch_to_tab_info) {
base::Optional<TabDetails> optional_details = base::Optional<TabDetails> optional_details =
......
...@@ -45,6 +45,7 @@ class TabSearchPageHandler : public tab_search::mojom::PageHandler, ...@@ -45,6 +45,7 @@ class TabSearchPageHandler : public tab_search::mojom::PageHandler,
void CloseTab(int32_t tab_id) override; void CloseTab(int32_t tab_id) override;
void GetProfileTabs(GetProfileTabsCallback callback) override; void GetProfileTabs(GetProfileTabsCallback callback) override;
void GetTabGroups(GetTabGroupsCallback callback) override; void GetTabGroups(GetTabGroupsCallback callback) override;
void ShowFeedbackPage() override;
void SwitchToTab( void SwitchToTab(
tab_search::mojom::SwitchToTabInfoPtr switch_to_tab_info) override; tab_search::mojom::SwitchToTabInfoPtr switch_to_tab_info) override;
......
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#include "chrome/browser/ui/webui/tab_search/tab_search_page_handler.h" #include "chrome/browser/ui/webui/tab_search/tab_search_page_handler.h"
#include "base/test/bind_test_util.h" #include "base/test/bind_test_util.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/timer/mock_timer.h" #include "base/timer/mock_timer.h"
#include "chrome/browser/extensions/extension_tab_util.h" #include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/ui/browser_commands.h" #include "chrome/browser/ui/browser_commands.h"
...@@ -300,4 +301,10 @@ TEST_F(TabSearchPageHandlerTest, CloseTab) { ...@@ -300,4 +301,10 @@ TEST_F(TabSearchPageHandlerTest, CloseTab) {
ASSERT_EQ(1, browser2()->tab_strip_model()->count()); ASSERT_EQ(1, browser2()->tab_strip_model()->count());
} }
TEST_F(TabSearchPageHandlerTest, ShowFeedbackPage) {
base::HistogramTester histogram_tester;
handler()->ShowFeedbackPage();
histogram_tester.ExpectTotalCount("Feedback.RequestSource", 1);
}
} // namespace } // namespace
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment