Commit 6357cb84 authored by Steven Bennetts's avatar Steven Bennetts Committed by Commit Bot

Internet: VPN Config: Elim policy indicator for provider type

When we switched to using an unmanaged enum for vpn.type (which is an
intrinsic / immutable property of a configured VPN), it broke the
policy indicator for the type selector, which assumes that the
'property' property will be a managed type (e.g. ManagedString).

Since the provider type can not be changed, it is not useful to
show the policy indicator for policy managed networks (the provider
type must be provided by the policy). Therefore we should just leave
'property' undefined for that network-config-select element.

Bug: 1035581
Change-Id: I47704adff49fa1063eab5e93a8654645a2ec1893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976492Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726476}
parent c626584f
......@@ -75,8 +75,7 @@
</network-config-input>
<network-config-select id="outer" label="[[i18n('OncVPN-Type')]]"
value="{{vpnType_}}" items="[[vpnTypeItems_]]"
onc-prefix="VPN.Type" disabled="[[hasGuid_(guid)]]"
property="[[managedProperties_.typeProperties.vpn.type]]">
onc-prefix="VPN.Type" disabled="[[hasGuid_(guid)]]">
</network-config-select>
<template is="dom-if" if="[[!showVpn_.OpenVPN]]">
<network-config-input label="[[i18n('OncVPN-L2TP-Username')]]"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment