Commit 635a777e authored by Raphael Kubo da Costa's avatar Raphael Kubo da Costa Committed by Commit Bot

bindings: Use V8SetReturnValueNull() in the custom bindings.

Small simplification that should not have any user-visible effects.

Change-Id: I93764d578de2e6e84c013f5e8a44392d0938835b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941887
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719954}
parent 8b55a5e8
...@@ -35,7 +35,7 @@ void V8PromiseRejectionEvent::PromiseAttributeGetterCustom( ...@@ -35,7 +35,7 @@ void V8PromiseRejectionEvent::PromiseAttributeGetterCustom(
ScriptPromise promise = event->promise(ScriptState::Current(isolate)); ScriptPromise promise = event->promise(ScriptState::Current(isolate));
if (promise.IsEmpty()) { if (promise.IsEmpty()) {
V8SetReturnValue(info, v8::Null(isolate)); V8SetReturnValueNull(info);
return; return;
} }
......
...@@ -79,7 +79,7 @@ void V8XMLHttpRequest::ResponseAttributeGetterCustom( ...@@ -79,7 +79,7 @@ void V8XMLHttpRequest::ResponseAttributeGetterCustom(
v8::Local<v8::String> json_source = v8::Local<v8::String> json_source =
xml_http_request->ResponseJSONSource(); xml_http_request->ResponseJSONSource();
if (json_source.IsEmpty()) { if (json_source.IsEmpty()) {
V8SetReturnValue(info, v8::Null(isolate)); V8SetReturnValueNull(info);
return; return;
} }
...@@ -90,7 +90,7 @@ void V8XMLHttpRequest::ResponseAttributeGetterCustom( ...@@ -90,7 +90,7 @@ void V8XMLHttpRequest::ResponseAttributeGetterCustom(
ToCoreString(json_source), exception_state); ToCoreString(json_source), exception_state);
if (exception_state.HadException()) { if (exception_state.HadException()) {
exception_state.ClearException(); exception_state.ClearException();
V8SetReturnValue(info, v8::Null(isolate)); V8SetReturnValueNull(info);
} else { } else {
V8SetReturnValue(info, json); V8SetReturnValue(info, json);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment