[chromecast] Introduce cast_source_set

The main changes are in chromecast/chromecast.gni

The rest of the files were modified with these commands:

- Change source_set -> cast_source_set
git ls-files "chromecast/*.gn" | xargs sed -i 's/source_set(/cast_source_set(/g'

- Include chromecast.gni for any GN files missing it
git ls-files "chromecast/*.gn" | xargs grep -L '//chromecast/chromecast.gni' | xargs grep -l 'source_set' | xargs -L1 ~/src/scratch/add_line_after_first_comment.py 'import(' '"//chromecast/chromecast.gni")'

add_line_after_first_comment.py can be found under
chromecast/internal/tools

BUG=b/68723969
TEST=Build and run

Change-Id: I38a06ac4d8a45ebc7963b58e5a2db81fde84e635
Reviewed-on: https://chromium-review.googlesource.com/747894Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513035}

chromecast/BUILD.gn

@@ -44,6 +44,11 @@ group("all") {
   testonly = true
 }
 
+# This is a config which is applied on all cast_* targets (which should be all
+# code under chromecast/).
+config("cast_config") {
+}
+
 # A list of all public test() binaries. This is an organizational target that
 # cannot be depended upon or built directly. Build cast_test_lists instead.
 cast_test_group("cast_tests") {

chromecast/app/BUILD.gn

@@ -6,7 +6,7 @@ import("//chromecast/chromecast.gni")
 import("//testing/test.gni")
 import("//tools/grit/grit_rule.gni")
 
-source_set("app") {
+cast_source_set("app") {
   sources = [
     "cast_main_delegate.cc",
     "cast_main_delegate.h",
@@ -32,7 +32,7 @@ source_set("app") {
   }
 }
 
-source_set("cast_crash_client") {
+cast_source_set("cast_crash_client") {
   sources = [
     "android/cast_crash_reporter_client_android.cc",
     "android/cast_crash_reporter_client_android.h",
@@ -67,7 +67,7 @@ source_set("cast_crash_client") {
   }
 }
 
-source_set("test_support") {
+cast_source_set("test_support") {
   testonly = true
   sources = [
     "cast_test_launcher.cc",
@@ -84,7 +84,7 @@ source_set("test_support") {
   ]
 }
 
-source_set("unittests") {
+cast_source_set("unittests") {
   testonly = true
   sources = [
     "linux/cast_crash_reporter_client_unittest.cc",

chromecast/base/BUILD.gn

@@ -36,7 +36,7 @@ if (is_android_arc) {
          cast_product_type != 7)
 }
 
-source_set("base") {
+cast_source_set("base") {
   sources = [
     "alarm_manager.cc",
     "alarm_manager.h",
@@ -95,7 +95,7 @@ source_set("base") {
 # b/30398176 components that depend on switch values should depend on
 # this target directly instead of depend on //chromecast/base to avoid
 # unnecessary size increase.
-source_set("chromecast_switches") {
+cast_source_set("chromecast_switches") {
   sources = [
     "chromecast_switches.cc",
     "chromecast_switches.h",
@@ -109,7 +109,7 @@ source_set("chromecast_switches") {
 # command line initialization code for shared libs
 # b/30398176 shared libs that depend on InitCommandLineShlib() only should
 # use this target instead of //chromecast/base
-source_set("init_shlib") {
+cast_source_set("init_shlib") {
   sources = [
     "init_command_line_shlib.cc",
     "init_command_line_shlib.h",
@@ -120,7 +120,7 @@ source_set("init_shlib") {
   ]
 }
 
-source_set("test_support") {
+cast_source_set("test_support") {
   sources = [
     "scoped_temp_file.cc",
     "scoped_temp_file.h",
@@ -157,7 +157,7 @@ test("cast_base_unittests") {
   ]
 }
 
-source_set("cast_sys_info") {
+cast_source_set("cast_sys_info") {
   sources = [
     "cast_sys_info_android.cc",
     "cast_sys_info_android.h",
@@ -196,7 +196,7 @@ cast_shared_library("libcast_sys_info_1.0") {
 }
 
 # Note: Android links //chromecast/base:cast_sys_info statically.
-source_set("cast_sys_info_shlib") {
+cast_source_set("cast_sys_info_shlib") {
   if (!is_android) {
     sources = [
       "cast_sys_info_util_shlib.cc",
@@ -211,7 +211,7 @@ source_set("cast_sys_info_shlib") {
   }
 }
 
-source_set("thread_health_checker") {
+cast_source_set("thread_health_checker") {
   sources = [
     "thread_health_checker.cc",
     "thread_health_checker.h",

chromecast/base/component/BUILD.gn

@@ -5,7 +5,7 @@
 import("//chromecast/chromecast.gni")
 import("//testing/test.gni")
 
-source_set("component") {
+cast_source_set("component") {
   sources = [
     "component.cc",
     "component.h",

chromecast/base/metrics/BUILD.gn

@@ -2,7 +2,9 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("metrics") {
+import("//chromecast/chromecast.gni")
+
+cast_source_set("metrics") {
   sources = [
     "cast_histograms.h",
     "cast_metrics_helper.cc",
@@ -16,7 +18,7 @@ source_set("metrics") {
   ]
 }
 
-source_set("test_support") {
+cast_source_set("test_support") {
   testonly = true
 
   sources = [

chromecast/browser/BUILD.gn

@@ -13,7 +13,7 @@ if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
-source_set("browser") {
+cast_source_set("browser") {
   sources = [
     "cast_browser_context.cc",
     "cast_browser_context.h",
@@ -253,7 +253,7 @@ grit("resources") {
   ]
 }
 
-source_set("test_support") {
+cast_source_set("test_support") {
   testonly = true
   sources = [
     "test/cast_browser_test.cc",
@@ -274,7 +274,7 @@ source_set("test_support") {
   ]
 }
 
-source_set("browsertests") {
+cast_source_set("browsertests") {
   testonly = true
   sources = [
     "cast_media_blocker_browsertest.cc",
@@ -296,7 +296,7 @@ source_set("browsertests") {
   ]
 }
 
-source_set("unittests") {
+cast_source_set("unittests") {
   testonly = true
 
   sources = [

chromecast/browser/metrics/BUILD.gn

@@ -2,7 +2,9 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("metrics") {
+import("//chromecast/chromecast.gni")
+
+cast_source_set("metrics") {
   sources = [
     "cast_metrics_prefs.cc",
     "cast_metrics_prefs.h",

chromecast/chromecast.gni

@@ -84,14 +84,21 @@ foreach(target_type,
           "executable",
           "shared_library",
           "loadable_module",
+          "source_set",
         ]) {
   template("cast_${target_type}") {
     target(target_type, target_name) {
       forward_variables_from(invoker, "*")
+
+      configs += [ "//chromecast:cast_config" ]
+
       if (!defined(deps)) {
         deps = []
       }
-      deps += [ "//build/config:exe_and_shlib_deps" ]
+
+      if (target_type != "source_set") {
+        deps += [ "//build/config:exe_and_shlib_deps" ]
+      }
     }
   }
 }
@@ -116,3 +123,7 @@ set_defaults("cast_loadable_module") {
     configs -= [ "//build/config/android:hide_all_but_jni_onload" ]
   }
 }
+
+set_defaults("cast_source_set") {
+  configs = default_compiler_configs
+}

chromecast/common/BUILD.gn

@@ -2,9 +2,10 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//chromecast/chromecast.gni")
 import("//mojo/public/tools/bindings/mojom.gni")
 
-source_set("common") {
+cast_source_set("common") {
   sources = [
     "cast_content_client.cc",
     "cast_content_client.h",

chromecast/common/media/BUILD.gn

@@ -5,7 +5,7 @@
 import("//chromecast/chromecast.gni")
 import("//mojo/public/tools/bindings/mojom.gni")
 
-source_set("media") {
+cast_source_set("media") {
   if (is_android) {
     sources = [
       "cast_media_drm_bridge_client.cc",

chromecast/crash/BUILD.gn

@@ -9,7 +9,7 @@ import("//testing/test.gni")
 # TODO(crbug.com/753619): Enable crash reporting on Fuchsia.
 assert(!is_fuchsia)
 
-source_set("crash") {
+cast_source_set("crash") {
   sources = [
     "app_state_tracker.cc",
     "app_state_tracker.h",
@@ -71,7 +71,7 @@ cast_executable("crash_uploader") {
   }
 }
 
-source_set("test_support") {
+cast_source_set("test_support") {
   sources = [
     "linux/crash_testing_utils.cc",
     "linux/crash_testing_utils.h",

chromecast/crypto/BUILD.gn

@@ -2,9 +2,10 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//chromecast/chromecast.gni")
 import("//testing/test.gni")
 
-source_set("crypto") {
+cast_source_set("crypto") {
   sources = [
     "signature_cache.cc",
     "signature_cache.h",

chromecast/graphics/BUILD.gn

@@ -6,7 +6,7 @@ import("//chromecast/chromecast.gni")
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 
-source_set("graphics") {
+cast_source_set("graphics") {
   sources = [
     "cast_window_manager.h",
   ]

chromecast/media/audio/BUILD.gn

@@ -2,9 +2,10 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//chromecast/chromecast.gni")
 import("//media/media_options.gni")
 
-source_set("audio") {
+cast_source_set("audio") {
   sources = [
     "cast_audio_manager.cc",
     "cast_audio_manager.h",

chromecast/media/base/BUILD.gn

@@ -4,7 +4,7 @@
 
 import("//chromecast/chromecast.gni")
 
-source_set("key_systems") {
+cast_source_set("key_systems") {
   sources = [
     "key_systems_common.cc",
     "key_systems_common.h",
@@ -22,7 +22,7 @@ source_set("key_systems") {
   ]
 }
 
-source_set("base") {
+cast_source_set("base") {
   sources = [
     "audio_device_ids.cc",
     "audio_device_ids.h",
@@ -64,7 +64,7 @@ source_set("base") {
   ]
 }
 
-source_set("media_resource_tracker") {
+cast_source_set("media_resource_tracker") {
   sources = [
     "media_resource_tracker.cc",
     "media_resource_tracker.h",
@@ -77,7 +77,7 @@ source_set("media_resource_tracker") {
   ]
 }
 
-source_set("media_codec_support") {
+cast_source_set("media_codec_support") {
   sources = [
     "media_codec_support.cc",
     "media_codec_support.h",
@@ -93,7 +93,7 @@ source_set("media_codec_support") {
   ]
 }
 
-source_set("video_plane_controller") {
+cast_source_set("video_plane_controller") {
   sources = [
     "video_plane_controller.cc",
     "video_plane_controller.h",

chromecast/media/cdm/BUILD.gn

@@ -5,7 +5,7 @@
 import("//chromecast/chromecast.gni")
 import("//media/media_options.gni")
 
-source_set("cdm") {
+cast_source_set("cdm") {
   sources = [
     "chromecast_init_data.cc",
     "chromecast_init_data.h",

chromecast/media/cma/BUILD.gn

@@ -14,7 +14,7 @@ group("cma") {
   ]
 }
 
-source_set("test_support") {
+cast_source_set("test_support") {
   testonly = true
   sources = [
     "test/frame_generator_for_test.cc",
@@ -42,7 +42,7 @@ source_set("test_support") {
   ]
 }
 
-source_set("unittests") {
+cast_source_set("unittests") {
   testonly = true
   sources = [
     "backend/audio_video_pipeline_device_unittest.cc",

chromecast/media/cma/backend/BUILD.gn

@@ -16,7 +16,7 @@ declare_args() {
       use_alsa && !enable_assistant && chromecast_branding != "google"
 }
 
-source_set("backend") {
+cast_source_set("backend") {
   sources = [
     "audio_decoder_wrapper.cc",
     "audio_decoder_wrapper.h",
@@ -42,7 +42,7 @@ source_set("backend") {
   ]
 }
 
-source_set("cast_media_android_dummy") {
+cast_source_set("cast_media_android_dummy") {
   sources = [
     "cast_media_android_dummy.cc",
   ]
@@ -71,7 +71,7 @@ cast_shared_library("libcast_media_1.0") {
 
 # Dummy implementation of media backend used on chromecast devices.
 # Must not depend on anything outside //chromecast/public.
-source_set("dummy") {
+cast_source_set("dummy") {
   sources = [
     "cast_media_dummy.cc",
   ]
@@ -92,7 +92,7 @@ buildflag_header("audio_features") {
 
 # Implementation of video decoder that discards decoder buffers.
 # Used on audio platforms for media streams containing video.
-source_set("null") {
+cast_source_set("null") {
   sources = [
     "video_decoder_null.cc",
     "video_decoder_null.h",
@@ -104,7 +104,7 @@ source_set("null") {
   ]
 }
 
-source_set("audio") {
+cast_source_set("audio") {
   sources = [
     "audio_decoder_for_mixer.cc",
     "audio_decoder_for_mixer.h",
@@ -191,7 +191,7 @@ cast_shared_library("libcast_governor_1.0") {
   ]
 }
 
-source_set("governor") {
+cast_source_set("governor") {
   sources = [
     "post_processors/governor.cc",
     "post_processors/governor.h",
@@ -215,7 +215,7 @@ cast_shared_library("libcast_saturated_gain_1.0") {
   ]
 }
 
-source_set("saturated_gain") {
+cast_source_set("saturated_gain") {
   sources = [
     "post_processors/saturated_gain.cc",
     "post_processors/saturated_gain.h",

chromecast/media/cma/backend/alsa/BUILD.gn

@@ -26,7 +26,7 @@ cast_shared_library("libcast_media_1.0_audio") {
   ]
 }
 
-source_set("alsa_cma_backend") {
+cast_source_set("alsa_cma_backend") {
   sources = [
     "alsa_volume_control.cc",
     "alsa_volume_control.h",
@@ -51,7 +51,7 @@ source_set("alsa_cma_backend") {
   ]
 }
 
-source_set("unit_tests") {
+cast_source_set("unit_tests") {
   testonly = true
   sources = [
     # TODO(sergeyu): Remove ALSA dependency from these tests and move them
@@ -71,7 +71,7 @@ source_set("unit_tests") {
   ]
 }
 
-source_set("test_support") {
+cast_source_set("test_support") {
   testonly = true
 
   sources = [

chromecast/media/cma/backend/android/BUILD.gn

@@ -6,7 +6,7 @@ import("//build/config/android/config.gni")
 import("//build/config/android/rules.gni")
 import("//chromecast/chromecast.gni")
 
-source_set("cast_media_android") {
+cast_source_set("cast_media_android") {
   sources = [
     "audio_decoder_android.cc",
     "audio_decoder_android.h",

chromecast/media/cma/backend/desktop/BUILD.gn

@@ -2,8 +2,10 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//chromecast/chromecast.gni")
+
 # Default implementation of media backend used on desktop builds for tests.
-source_set("desktop") {
+cast_source_set("desktop") {
   sources = [
     "audio_decoder_desktop.cc",
     "audio_decoder_desktop.h",

chromecast/media/cma/backend/fuchsia/BUILD.gn

@@ -8,7 +8,7 @@ import("//testing/test.gni")
 
 assert(is_fuchsia)
 
-source_set("fuchsia") {
+cast_source_set("fuchsia") {
   sources = [
     "cast_media_shlib_fuchsia.cc",
     "fuchsia_volume_control.cc",
@@ -28,7 +28,7 @@ source_set("fuchsia") {
   libs = [ "media_client" ]
 }
 
-source_set("unit_tests") {
+cast_source_set("unit_tests") {
   testonly = true
   sources = [
     "mixer_output_stream_fuchsia_unittest.cc",

chromecast/media/cma/backend/post_processors/BUILD.gn

@@ -2,7 +2,9 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("test_support") {
+import("//chromecast/chromecast.gni")
+
+cast_source_set("test_support") {
   testonly = true
   sources = [
     "post_processor_unittest.cc",

chromecast/media/cma/base/BUILD.gn

@@ -2,7 +2,9 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("base") {
+import("//chromecast/chromecast.gni")
+
+cast_source_set("base") {
   sources = [
     "balanced_media_task_runner_factory.cc",
     "balanced_media_task_runner_factory.h",

chromecast/media/cma/decoder/BUILD.gn

@@ -2,7 +2,9 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("decoder") {
+import("//chromecast/chromecast.gni")
+
+cast_source_set("decoder") {
   sources = [
     "cast_audio_decoder.cc",
     "cast_audio_decoder.h",

chromecast/media/cma/pipeline/BUILD.gn

@@ -2,6 +2,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//chromecast/chromecast.gni")
 import("//build/buildflag_header.gni")
 import("//build/config/chromecast_build.gni")
 
@@ -10,7 +11,7 @@ declare_args() {
   cma_use_accurate_media_time = is_cast_audio_only
 }
 
-source_set("pipeline") {
+cast_source_set("pipeline") {
   sources = [
     "audio_decoder_software_wrapper.cc",
     "audio_decoder_software_wrapper.h",

chromecast/media/service/BUILD.gn

@@ -2,7 +2,9 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("service") {
+import("//chromecast/chromecast.gni")
+
+cast_source_set("service") {
   sources = [
     "cast_mojo_media_client.cc",
     "cast_mojo_media_client.h",

chromecast/net/BUILD.gn

@@ -2,9 +2,10 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//chromecast/chromecast.gni")
 import("//testing/test.gni")
 
-source_set("net") {
+cast_source_set("net") {
   sources = [
     "connectivity_checker.cc",
     "connectivity_checker.h",
@@ -36,7 +37,7 @@ source_set("net") {
   ]
 }
 
-source_set("test_support") {
+cast_source_set("test_support") {
   testonly = true
 
   sources = [

chromecast/public/BUILD.gn

@@ -2,11 +2,13 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//chromecast/chromecast.gni")
+
 config("public_config") {
   include_dirs = [ "//chromecast/public" ]
 }
 
-source_set("public") {
+cast_source_set("public") {
   sources = [
     "avsettings.h",
     "cast_egl_platform.h",

chromecast/public/media/BUILD.gn

@@ -2,7 +2,9 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("media") {
+import("//chromecast/chromecast.gni")
+
+cast_source_set("media") {
   sources = [
     "audio_post_processor_shlib.h",
     "cast_decoder_buffer.h",

chromecast/renderer/BUILD.gn

@@ -4,7 +4,7 @@
 
 import("//chromecast/chromecast.gni")
 
-source_set("renderer") {
+cast_source_set("renderer") {
   sources = [
     "cast_content_renderer_client.cc",
     "cast_content_renderer_client.h",

chromecast/renderer/media/BUILD.gn

@@ -2,7 +2,9 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("media") {
+import("//chromecast/chromecast.gni")
+
+cast_source_set("media") {
   sources = [
     "key_systems_cast.cc",
     "key_systems_cast.h",

chromecast/service/BUILD.gn

@@ -2,7 +2,9 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("service") {
+import("//chromecast/chromecast.gni")
+
+cast_source_set("service") {
   sources = [
     "cast_service.cc",
     "cast_service.h",

chromecast/system/reboot/BUILD.gn

@@ -5,7 +5,7 @@
 import("//chromecast/chromecast.gni")
 import("//testing/test.gni")
 
-source_set("reboot_util") {
+cast_source_set("reboot_util") {
   sources = [
     "reboot_util.h",
     "reboot_util_core.cc",

chromecast/utility/BUILD.gn

@@ -4,7 +4,7 @@
 
 import("//chromecast/chromecast.gni")
 
-source_set("utility") {
+cast_source_set("utility") {
   sources = [
     "cast_content_utility_client.h",
   ]