Last files: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

Most of the callsites have been converted, with only
https://codereview.chromium.org/2317123003/ remaining as the last big chunk,
but in the meantime new uses of path() crept in.

BUG=640599
TBR=danakj@chromium.org, petewil@chromium.org, siggi@chromium.org,

Review-Url: https://codereview.chromium.org/2347673002
Cr-Commit-Position: refs/heads/master@{#418932}

base/win/shortcut_unittest.cc

@@ -57,7 +57,7 @@ class ShortcutTest : public testing::Test {
       CreateTemporaryFileInDir(temp_dir_.GetPath(), &icon_path_2);
 
       link_properties_2_.set_target(target_file_2);
-      link_properties_2_.set_working_dir(temp_dir_2_.path());
+      link_properties_2_.set_working_dir(temp_dir_2_.GetPath());
       link_properties_2_.set_arguments(L"--super --crazy");
       link_properties_2_.set_description(L"The best in the west.");
       link_properties_2_.set_icon(icon_path_2, 0);

components/browser_watcher/postmortem_minidump_writer_win_unittest.cc

@@ -43,7 +43,7 @@ class WritePostmortemDumpTest : public testing::Test {
 
     // Write the minidump.
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
-    minidump_path_ = temp_dir_.path().AppendASCII("minidump.dmp");
+    minidump_path_ = temp_dir_.GetPath().AppendASCII("minidump.dmp");
   }
 
   bool WriteDump() {

components/offline_pages/offline_page_metadata_store_impl_unittest.cc

@@ -383,7 +383,7 @@ OfflinePageMetadataStoreTest::BuildStoreWithSchemaFromM53() {
 std::unique_ptr<OfflinePageMetadataStore>
 OfflinePageMetadataStoreTest::BuildStoreWithSchemaFromM54() {
   std::unique_ptr<OfflinePageMetadataStore> store(
-      factory_.BuildStoreM53(temp_directory_.path()));
+      factory_.BuildStoreM53(temp_directory_.GetPath()));
   store->GetOfflinePages(
       base::Bind(&OfflinePageMetadataStoreTest::GetOfflinePagesCallback,
                  base::Unretained(this)));