Commit 63b4d83f authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Move pdf/ppapi_migration code into its own target.

Move more code that depends on PPAPI out of the "internal" build target.

Bug: 1103478
Change-Id: Ifa7b2ca0565a261ca0493d97dab9bf216d47f35f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308490
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: default avatarDaniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790576}
parent d9e64e11
...@@ -121,14 +121,6 @@ if (enable_pdf) { ...@@ -121,14 +121,6 @@ if (enable_pdf) {
"pdfium/pdfium_range.h", "pdfium/pdfium_range.h",
"pdfium/pdfium_unsupported_features.cc", "pdfium/pdfium_unsupported_features.cc",
"pdfium/pdfium_unsupported_features.h", "pdfium/pdfium_unsupported_features.h",
"ppapi_migration/bitmap.cc",
"ppapi_migration/bitmap.h",
"ppapi_migration/callback.cc",
"ppapi_migration/callback.h",
"ppapi_migration/geometry_conversions.cc",
"ppapi_migration/geometry_conversions.h",
"ppapi_migration/input_event_conversions.cc",
"ppapi_migration/input_event_conversions.h",
"preview_mode_client.cc", "preview_mode_client.cc",
"preview_mode_client.h", "preview_mode_client.h",
"range_set.cc", "range_set.cc",
...@@ -142,6 +134,7 @@ if (enable_pdf) { ...@@ -142,6 +134,7 @@ if (enable_pdf) {
deps = [ deps = [
":features", ":features",
":ppapi_migration",
"//base", "//base",
"//base:i18n", "//base:i18n",
"//gin", "//gin",
...@@ -174,12 +167,37 @@ if (enable_pdf) { ...@@ -174,12 +167,37 @@ if (enable_pdf) {
deps = [ deps = [
":internal", ":internal",
":pdf", ":pdf",
":ppapi_migration",
"//ppapi/c", "//ppapi/c",
"//third_party/pdfium", "//third_party/pdfium",
"//ui/base", "//ui/base",
] ]
} }
source_set("ppapi_migration") {
visibility = [ ":*" ]
sources = [
"ppapi_migration/bitmap.cc",
"ppapi_migration/bitmap.h",
"ppapi_migration/callback.cc",
"ppapi_migration/callback.h",
"ppapi_migration/geometry_conversions.cc",
"ppapi_migration/geometry_conversions.h",
"ppapi_migration/input_event_conversions.cc",
"ppapi_migration/input_event_conversions.h",
]
configs += [ ":pdf_common_config" ]
deps = [
"//base",
"//ppapi/cpp:objects",
"//skia",
"//ui/base",
]
}
source_set("out_of_process_instance") { source_set("out_of_process_instance") {
visibility = [ ":*" ] visibility = [ ":*" ]
...@@ -193,6 +211,7 @@ if (enable_pdf) { ...@@ -193,6 +211,7 @@ if (enable_pdf) {
deps = [ deps = [
":features", ":features",
":internal", ":internal",
":ppapi_migration",
"//base", "//base",
"//net", "//net",
"//ppapi/cpp:objects", "//ppapi/cpp:objects",
...@@ -265,6 +284,7 @@ if (enable_pdf) { ...@@ -265,6 +284,7 @@ if (enable_pdf) {
":out_of_process_instance", ":out_of_process_instance",
":pdf", ":pdf",
":pdf_test_utils", ":pdf_test_utils",
":ppapi_migration",
"//base", "//base",
"//base/test:run_all_unittests", "//base/test:run_all_unittests",
"//base/test:test_support", "//base/test:test_support",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment