Skip to content

GitLab

T
tangled
Commit 63dc3d89 authored by Ching-Kang Yen's avatar Ching-Kang Yen Committed by Chromium LUCI CQ
Browse files
Options

Add trunks metrics to record timeout TPM command 

Add the metrics to record the command code and system uptime when the
TPM writing or reading commands timeout.

The corresponding changes on the Chrome OS side is in
crrev.com/c/2619447

BUG=b:176421411

Change-Id: I1803d90e74ab3b82358df30cf108085af50b5f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627652
Commit-Queue: Ching-Kang Yen <chingkang@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844373}
parent 760e2e8b
Hide whitespace changes
Inline Side-by-side
Showing with 140 additions and 0 deletions
tools/metrics/histograms/enums.xml
View file @ 63dc3d89
......@@ -74144,6 +74144,118 @@ would be helpful to identify which type is being sent.
<int value="2" label="Selected Manage Passwords"/>
</enum>
<enum name="TPMCommandCode">
<int value="287" label="TPM_CC_NV_UndefineSpaceSpecial"/>
<int value="288" label="TPM_CC_EvictControl"/>
<int value="289" label="TPM_CC_HierarchyControl"/>
<int value="290" label="TPM_CC_NV_UndefineSpace"/>
<int value="292" label="TPM_CC_ChangeEPS"/>
<int value="293" label="TPM_CC_ChangePPS"/>
<int value="294" label="TPM_CC_Clear"/>
<int value="295" label="TPM_CC_ClearControl"/>
<int value="296" label="TPM_CC_ClockSet"/>
<int value="297" label="TPM_CC_HierarchyChangeAuth"/>
<int value="298" label="TPM_CC_NV_DefineSpace"/>
<int value="299" label="TPM_CC_PCR_Allocate"/>
<int value="300" label="TPM_CC_PCR_SetAuthPolicy"/>
<int value="301" label="TPM_CC_PP_Commands"/>
<int value="302" label="TPM_CC_SetPrimaryPolicy"/>
<int value="303" label="TPM_CC_FieldUpgradeStart"/>
<int value="304" label="TPM_CC_ClockRateAdjust"/>
<int value="305" label="TPM_CC_CreatePrimary"/>
<int value="306" label="TPM_CC_NV_GlobalWriteLock"/>
<int value="307" label="TPM_CC_GetCommandAuditDigest"/>
<int value="308" label="TPM_CC_NV_Increment"/>
<int value="309" label="TPM_CC_NV_SetBits"/>
<int value="310" label="TPM_CC_NV_Extend"/>
<int value="311" label="TPM_CC_NV_Write"/>
<int value="312" label="TPM_CC_NV_WriteLock"/>
<int value="313" label="TPM_CC_DictionaryAttackLockReset"/>
<int value="314" label="TPM_CC_DictionaryAttackParameters"/>
<int value="315" label="TPM_CC_NV_ChangeAuth"/>
<int value="316" label="TPM_CC_PCR_Event"/>
<int value="317" label="TPM_CC_PCR_Reset"/>
<int value="318" label="TPM_CC_SequenceComplete"/>
<int value="319" label="TPM_CC_SetAlgorithmSet"/>
<int value="320" label="TPM_CC_SetCommandCodeAuditStatus"/>
<int value="321" label="TPM_CC_FieldUpgradeData"/>
<int value="322" label="TPM_CC_IncrementalSelfTest"/>
<int value="323" label="TPM_CC_SelfTest"/>
<int value="324" label="TPM_CC_Startup"/>
<int value="325" label="TPM_CC_Shutdown"/>
<int value="326" label="TPM_CC_StirRandom"/>
<int value="327" label="TPM_CC_ActivateCredential"/>
<int value="328" label="TPM_CC_Certify"/>
<int value="329" label="TPM_CC_PolicyNV"/>
<int value="330" label="TPM_CC_CertifyCreation"/>
<int value="331" label="TPM_CC_Duplicate"/>
<int value="332" label="TPM_CC_GetTime"/>
<int value="333" label="TPM_CC_GetSessionAuditDigest"/>
<int value="334" label="TPM_CC_NV_Read"/>
<int value="335" label="TPM_CC_NV_ReadLock"/>
<int value="336" label="TPM_CC_ObjectChangeAuth"/>
<int value="337" label="TPM_CC_PolicySecret"/>
<int value="338" label="TPM_CC_Rewrap"/>
<int value="339" label="TPM_CC_Create"/>
<int value="340" label="TPM_CC_ECDH_ZGen"/>
<int value="341" label="TPM_CC_HMAC"/>
<int value="342" label="TPM_CC_Import"/>
<int value="343" label="TPM_CC_Load"/>
<int value="344" label="TPM_CC_Quote"/>
<int value="345" label="TPM_CC_RSA_Decrypt"/>
<int value="347" label="TPM_CC_HMAC_Start"/>
<int value="348" label="TPM_CC_SequenceUpdate"/>
<int value="349" label="TPM_CC_Sign"/>
<int value="350" label="TPM_CC_Unseal"/>
<int value="352" label="TPM_CC_PolicySigned"/>
<int value="353" label="TPM_CC_ContextLoad"/>
<int value="354" label="TPM_CC_ContextSave"/>
<int value="355" label="TPM_CC_ECDH_KeyGen"/>
<int value="356" label="TPM_CC_EncryptDecrypt"/>
<int value="357" label="TPM_CC_FlushContext"/>
<int value="359" label="TPM_CC_LoadExternal"/>
<int value="360" label="TPM_CC_MakeCredential"/>
<int value="361" label="TPM_CC_NV_ReadPublic"/>
<int value="362" label="TPM_CC_PolicyAuthorize"/>
<int value="363" label="TPM_CC_PolicyAuthValue"/>
<int value="364" label="TPM_CC_PolicyCommandCode"/>
<int value="365" label="TPM_CC_PolicyCounterTimer"/>
<int value="366" label="TPM_CC_PolicyCpHash"/>
<int value="367" label="TPM_CC_PolicyLocality"/>
<int value="368" label="TPM_CC_PolicyNameHash"/>
<int value="369" label="TPM_CC_PolicyOR"/>
<int value="370" label="TPM_CC_PolicyTicket"/>
<int value="371" label="TPM_CC_ReadPublic"/>
<int value="372" label="TPM_CC_RSA_Encrypt"/>
<int value="374" label="TPM_CC_StartAuthSession"/>
<int value="375" label="TPM_CC_VerifySignature"/>
<int value="376" label="TPM_CC_ECC_Parameters"/>
<int value="377" label="TPM_CC_FirmwareRead"/>
<int value="378" label="TPM_CC_GetCapability"/>
<int value="379" label="TPM_CC_GetRandom"/>
<int value="380" label="TPM_CC_GetTestResult"/>
<int value="381" label="TPM_CC_Hash"/>
<int value="382" label="TPM_CC_PCR_Read"/>
<int value="383" label="TPM_CC_PolicyPCR"/>
<int value="384" label="TPM_CC_PolicyRestart"/>
<int value="385" label="TPM_CC_ReadClock"/>
<int value="386" label="TPM_CC_PCR_Extend"/>
<int value="387" label="TPM_CC_PCR_SetAuthValue"/>
<int value="388" label="TPM_CC_NV_Certify"/>
<int value="389" label="TPM_CC_EventSequenceComplete"/>
<int value="390" label="TPM_CC_HashSequenceStart"/>
<int value="391" label="TPM_CC_PolicyPhysicalPresence"/>
<int value="392" label="TPM_CC_PolicyDuplicationSelect"/>
<int value="393" label="TPM_CC_PolicyGetDigest"/>
<int value="394" label="TPM_CC_TestParms"/>
<int value="395" label="TPM_CC_Commit"/>
<int value="396" label="TPM_CC_PolicyPassword"/>
<int value="397" label="TPM_CC_ZGen_2Phase"/>
<int value="398" label="TPM_CC_EC_Ephemeral"/>
<int value="399" label="TPM_CC_PolicyNvWritten"/>
<int value="536903681" label="TPM_CCE_PolicyFidoSigned"/>
</enum>
<enum name="TPMFirmwareUpdateResult">
<int value="0" label="Success"/>
<int value="1" label="Success after retry"/>
tools/metrics/histograms/histograms_xml/platform/histograms.xml
View file @ 63dc3d89
......@@ -1233,6 +1233,34 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</summary>
</histogram>
<histogram name="Platform.Trunks.FirstTimeoutReadingCommand"
enum="TPMCommandCode" expires_after="2022-01-14">
<owner>chingkang@chromium.org</owner>
<owner>cros-hwsec+uma@chromium.org</owner>
<summary>Command code of the first timeout reading TPM command</summary>
</histogram>
<histogram name="Platform.Trunks.FirstTimeoutReadingTime" units="seconds"
expires_after="2022-01-14">
<owner>chingkang@chromium.org</owner>
<owner>cros-hwsec+uma@chromium.org</owner>
<summary>System uptime when first timeout reading TPM command occurs</summary>
</histogram>
<histogram name="Platform.Trunks.FirstTimeoutWritingCommand"
enum="TPMCommandCode" expires_after="2022-01-14">
<owner>chingkang@chromium.org</owner>
<owner>cros-hwsec+uma@chromium.org</owner>
<summary>Command code of the first timeout writing TPM command</summary>
</histogram>
<histogram name="Platform.Trunks.FirstTimeoutWritingTime" units="seconds"
expires_after="2022-01-14">
<owner>chingkang@chromium.org</owner>
<owner>cros-hwsec+uma@chromium.org</owner>
<summary>System uptime when first timeout writing TPM command occurs</summary>
</histogram>
<histogram name="Platform.U2F.Command" enum="Cr50U2FCommands"
expires_after="2021-12-21">
<owner>cylai@chromium.org</owner>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment