[ios][remoting] Improve linking with MaterialComponents.framework

Change remoting code to only link with MaterialComponents.framework if
the code is compiled as a framework (this will allow removing the fake
targets that exists in ios/third_party/material_components_ios/BUILD.gn).

If using MaterialComponents.framework, then bundle it with the app.

This is a reland of https://crrev.com/c/2020960 with a fix for the
compilation of ios_remoting_unittests when building a framework for
MaterialComponents (which is the default on the internal builder and
why the original CL was reverted).

Bug: 1040871
Change-Id: I77bb04480bc6b7b1a01133a795f73bc5860b7686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023888Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736011}

remoting/ios/BUILD.gn

@@ -2,6 +2,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//ios/third_party/features.gni")
 import("//remoting/build/config/remoting_build.gni")
 import("//remoting/remoting_locales.gni")
 
@@ -84,9 +85,13 @@ test("ios_remoting_unittests") {
     deps += [ ":unittests_locale_${locale}_bundle_data" ]
   }
 
-  bundle_deps = [
-    "//ios/third_party/material_components_ios:material_components_ios+bundle",
-  ]
+  if (ios_third_party_material_components_built_as_framework) {
+    deps += [
+      "//ios/third_party/material_components_ios:material_components_ios+link",
+    ]
+
+    bundle_deps = [ "//ios/third_party/material_components_ios:material_components_ios+bundle" ]
+  }
 }
 
 foreach(locale, remoting_locales_with_underscores) {

remoting/ios/app/BUILD.gn

@@ -2,6 +2,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//ios/third_party/features.gni")
 import("//remoting/build/config/remoting_build.gni")
 import("//remoting/ios/app/remoting_ios_tmpl.gni")
 
@@ -111,7 +112,7 @@ source_set("common_source_set") {
   }
 
   public_deps = [
-    "//ios/third_party/material_components_ios:material_components_ios+link",
+    "//ios/third_party/material_components_ios",
     "//remoting/ios/facade",
   ]
 
@@ -144,8 +145,14 @@ ios_remoting_app_tmpl("ios_remoting_app") {
   entitlements_path = "resources/Remoting.entitlements"
   deps = [
     ":app_source_set",
-    "//ios/third_party/material_components_ios:material_components_ios+bundle",
     "//remoting/ios/app/resources:launchscreen_assets",
     "//remoting/ios/app/resources:remoting_icons",
   ]
+
+  if (ios_third_party_material_components_built_as_framework) {
+    deps += [
+      "//ios/third_party/material_components_ios:material_components_ios+bundle",
+      "//ios/third_party/material_components_ios:material_components_ios+link",
+    ]
+  }
 }

remoting/ios/app/settings/BUILD.gn

@@ -27,9 +27,7 @@ source_set("settings") {
     "//ui/resources",
   ]
 
-  public_deps = [
-    "//ios/third_party/material_components_ios:material_components_ios+link",
-  ]
+  public_deps = [ "//ios/third_party/material_components_ios" ]
 
   configs += [ "//build/config/compiler:enable_arc" ]
 }

remoting/ios/facade/BUILD.gn

@@ -25,7 +25,7 @@ source_set("facade") {
 
   deps = [
     "//base",
-    "//ios/third_party/material_components_ios:material_components_ios+link",
+    "//ios/third_party/material_components_ios",
     "//remoting/base:authorization",
     "//remoting/client",
     "//remoting/ios/domain",

remoting/ios/mdc/BUILD.gn

@@ -14,9 +14,7 @@ source_set("mdc") {
 
   libs = [ "UIKit.framework" ]
 
-  deps = [
-    "//ios/third_party/material_components_ios:material_components_ios+link",
-  ]
+  deps = [ "//ios/third_party/material_components_ios" ]
 
   configs += [ "//build/config/compiler:enable_arc" ]
 }

remoting/ios/session/BUILD.gn

@@ -16,7 +16,7 @@ source_set("session") {
 
   deps = [
     "//base",
-    "//ios/third_party/material_components_ios:material_components_ios+link",
+    "//ios/third_party/material_components_ios",
     "//remoting/client",
     "//remoting/client/display",
     "//remoting/client/ui",