Commit 642f98e3 authored by Eugene But's avatar Eugene But Committed by Commit Bot

Mark RestoreSessionOnline as flaky on devices.

The test flakily fails on iPhone and iPad devices.

Bug: 944803
Change-Id: I102cfae6ed43d57db7d63deedb1cea61a1bd0405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548534
Commit-Queue: Eugene But <eugenebut@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: default avatarChris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646628}
parent 3f0e8a2e
......@@ -2479,13 +2479,13 @@ TEST_P(WebStateObserverTest, RestoreSession) {
// Tests callbacks for restoring session and subsequently going back to
// about:blank.
TEST_P(WebStateObserverTest, RestoreSessionOnline) {
// TODO(crbug.com/944886): Remove once issue resolved.
#if !TARGET_IPHONE_SIMULATOR
UIUserInterfaceIdiom idiom = [[UIDevice currentDevice] userInterfaceIdiom];
if (idiom == UIUserInterfaceIdiomPad)
return;
// TODO(crbug.com/944803): Test is flaky on iPhone and iPad devices.
#if TARGET_IPHONE_SIMULATOR
#define MAYBE_RestoreSessionOnline RestoreSessionOnline
#else
#define MAYBE_RestoreSessionOnline FLAKY_RestoreSessionOnline
#endif
TEST_P(WebStateObserverTest, MAYBE_RestoreSessionOnline) {
// LegacyNavigationManager doesn't trigger load in Restore.
if (!GetWebClient()->IsSlimNavigationManagerEnabled()) {
return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment