Commit 6436fc4a authored by Robbie Gibson's avatar Robbie Gibson Committed by Commit Bot

[iOS] Add Omnibox NTP ZPS suggestion flag

This flag already exists and is used for this purpose on Android and
Desktop. This adds the flag to iOS.

Bug: 1048193
Change-Id: Ia50dbcc3994cc74592f821a3fbc6c3f74ff785a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056776Reviewed-by: default avatarEnder <ender@google.com>
Reviewed-by: default avatarStepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#742553}
parent f51a5cd9
...@@ -189,6 +189,16 @@ const FeatureEntry::FeatureVariation ...@@ -189,6 +189,16 @@ const FeatureEntry::FeatureVariation
base::size(kOmniboxOnDeviceHeadSuggestDelay350MsAndRelevance1000), base::size(kOmniboxOnDeviceHeadSuggestDelay350MsAndRelevance1000),
nullptr}}; nullptr}};
const FeatureEntry::FeatureParam kOmniboxNTPZPSRemote[] = {
{"ZeroSuggestVariant:1:*", "RemoteNoUrl"},
{"ZeroSuggestVariant:7:*", "RemoteNoUrl"},
{"ZeroSuggestVariant:8:*", "RemoteNoUrl"}};
const FeatureEntry::FeatureVariation kOmniboxOnFocusSuggestionsVariations[] = {
{"ZPS on NTP: Remote History", kOmniboxNTPZPSRemote,
base::size(kOmniboxNTPZPSRemote), "t3316653" /* variation_id */},
};
const FeatureEntry::FeatureParam kOmniboxUIMaxAutocompleteMatches3[] = { const FeatureEntry::FeatureParam kOmniboxUIMaxAutocompleteMatches3[] = {
{OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "3"}}; {OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "3"}};
const FeatureEntry::FeatureParam kOmniboxUIMaxAutocompleteMatches4[] = { const FeatureEntry::FeatureParam kOmniboxUIMaxAutocompleteMatches4[] = {
...@@ -383,6 +393,12 @@ const flags_ui::FeatureEntry kFeatureEntries[] = { ...@@ -383,6 +393,12 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
omnibox::kOnDeviceHeadProvider, omnibox::kOnDeviceHeadProvider,
kOmniboxOnDeviceHeadSuggestExperimentVariations, kOmniboxOnDeviceHeadSuggestExperimentVariations,
"OmniboxOnDeviceHeadSuggestIOS")}, "OmniboxOnDeviceHeadSuggestIOS")},
{"omnibox-on-focus-suggestions",
flag_descriptions::kOmniboxOnFocusSuggestionsName,
flag_descriptions::kOmniboxOnFocusSuggestionsDescription, flags_ui::kOsIos,
FEATURE_WITH_PARAMS_VALUE_TYPE(omnibox::kOnFocusSuggestions,
kOmniboxOnFocusSuggestionsVariations,
"OmniboxBundledExperimentV1")},
{"omnibox-ui-max-autocomplete-matches", {"omnibox-ui-max-autocomplete-matches",
flag_descriptions::kOmniboxUIMaxAutocompleteMatchesName, flag_descriptions::kOmniboxUIMaxAutocompleteMatchesName,
flag_descriptions::kOmniboxUIMaxAutocompleteMatchesDescription, flag_descriptions::kOmniboxUIMaxAutocompleteMatchesDescription,
......
...@@ -314,6 +314,12 @@ const char kOmniboxOnDeviceHeadSuggestionsDescription[] = ...@@ -314,6 +314,12 @@ const char kOmniboxOnDeviceHeadSuggestionsDescription[] =
"Shows Google head non personalized search suggestions provided by a " "Shows Google head non personalized search suggestions provided by a "
"compact on device model"; "compact on device model";
const char kOmniboxOnFocusSuggestionsName[] = "Omnibox on-focus suggestions";
const char kOmniboxOnFocusSuggestionsDescription[] =
"Configures Omnibox on-focus suggestions - suggestions displayed on-focus "
"before the user has typed any input. This provides overrides for the "
"default suggestion locations.";
const char kPageInfoRefactoringName[] = "New design of the page info"; const char kPageInfoRefactoringName[] = "New design of the page info";
const char kPageInfoRefactoringDescription[] = const char kPageInfoRefactoringDescription[] =
"Uses the new design for the page security info."; "Uses the new design for the page security info.";
......
...@@ -269,6 +269,10 @@ extern const char kOmniboxUIMaxAutocompleteMatchesDescription[]; ...@@ -269,6 +269,10 @@ extern const char kOmniboxUIMaxAutocompleteMatchesDescription[];
extern const char kOmniboxOnDeviceHeadSuggestionsName[]; extern const char kOmniboxOnDeviceHeadSuggestionsName[];
extern const char kOmniboxOnDeviceHeadSuggestionsDescription[]; extern const char kOmniboxOnDeviceHeadSuggestionsDescription[];
// Title and description for the flag to control Omnibox on-focus suggestions.
extern const char kOmniboxOnFocusSuggestionsName[];
extern const char kOmniboxOnFocusSuggestionsDescription[];
// Title and description for the flag to enable the new design of the page info. // Title and description for the flag to enable the new design of the page info.
extern const char kPageInfoRefactoringName[]; extern const char kPageInfoRefactoringName[];
extern const char kPageInfoRefactoringDescription[]; extern const char kPageInfoRefactoringDescription[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment