Rewrite base::Bind to base::BindOnce with base_bind_rewriters in...

Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/chromeos/file_manager

This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters.
It rewrites base::Bind to base::BindOnce where the resulting Callback is converted to
OnceCallback immediately.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback.

Bug: 554299
Change-Id: I54220a53ba53141700cecbbeed585a8c1627e0a8
Reviewed-on: https://chromium-review.googlesource.com/517466Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475861}

chrome/browser/chromeos/file_manager/fileapi_util.cc

@@ -305,13 +305,12 @@ class ConvertSelectedFileInfoListToFileChooserFileInfoListImpl {
     // file), move to IO thread to obtian metadata for the non-native file.
     if (need_fill_metadata) {
       BrowserThread::PostTask(
-          BrowserThread::IO,
-          FROM_HERE,
-          base::Bind(&ConvertSelectedFileInfoListToFileChooserFileInfoListImpl::
-                         FillMetadataOnIOThread,
-                     base::Unretained(this),
-                     base::Passed(&lifetime),
-                     chooser_info_list_->begin()));
+          BrowserThread::IO, FROM_HERE,
+          base::BindOnce(
+              &ConvertSelectedFileInfoListToFileChooserFileInfoListImpl::
+                  FillMetadataOnIOThread,
+              base::Unretained(this), base::Passed(&lifetime),
+              chooser_info_list_->begin()));
       return;
     }
 
@@ -338,12 +337,11 @@ class ConvertSelectedFileInfoListToFileChooserFileInfoListImpl {
 
     if (it == chooser_info_list_->end()) {
       BrowserThread::PostTask(
-          BrowserThread::UI,
-          FROM_HERE,
-          base::Bind(&ConvertSelectedFileInfoListToFileChooserFileInfoListImpl::
-                         NotifyComplete,
-                     base::Unretained(this),
-                     base::Passed(&lifetime)));
+          BrowserThread::UI, FROM_HERE,
+          base::BindOnce(
+              &ConvertSelectedFileInfoListToFileChooserFileInfoListImpl::
+                  NotifyComplete,
+              base::Unretained(this), base::Passed(&lifetime)));
       return;
     }
 
@@ -371,12 +369,11 @@ class ConvertSelectedFileInfoListToFileChooserFileInfoListImpl {
 
     if (result != base::File::FILE_OK) {
       BrowserThread::PostTask(
-          BrowserThread::UI,
-          FROM_HERE,
-          base::Bind(&ConvertSelectedFileInfoListToFileChooserFileInfoListImpl::
-                         NotifyError,
-                     base::Unretained(this),
-                     base::Passed(&lifetime)));
+          BrowserThread::UI, FROM_HERE,
+          base::BindOnce(
+              &ConvertSelectedFileInfoListToFileChooserFileInfoListImpl::
+                  NotifyError,
+              base::Unretained(this), base::Passed(&lifetime)));
       return;
     }
 
@@ -553,10 +550,10 @@ void CheckIfDirectoryExists(
 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
-      base::Bind(base::IgnoreResult(
-                     &storage::FileSystemOperationRunner::DirectoryExists),
-                 file_system_context->operation_runner()->AsWeakPtr(),
-                 internal_url, google_apis::CreateRelayCallback(callback)));
+      base::BindOnce(base::IgnoreResult(
+                         &storage::FileSystemOperationRunner::DirectoryExists),
+                     file_system_context->operation_runner()->AsWeakPtr(),
+                     internal_url, google_apis::CreateRelayCallback(callback)));
 }
 
 void GetMetadataForPath(
@@ -574,7 +571,7 @@ void GetMetadataForPath(
 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
-      base::Bind(
+      base::BindOnce(
           base::IgnoreResult(&storage::FileSystemOperationRunner::GetMetadata),
           file_system_context->operation_runner()->AsWeakPtr(), internal_url,
           fields, google_apis::CreateRelayCallback(callback)));

chrome/browser/chromeos/file_manager/filesystem_api_util.cc

@@ -151,9 +151,8 @@ void GetNonNativeLocalPathMimeType(
         drive::util::GetFileSystemByProfile(profile);
     if (!file_system) {
       content::BrowserThread::PostTask(
-          content::BrowserThread::UI,
-          FROM_HERE,
-          base::Bind(callback, false, std::string()));
+          content::BrowserThread::UI, FROM_HERE,
+          base::BindOnce(callback, false, std::string()));
       return;
     }
 
@@ -168,9 +167,8 @@ void GetNonNativeLocalPathMimeType(
     chromeos::file_system_provider::util::LocalPathParser parser(profile, path);
     if (!parser.Parse()) {
       content::BrowserThread::PostTask(
-          content::BrowserThread::UI,
-          FROM_HERE,
-          base::Bind(callback, false, std::string()));
+          content::BrowserThread::UI, FROM_HERE,
+          base::BindOnce(callback, false, std::string()));
       return;
     }
 
@@ -187,9 +185,8 @@ void GetNonNativeLocalPathMimeType(
   // error with empty MIME type, that leads fallback guessing mime type from
   // file extensions.
   content::BrowserThread::PostTask(
-      content::BrowserThread::UI,
-      FROM_HERE,
-      base::Bind(callback, false /* failure */, std::string()));
+      content::BrowserThread::UI, FROM_HERE,
+      base::BindOnce(callback, false /* failure */, std::string()));
 }
 
 void IsNonNativeLocalPathDirectory(
@@ -216,9 +213,8 @@ void PrepareNonNativeLocalFileForWritableApp(
            profile, path, kFileManagerAppId, &url)) {
     // Posting to the current thread, so that we always call back asynchronously
     // independent from whether or not the operation succeeds.
-    content::BrowserThread::PostTask(content::BrowserThread::UI,
-                                     FROM_HERE,
-                                     base::Bind(callback, false));
+    content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
+                                     base::BindOnce(callback, false));
     return;
   }
 
@@ -233,8 +229,8 @@ void PrepareNonNativeLocalFileForWritableApp(
 
   content::BrowserThread::PostTask(
       content::BrowserThread::IO, FROM_HERE,
-      base::Bind(&PrepareFileOnIOThread, file_system_context, internal_url,
-                 google_apis::CreateRelayCallback(callback)));
+      base::BindOnce(&PrepareFileOnIOThread, file_system_context, internal_url,
+                     google_apis::CreateRelayCallback(callback)));
 }
 
 }  // namespace util

chrome/browser/chromeos/file_manager/snapshot_manager.cc

@@ -75,10 +75,9 @@ void ComputeSpaceNeedToBeFreed(
     const GetNecessaryFreeSpaceCallback& callback) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   content::BrowserThread::PostTask(
-      content::BrowserThread::IO,
-      FROM_HERE,
-      base::Bind(&GetMetadataOnIOThread, profile->GetPath(), context, url,
-                 google_apis::CreateRelayCallback(callback)));
+      content::BrowserThread::IO, FROM_HERE,
+      base::BindOnce(&GetMetadataOnIOThread, profile->GetPath(), context, url,
+                     google_apis::CreateRelayCallback(callback)));
 }
 
 // Part of CreateManagedSnapshot. Runs CreateSnapshotFile method of fileapi.
@@ -118,9 +117,8 @@ SnapshotManager::SnapshotManager(Profile* profile)
 SnapshotManager::~SnapshotManager() {
   if (!file_refs_.empty()) {
     bool posted = content::BrowserThread::PostTask(
-        content::BrowserThread::IO,
-        FROM_HERE,
-        base::Bind(&FreeReferenceOnIOThread, file_refs_));
+        content::BrowserThread::IO, FROM_HERE,
+        base::BindOnce(&FreeReferenceOnIOThread, file_refs_));
     DCHECK(posted);
   }
 }
@@ -169,9 +167,8 @@ void SnapshotManager::CreateManagedSnapshotAfterSpaceComputed(
   }
   if (!to_free.empty()) {
     bool posted = content::BrowserThread::PostTask(
-        content::BrowserThread::IO,
-        FROM_HERE,
-        base::Bind(&FreeReferenceOnIOThread, to_free));
+        content::BrowserThread::IO, FROM_HERE,
+        base::BindOnce(&FreeReferenceOnIOThread, to_free));
     DCHECK(posted);
   }
 
@@ -183,15 +180,11 @@ void SnapshotManager::CreateManagedSnapshotAfterSpaceComputed(
 
   // Start creating the snapshot.
   content::BrowserThread::PostTask(
-      content::BrowserThread::IO,
-      FROM_HERE,
-      base::Bind(&CreateSnapshotFileOnIOThread,
-                 context,
-                 filesystem_url,
-                 google_apis::CreateRelayCallback(
-                     base::Bind(&SnapshotManager::OnCreateSnapshotFile,
-                                weak_ptr_factory_.GetWeakPtr(),
-                                callback))));
+      content::BrowserThread::IO, FROM_HERE,
+      base::BindOnce(&CreateSnapshotFileOnIOThread, context, filesystem_url,
+                     google_apis::CreateRelayCallback(base::Bind(
+                         &SnapshotManager::OnCreateSnapshotFile,
+                         weak_ptr_factory_.GetWeakPtr(), callback))));
 }
 
 void SnapshotManager::OnCreateSnapshotFile(

chrome/browser/chromeos/file_manager/volume_manager.cc

@@ -855,9 +855,9 @@ void VolumeManager::OnRemovableStorageAttached(
 
   content::BrowserThread::PostTask(
       content::BrowserThread::IO, FROM_HERE,
-      base::Bind(&MTPDeviceMapService::RegisterMTPFileSystem,
-                 base::Unretained(MTPDeviceMapService::GetInstance()),
-                 info.location(), fsid, read_only));
+      base::BindOnce(&MTPDeviceMapService::RegisterMTPFileSystem,
+                     base::Unretained(MTPDeviceMapService::GetInstance()),
+                     info.location(), fsid, read_only));
 
   std::unique_ptr<Volume> volume = Volume::CreateForMTP(path, label, read_only);
   DoMountEvent(chromeos::MOUNT_ERROR_NONE, std::move(volume));
@@ -875,10 +875,10 @@ void VolumeManager::OnRemovableStorageDetached(
       const std::string fsid = GetMountPointNameForMediaStorage(info);
       storage::ExternalMountPoints::GetSystemInstance()->RevokeFileSystem(fsid);
       content::BrowserThread::PostTask(
-          content::BrowserThread::IO, FROM_HERE, base::Bind(
-              &MTPDeviceMapService::RevokeMTPFileSystem,
-              base::Unretained(MTPDeviceMapService::GetInstance()),
-              fsid));
+          content::BrowserThread::IO, FROM_HERE,
+          base::BindOnce(&MTPDeviceMapService::RevokeMTPFileSystem,
+                         base::Unretained(MTPDeviceMapService::GetInstance()),
+                         fsid));
       return;
     }
   }