Stop trying to execute a print() command if loading failed.

LocalDOMWindow::should_print_when_finished_loading_ stores whether
a print command happened while the window was still loading, in order
to run the print once loading has completed.

If the load fails, the print should not happen, because it makes
no sense, and also because it might cause a crash (see bug).

Bug: 982974

Change-Id: I5222a55d6280403296f532049d8302723ef9ed59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716397Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681937}

third_party/blink/renderer/core/dom/document.cc

@@ -3945,8 +3945,10 @@ void Document::Abort() {
 }
 
 void Document::CheckCompleted() {
-  if (CheckCompletedInternal())
-    frame_->Loader().DidFinishNavigation();
+  if (CheckCompletedInternal()) {
+    frame_->Loader().DidFinishNavigation(
+        FrameLoader::NavigationFinishState::kSuccess);
+  }
 }
 
 bool Document::CheckCompletedInternal() {

third_party/blink/renderer/core/frame/local_dom_window.cc

@@ -1412,9 +1412,13 @@ void LocalDOMWindow::RemoveAllEventListeners() {
   UntrackAllBeforeUnloadEventListeners(this);
 }
 
-void LocalDOMWindow::FinishedLoading() {
-  if (should_print_when_finished_loading_) {
-    should_print_when_finished_loading_ = false;
+void LocalDOMWindow::FinishedLoading(FrameLoader::NavigationFinishState state) {
+  bool was_should_print_when_finished_loading =
+      should_print_when_finished_loading_;
+  should_print_when_finished_loading_ = false;
+
+  if (was_should_print_when_finished_loading &&
+      state == FrameLoader::NavigationFinishState::kSuccess) {
     print(nullptr);
   }
 }

third_party/blink/renderer/core/frame/local_dom_window.h

@@ -293,7 +293,7 @@ class CORE_EXPORT LocalDOMWindow final : public DOMWindow,
   using EventTarget::DispatchEvent;
   DispatchEventResult DispatchEvent(Event&, EventTarget*);
 
-  void FinishedLoading();
+  void FinishedLoading(FrameLoader::NavigationFinishState);
 
   // Dispatch the (deprecated) orientationchange event to this DOMWindow and
   // recurse on its child frames.

third_party/blink/renderer/core/frame/local_frame.cc

@@ -1725,8 +1725,8 @@ void LocalFrame::CountUseIfFeatureWouldBeBlockedByFeaturePolicy(
   }
 }
 
-void LocalFrame::FinishedLoading() {
-  DomWindow()->FinishedLoading();
+void LocalFrame::FinishedLoading(FrameLoader::NavigationFinishState state) {
+  DomWindow()->FinishedLoading(state);
 
   if (pending_lifecycle_state_) {
     DCHECK(!IsLoading());

third_party/blink/renderer/core/frame/local_frame.h

@@ -453,7 +453,7 @@ class CORE_EXPORT LocalFrame final : public Frame,
       mojom::WebFeature blocked_cross_origin,
       mojom::WebFeature blocked_same_origin);
 
-  void FinishedLoading();
+  void FinishedLoading(FrameLoader::NavigationFinishState);
 
  private:
   friend class FrameNavigationDisabler;

third_party/blink/renderer/core/loader/document_loader.cc

@@ -614,7 +614,8 @@ void DocumentLoader::LoadFailed(const ResourceError& error) {
     frame_->GetDocument()->Parser()->StopParsing();
   state_ = kSentDidFinishLoad;
   GetLocalFrameClient().DispatchDidFailLoad(error, history_commit_type);
-  GetFrameLoader().DidFinishNavigation();
+  GetFrameLoader().DidFinishNavigation(
+      FrameLoader::NavigationFinishState::kFailure);
   DCHECK_EQ(kSentDidFinishLoad, state_);
   params_ = nullptr;
 }
@@ -966,7 +967,8 @@ void DocumentLoader::CommitSameDocumentNavigationInternal(
   // scroll should cancel it.
   GetFrameLoader().DetachProvisionalDocumentLoader();
   GetFrameLoader().CancelClientNavigation();
-  GetFrameLoader().DidFinishNavigation();
+  GetFrameLoader().DidFinishNavigation(
+      FrameLoader::NavigationFinishState::kSuccess);
 
   if (!frame_->GetPage())
     return;

third_party/blink/renderer/core/loader/frame_loader.cc

@@ -362,7 +362,7 @@ void FrameLoader::FinishedParsing() {
 // TODO(dgozman): we are calling this method too often, hoping that it
 // does not do anything when navigation is in progress, or when loading
 // has finished already. We should call it at the right times.
-void FrameLoader::DidFinishNavigation() {
+void FrameLoader::DidFinishNavigation(NavigationFinishState state) {
   // We should have either finished the provisional or committed navigation if
   // this is called. Only delcare the whole frame finished if neither is in
   // progress.
@@ -383,7 +383,7 @@ void FrameLoader::DidFinishNavigation() {
     RestoreScrollPositionAndViewState();
     if (document_loader_)
       document_loader_->SetLoadType(WebFrameLoadType::kStandard);
-    frame_->FinishedLoading();
+    frame_->FinishedLoading(state);
   }
 
   // When a subframe finishes loading, the parent should check if *all*
@@ -893,7 +893,7 @@ void FrameLoader::CommitNavigation(
 
   FillStaticResponseIfNeeded(navigation_params.get(), frame_);
   if (!ShouldNavigate(navigation_params.get(), frame_)) {
-    DidFinishNavigation();
+    DidFinishNavigation(FrameLoader::NavigationFinishState::kSuccess);
     return;
   }
 
@@ -988,7 +988,7 @@ void FrameLoader::StopAllLoaders() {
     document_loader_->StopLoading();
   DetachDocumentLoader(provisional_document_loader_);
   CancelClientNavigation();
-  DidFinishNavigation();
+  DidFinishNavigation(FrameLoader::NavigationFinishState::kSuccess);
 
   TakeObjectSnapshot();
 }
@@ -1212,7 +1212,7 @@ void FrameLoader::Detach() {
   }
   ClearClientNavigation();
   committing_navigation_ = false;
-  DidFinishNavigation();
+  DidFinishNavigation(FrameLoader::NavigationFinishState::kSuccess);
 
   if (progress_tracker_) {
     progress_tracker_->Dispose();
@@ -1242,7 +1242,7 @@ bool FrameLoader::MaybeRenderFallbackContent() {
 
   frame_->Owner()->RenderFallbackContent(frame_);
   ClearClientNavigation();
-  DidFinishNavigation();
+  DidFinishNavigation(FrameLoader::NavigationFinishState::kSuccess);
   return true;
 }
 
@@ -1367,7 +1367,7 @@ void FrameLoader::DidDropNavigation() {
   // TODO(dgozman): should we ClearClientNavigation instead and not
   // notify the client in response to its own call?
   CancelClientNavigation();
-  DidFinishNavigation();
+  DidFinishNavigation(FrameLoader::NavigationFinishState::kSuccess);
 
   // Forcibly instantiate WindowProxy for initial frame document.
   // This is only required when frame navigation is aborted, e.g. due to

third_party/blink/renderer/core/loader/frame_loader.h

@@ -167,7 +167,8 @@ class CORE_EXPORT FrameLoader final {
   void Detach();
 
   void FinishedParsing();
-  void DidFinishNavigation();
+  enum class NavigationFinishState { kSuccess, kFailure };
+  void DidFinishNavigation(NavigationFinishState);
 
   void DidFinishSameDocumentNavigation(const KURL&,
                                        WebFrameLoadType,