Commit 650a5e42 authored by Jialiu Lin's avatar Jialiu Lin Committed by Commit Bot

Fix DCHECK crash in CheckClientDownloadRequest::OnDownloadDestroyed

For some rare cases, service_ in CheckClientDownloadRequest is already
set to null when OnDownloadDestroyed is called, which as a result will
make item_ still dangle there, and causes crash at the DCHECK(item_==NULL).

Bug: 806785
Change-Id: I384f66ca94d6695d870a632d52b9be26a0f9a3a3
Reviewed-on: https://chromium-review.googlesource.com/891808Reviewed-by: default avatarJialiu Lin <jialiul@chromium.org>
Reviewed-by: default avatarLuke Z <lpz@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532973}
parent 0eefbc58
...@@ -1031,6 +1031,7 @@ void CheckClientDownloadRequest::FinishRequest( ...@@ -1031,6 +1031,7 @@ void CheckClientDownloadRequest::FinishRequest(
// so we may be deleted now. // so we may be deleted now.
} else { } else {
callback_.Run(DownloadCheckResult::UNKNOWN); callback_.Run(DownloadCheckResult::UNKNOWN);
item_ = NULL;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment