Commit 6519625c authored by Yue Zhang's avatar Yue Zhang Committed by Commit Bot

Disable TabGridDialogTest on low end phone

Even though TabGridDialog is available for low end devices with
TabGroup M5, we don't have such coverage in TabGridDialogTest yet. This
CL disables the tests for low end devices to keep test-go-phone bot
green. Also, this CL enables the tests that are disabled due to failure
on test-go-phone bot.

Bug: 1108547
Change-Id: I250b1d1a5add21039b4c0d942e3b29d5d1b72724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315442
Auto-Submit: Yue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791161}
parent 3d9923f3
...@@ -75,7 +75,6 @@ import org.junit.runner.RunWith; ...@@ -75,7 +75,6 @@ import org.junit.runner.RunWith;
import org.chromium.base.test.params.ParameterAnnotations; import org.chromium.base.test.params.ParameterAnnotations;
import org.chromium.base.test.params.ParameterizedRunner; import org.chromium.base.test.params.ParameterizedRunner;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.Restriction; import org.chromium.base.test.util.Restriction;
import org.chromium.chrome.browser.ChromeActivity; import org.chromium.chrome.browser.ChromeActivity;
...@@ -103,7 +102,8 @@ import java.util.concurrent.ExecutionException; ...@@ -103,7 +102,8 @@ import java.util.concurrent.ExecutionException;
@RunWith(ParameterizedRunner.class) @RunWith(ParameterizedRunner.class)
@ParameterAnnotations.UseRunnerDelegate(ChromeJUnit4RunnerDelegate.class) @ParameterAnnotations.UseRunnerDelegate(ChromeJUnit4RunnerDelegate.class)
@CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE}) @CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE})
@Restriction(UiRestriction.RESTRICTION_TYPE_PHONE) @Restriction({UiRestriction.RESTRICTION_TYPE_PHONE,
Restriction.RESTRICTION_TYPE_NON_LOW_END_DEVICE})
@Features.EnableFeatures({TAB_GRID_LAYOUT_ANDROID, TAB_GROUPS_ANDROID}) @Features.EnableFeatures({TAB_GRID_LAYOUT_ANDROID, TAB_GROUPS_ANDROID})
public class TabGridDialogTest { public class TabGridDialogTest {
// clang-format on // clang-format on
...@@ -158,7 +158,6 @@ public class TabGridDialogTest { ...@@ -158,7 +158,6 @@ public class TabGridDialogTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testBackPressCloseDialog() { public void testBackPressCloseDialog() {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2); createTabs(cta, false, 2);
...@@ -193,7 +192,6 @@ public class TabGridDialogTest { ...@@ -193,7 +192,6 @@ public class TabGridDialogTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testClickScrimCloseDialog() throws ExecutionException { public void testClickScrimCloseDialog() throws ExecutionException {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2); createTabs(cta, false, 2);
...@@ -236,7 +234,6 @@ public class TabGridDialogTest { ...@@ -236,7 +234,6 @@ public class TabGridDialogTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testDisableTabGroupsContinuation() { public void testDisableTabGroupsContinuation() {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2); createTabs(cta, false, 2);
...@@ -276,7 +273,6 @@ public class TabGridDialogTest { ...@@ -276,7 +273,6 @@ public class TabGridDialogTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testTabGridDialogAnimation() { public void testTabGridDialogAnimation() {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2); createTabs(cta, false, 2);
...@@ -327,7 +323,6 @@ public class TabGridDialogTest { ...@@ -327,7 +323,6 @@ public class TabGridDialogTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testUndoClosureInDialog_GTS() throws ExecutionException { public void testUndoClosureInDialog_GTS() throws ExecutionException {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2); createTabs(cta, false, 2);
...@@ -357,7 +352,6 @@ public class TabGridDialogTest { ...@@ -357,7 +352,6 @@ public class TabGridDialogTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testUndoClosureInDialog_TabStrip() throws ExecutionException { public void testUndoClosureInDialog_TabStrip() throws ExecutionException {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2); createTabs(cta, false, 2);
...@@ -393,7 +387,6 @@ public class TabGridDialogTest { ...@@ -393,7 +387,6 @@ public class TabGridDialogTest {
@Test @Test
@MediumTest @MediumTest
@Features.EnableFeatures(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID) @Features.EnableFeatures(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID)
@DisabledTest(message = "https://crbug.com/1108547")
public void testDialogToolbarMenuShareGroup() { public void testDialogToolbarMenuShareGroup() {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2); createTabs(cta, false, 2);
...@@ -455,7 +448,6 @@ public class TabGridDialogTest { ...@@ -455,7 +448,6 @@ public class TabGridDialogTest {
@Test @Test
@MediumTest @MediumTest
@Features.EnableFeatures(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID) @Features.EnableFeatures(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID)
@DisabledTest(message = "https://crbug.com/1108547")
public void testSelectionEditorUngroup() throws ExecutionException { public void testSelectionEditorUngroup() throws ExecutionException {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
assertTrue(cta.getTabModelSelector().getTabModelFilterProvider().getCurrentTabModelFilter() assertTrue(cta.getTabModelSelector().getTabModelFilterProvider().getCurrentTabModelFilter()
...@@ -592,7 +584,6 @@ public class TabGridDialogTest { ...@@ -592,7 +584,6 @@ public class TabGridDialogTest {
@Test @Test
@MediumTest @MediumTest
@Features.EnableFeatures(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID) @Features.EnableFeatures(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID)
@DisabledTest(message = "https://crbug.com/1108547")
public void testTabGroupNaming() throws ExecutionException { public void testTabGroupNaming() throws ExecutionException {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2); createTabs(cta, false, 2);
...@@ -628,7 +619,6 @@ public class TabGridDialogTest { ...@@ -628,7 +619,6 @@ public class TabGridDialogTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testDialogInitialShowFromStrip() throws Exception { public void testDialogInitialShowFromStrip() throws Exception {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
prepareTabsWithThumbnail(mActivityTestRule, 2, 0, "about:blank"); prepareTabsWithThumbnail(mActivityTestRule, 2, 0, "about:blank");
...@@ -653,7 +643,6 @@ public class TabGridDialogTest { ...@@ -653,7 +643,6 @@ public class TabGridDialogTest {
@MediumTest @MediumTest
@Feature({"RenderTest"}) @Feature({"RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class) @ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "https://crbug.com/1108547")
public void testRenderDialog_3Tabs_Portrait(boolean nightModeEnabled) throws Exception { public void testRenderDialog_3Tabs_Portrait(boolean nightModeEnabled) throws Exception {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
prepareTabsWithThumbnail(mActivityTestRule, 3, 0, "about:blank"); prepareTabsWithThumbnail(mActivityTestRule, 3, 0, "about:blank");
...@@ -674,7 +663,6 @@ public class TabGridDialogTest { ...@@ -674,7 +663,6 @@ public class TabGridDialogTest {
@MediumTest @MediumTest
@Feature({"RenderTest"}) @Feature({"RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class) @ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "https://crbug.com/1108547")
public void testRenderDialog_3Tabs_Landscape(boolean nightModeEnabled) throws Exception { public void testRenderDialog_3Tabs_Landscape(boolean nightModeEnabled) throws Exception {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
prepareTabsWithThumbnail(mActivityTestRule, 3, 0, "about:blank"); prepareTabsWithThumbnail(mActivityTestRule, 3, 0, "about:blank");
...@@ -696,7 +684,6 @@ public class TabGridDialogTest { ...@@ -696,7 +684,6 @@ public class TabGridDialogTest {
@MediumTest @MediumTest
@Feature({"RenderTest"}) @Feature({"RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class) @ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "https://crbug.com/1108547")
public void testRenderDialog_5Tabs_InitialScroll(boolean nightModeEnabled) throws Exception { public void testRenderDialog_5Tabs_InitialScroll(boolean nightModeEnabled) throws Exception {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity(); final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
prepareTabsWithThumbnail(mActivityTestRule, 5, 0, "about:blank"); prepareTabsWithThumbnail(mActivityTestRule, 5, 0, "about:blank");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment