Commit 65306b8c authored by Nohemi Fernandez's avatar Nohemi Fernandez Committed by Commit Bot

[iOS][MICE] Remove identity section from Google Services Settings.

For MICE we are moving all identity information into the top-level
Settings page. The Google Services Settings will now only contain
the relevant Services information.

Before: https://drive.google.com/file/d/1IaeI3UWGWIeFEWWR8s_FZIFQ_99ZDqha
After: https://drive.google.com/file/d/1jP4iYi5Fewd1o2hn5scJEwaYW-jgmdsK

Bug: 1151296
Change-Id: I6ce11e114873ae9ec411bfb6aeec342c4165083d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550555Reviewed-by: default avatarJérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829665}
parent c8ff9eac
...@@ -264,6 +264,10 @@ NSString* kGoogleServicesSyncErrorImage = @"google_services_sync_error"; ...@@ -264,6 +264,10 @@ NSString* kGoogleServicesSyncErrorImage = @"google_services_sync_error";
// Creates, removes or updates the identity section as needed. And notifies the // Creates, removes or updates the identity section as needed. And notifies the
// consumer. // consumer.
- (void)updateIdentitySectionAndNotifyConsumer { - (void)updateIdentitySectionAndNotifyConsumer {
// Do not display the identity section in Google Services for MICE.
if (base::FeatureList::IsEnabled(signin::kMobileIdentityConsistency)) {
return;
}
TableViewModel* model = self.consumer.tableViewModel; TableViewModel* model = self.consumer.tableViewModel;
BOOL hasIdentitySection = BOOL hasIdentitySection =
[model hasSectionForSectionIdentifier:IdentitySectionIdentifier]; [model hasSectionForSectionIdentifier:IdentitySectionIdentifier];
...@@ -810,10 +814,10 @@ NSString* kGoogleServicesSyncErrorImage = @"google_services_sync_error"; ...@@ -810,10 +814,10 @@ NSString* kGoogleServicesSyncErrorImage = @"google_services_sync_error";
- (void)googleServicesSettingsViewControllerLoadModel: - (void)googleServicesSettingsViewControllerLoadModel:
(GoogleServicesSettingsViewController*)controller { (GoogleServicesSettingsViewController*)controller {
DCHECK_EQ(self.consumer, controller); DCHECK_EQ(self.consumer, controller);
[self loadIdentitySection];
// For the MICE experiment Chrome will display the Sync section within "Manage // For the MICE experiment Chrome will display the Sync section within "Manage
// Sync Settings". // Sync Settings".
if (!base::FeatureList::IsEnabled(signin::kMobileIdentityConsistency)) { if (!base::FeatureList::IsEnabled(signin::kMobileIdentityConsistency)) {
[self loadIdentitySection];
[self loadSyncSection]; [self loadSyncSection];
} }
[self loadNonPersonalizedSection]; [self loadNonPersonalizedSection];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment