Commit 65338c09 authored by Nico Weber's avatar Nico Weber

Enable more tests on the cros memory bots.

The motivation is to remove chromium_memory_chromiumos_asan_gtests in favor
of linux_chromeos_rel_gtests, but when I tried doing that directly [1], I got
many asan/lsan and msan reports for these tests. Some of them pass however,
so I'd like to lock in the working ones while I work on fixing the broken ones.

1: https://chromium-review.googlesource.com/c/chromium/src/+/1110703

Adds to "Linux ChromiumOS MSan Tests" and "Linux Chromium OS ASan LSan Tests (1)" these tests:
- chromevox_tests
- gl_unittests_ozone (to asan/lsan only)
- ozone_gl_unittests
- ozone_x11_unittests
- select_to_speak_extension_tests
- views_mus_interactive_ui_tests

Bug: 843511
Bug: 855573,855580,855588
Bug: 855584,855585,855583
Change-Id: I9402cd43d1d0ef95432eba8231ae79c936b4848b
Reviewed-on: https://chromium-review.googlesource.com/1112037Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569725}
parent 77ab0de5
...@@ -4364,6 +4364,12 @@ ...@@ -4364,6 +4364,12 @@
}, },
"test": "chromeos_unittests" "test": "chromeos_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "chromevox_tests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": true "can_use_on_swarming_builders": true
...@@ -4472,6 +4478,12 @@ ...@@ -4472,6 +4478,12 @@
}, },
"test": "gfx_unittests" "test": "gfx_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "gl_unittests_ozone"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": true "can_use_on_swarming_builders": true
...@@ -4594,6 +4606,21 @@ ...@@ -4594,6 +4606,21 @@
}, },
"test": "net_unittests" "test": "net_unittests"
}, },
{
"args": [
"--ozone-platform=headless"
],
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "ozone_gl_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "ozone_x11_unittests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": true "can_use_on_swarming_builders": true
...@@ -4624,6 +4651,12 @@ ...@@ -4624,6 +4651,12 @@
}, },
"test": "sandbox_linux_unittests" "test": "sandbox_linux_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "select_to_speak_extension_tests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": true "can_use_on_swarming_builders": true
...@@ -4702,6 +4735,12 @@ ...@@ -4702,6 +4735,12 @@
}, },
"test": "url_unittests" "test": "url_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "views_mus_interactive_ui_tests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": true "can_use_on_swarming_builders": true
...@@ -4893,6 +4932,13 @@ ...@@ -4893,6 +4932,13 @@
}, },
"test": "chromeos_unittests" "test": "chromeos_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": true,
"shards": 4
},
"test": "chromevox_tests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": true "can_use_on_swarming_builders": true
...@@ -5127,6 +5173,21 @@ ...@@ -5127,6 +5173,21 @@
}, },
"test": "net_unittests" "test": "net_unittests"
}, },
{
"args": [
"--ozone-platform=headless"
],
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "ozone_gl_unittests"
},
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "ozone_x11_unittests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": true "can_use_on_swarming_builders": true
...@@ -5157,6 +5218,12 @@ ...@@ -5157,6 +5218,12 @@
}, },
"test": "sandbox_linux_unittests" "test": "sandbox_linux_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "select_to_speak_extension_tests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": true "can_use_on_swarming_builders": true
...@@ -5229,6 +5296,12 @@ ...@@ -5229,6 +5296,12 @@
}, },
"test": "url_unittests" "test": "url_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": true
},
"test": "views_mus_interactive_ui_tests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": true "can_use_on_swarming_builders": true
......
...@@ -638,6 +638,16 @@ ...@@ -638,6 +638,16 @@
'linux-chromeos-rel', 'linux-chromeos-rel',
], ],
}, },
'chromevox_tests': {
'modifications': {
# Takes a long time under msan for some reason.
'Linux ChromiumOS MSan Tests': {
'swarming': {
'shards': 4,
},
},
},
},
'components_browsertests': { 'components_browsertests': {
'remove_from': [ 'remove_from': [
# chromium.chromiumos # chromium.chromiumos
...@@ -1391,6 +1401,13 @@ ...@@ -1391,6 +1401,13 @@
}, },
}, },
}, },
'gl_unittests_ozone': {
'remove_from': [
# Can't run on MSAN because gl_unittests_ozone uses the hardware driver,
# which isn't instrumented.
'Linux ChromiumOS MSan Tests',
],
},
'gn_unittests': { 'gn_unittests': {
'remove_from': [ 'remove_from': [
# chromium.fyi # chromium.fyi
......
...@@ -1807,6 +1807,28 @@ ...@@ -1807,6 +1807,28 @@
'wayland_client_perftests': {}, 'wayland_client_perftests': {},
}, },
# The Chrome OS memory bots should run linux_chromeos_rel_specific_gtests,
# but currently they don't, and not all of the tests in
# linux_chromeos_rel_specific_gtests currently pass on asan and msan.
# This contains the tests that currently pass.
# TODO(thakis): Fix all failing tests, add them here, then remove this.
'linux_chromeos_rel_specific_gtests_asan_bringup': {
'chromevox_tests': {},
#'exo_unittests': {}, # https://crbug.com/855573
'gl_unittests_ozone': {},
'ozone_gl_unittests': {
'args': [
'--ozone-platform=headless',
],
},
#'ozone_unittests': {}, # https://crbug.com/855580, https://crbug.com/855588
'ozone_x11_unittests': {},
'select_to_speak_extension_tests': {},
#'views_mus_unittests': {}, # https://crbug.com/855584, https://crbug.com/855585
'views_mus_interactive_ui_tests': {},
#'wayland_client_perftests': {}, # https://crbug.com/855583
},
'linux_chromeos_specific_gtests': { 'linux_chromeos_specific_gtests': {
# Chrome OS only. # Chrome OS only.
'app_list_unittests': {}, 'app_list_unittests': {},
...@@ -2478,6 +2500,7 @@ ...@@ -2478,6 +2500,7 @@
'chromium_gtests_for_devices_with_graphical_output', 'chromium_gtests_for_devices_with_graphical_output',
'chromium_gtests_for_linux_and_chromeos_only', 'chromium_gtests_for_linux_and_chromeos_only',
'linux_chromeos_specific_gtests', 'linux_chromeos_specific_gtests',
'linux_chromeos_rel_specific_gtests_asan_bringup',
'linux_flavor_specific_chromium_gtests', 'linux_flavor_specific_chromium_gtests',
'mash_chromium_gtests', 'mash_chromium_gtests',
'non_android_chromium_gtests', 'non_android_chromium_gtests',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment