Commit 659c8284 authored by tkent's avatar tkent Committed by Commit bot

DOM: Remove blink::NodeFilterCondition.

This interface isn't helpful.

BUG=591919

Review-Url: https://codereview.chromium.org/2841393002
Cr-Commit-Position: refs/heads/master@{#467622}
parent 8ff4d283
...@@ -33,7 +33,6 @@ ...@@ -33,7 +33,6 @@
#include "bindings/core/v8/ScriptWrappable.h" #include "bindings/core/v8/ScriptWrappable.h"
#include "bindings/core/v8/TraceWrapperV8Reference.h" #include "bindings/core/v8/TraceWrapperV8Reference.h"
#include "core/dom/NodeFilterCondition.h"
#include "platform/heap/Handle.h" #include "platform/heap/Handle.h"
#include "v8/include/v8.h" #include "v8/include/v8.h"
...@@ -48,8 +47,9 @@ class ScriptState; ...@@ -48,8 +47,9 @@ class ScriptState;
// is referenced by a NodeIterator/TreeWalker. // is referenced by a NodeIterator/TreeWalker.
// //
// Binding generator should generate this code. See crbug.com/630986. // Binding generator should generate this code. See crbug.com/630986.
class V8NodeFilterCondition final : public NodeFilterCondition, class V8NodeFilterCondition final
public TraceWrapperBase { : public GarbageCollectedFinalized<V8NodeFilterCondition>,
public TraceWrapperBase {
public: public:
static V8NodeFilterCondition* CreateOrNull(v8::Local<v8::Value> filter, static V8NodeFilterCondition* CreateOrNull(v8::Local<v8::Value> filter,
ScriptState* script_state) { ScriptState* script_state) {
...@@ -57,10 +57,11 @@ class V8NodeFilterCondition final : public NodeFilterCondition, ...@@ -57,10 +57,11 @@ class V8NodeFilterCondition final : public NodeFilterCondition,
: new V8NodeFilterCondition(filter, script_state); : new V8NodeFilterCondition(filter, script_state);
} }
~V8NodeFilterCondition() override; ~V8NodeFilterCondition();
DEFINE_INLINE_VIRTUAL_TRACE() {}
DECLARE_TRACE_WRAPPERS(); DECLARE_TRACE_WRAPPERS();
unsigned acceptNode(Node*, ExceptionState&) const override; unsigned acceptNode(Node*, ExceptionState&) const;
v8::Local<v8::Value> Callback(v8::Isolate* isolate) const { v8::Local<v8::Value> Callback(v8::Isolate* isolate) const {
return filter_.NewLocal(isolate); return filter_.NewLocal(isolate);
} }
......
...@@ -225,7 +225,6 @@ blink_core_sources("dom") { ...@@ -225,7 +225,6 @@ blink_core_sources("dom") {
"NodeChildRemovalTracker.h", "NodeChildRemovalTracker.h",
"NodeComputedStyle.h", "NodeComputedStyle.h",
"NodeFilter.h", "NodeFilter.h",
"NodeFilterCondition.h",
"NodeIterator.cpp", "NodeIterator.cpp",
"NodeIterator.h", "NodeIterator.h",
"NodeIteratorBase.cpp", "NodeIteratorBase.cpp",
......
/*
* Copyright (C) 1999 Lars Knoll (knoll@kde.org)
* Copyright (C) 2000 Frederik Holljen (frederik.holljen@hig.no)
* Copyright (C) 2001 Peter Kelly (pmk@post.com)
* Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
* Copyright (C) 2004, 2008, 2009 Apple Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Library General Public License for more details.
*
* You should have received a copy of the GNU Library General Public License
* along with this library; see the file COPYING.LIB. If not, write to
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*
*/
#ifndef NodeFilterCondition_h
#define NodeFilterCondition_h
#include "platform/heap/Handle.h"
namespace blink {
class ExceptionState;
class Node;
// TODO(tkent): This abstraction isn't helpful. Fold this into
// V8NodeFilterCondition.
class NodeFilterCondition
: public GarbageCollectedFinalized<NodeFilterCondition> {
public:
virtual ~NodeFilterCondition() {}
virtual unsigned acceptNode(Node*, ExceptionState&) const = 0;
DEFINE_INLINE_VIRTUAL_TRACE() {}
};
} // namespace blink
#endif // NodeFilterCondition_h
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment