Commit 65b21d71 authored by Jesse Schettler's avatar Jesse Schettler Committed by Chromium LUCI CQ

scanning: Update help links

Update all the help links with the p-link for the scanning support
article.

Bug: 1059779
Change-Id: Ie6d04ad168de7a97f4afbb042c747000d60376a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596421Reviewed-by: default avatarZentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837828}
parent d1154a5c
......@@ -37,7 +37,9 @@
<div id="scanHelp" slot="error"
hidden$="[[shouldHideScanHelpLink_(loaded, scanners)]]">
[[i18n('noScannersHelpText')]]
<!-- TODO(gavinwill): Add href to the help link when available -->
<a id="scanHelpLink" href="#">[[i18n('noScannersHelpLinkLabel')]]</a>
<a id="scanHelpLink" target="_blank"
href="http://support.google.com/chromebook?p=chrome_scanning">
[[i18n('noScannersHelpLinkLabel')]]
</a>
</div>
</scan-settings-section>
......@@ -211,9 +211,10 @@
<iron-icon id="toastInfoIcon" icon="cr:info-outline"
hidden="[[!showToastInfoIcon_]]"></iron-icon>
<span id="toastText">[[i18n(toastMessageKey_)]]</span>
<!-- TODO(gavinwill): Add href to the help link when available -->
<div id="getHelpDiv">
<a id="getHelpLink" href="#" hidden="[[!showToastHelpLink_]]">
<a id="getHelpLink" target="_blank"
href="http://support.google.com/chromebook?p=chrome_scanning"
hidden="[[!showToastHelpLink_]]">
[[i18n('getHelpLinkText')]]</a>
</div>
</div>
......@@ -227,8 +228,7 @@
[[i18n('scanFailedDialogBodyText')]]
</div>
<div slot="button-container">
<!-- TODO(gavinwill): Add href to the help link when available -->
<cr-button class="cancel-button">
<cr-button class="cancel-button" on-click="onDialogGetHelpClick_">
[[i18n('getHelpLinkText')]]
</cr-button>
<cr-button id="okButton" class="action-button"
......
......@@ -549,4 +549,11 @@ Polymer({
this.$.scanFailedDialog.close();
this.setAppState_(AppState.READY);
},
/** @private */
onDialogGetHelpClick_() {
this.$.scanFailedDialog.close();
this.setAppState_(AppState.READY);
window.open('http://support.google.com/chromebook?p=chrome_scanning');
},
});
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment