Commit 65b77986 authored by qyearsley's avatar qyearsley Committed by Commit bot

Add -f flag to git cl upload when uploading patchset in wpt importer

The last couple import jobs failed when uploading the second patchset;
I think that it failed at this point (and not when uploading the
CL initially) because when initially uploading the CL it uses -f.

We want to use -f in general to ignore presubmit warnings for things
like tabs.

Review-Url: https://codereview.chromium.org/2802093002
Cr-Commit-Position: refs/heads/master@{#462698}
parent a1c5ca58
......@@ -352,6 +352,7 @@ class TestImporter(object):
if try_results and self.git_cl.has_failing_try_results(try_results):
self.fetch_new_expectations_and_baselines()
self._upload_patchset('Update test expectations and baselines.')
# Trigger CQ and wait for CQ try jobs to finish.
self.git_cl.run(['set-commit', '--gerrit'])
......@@ -386,6 +387,9 @@ class TestImporter(object):
description,
] + self._cc_part(directory_owners))
def _upload_patchset(self, message):
self.git_cl.run(['upload', '-f', '-t', message, '--gerrit'])
@staticmethod
def _cc_part(directory_owners):
cc_part = []
......@@ -435,9 +439,6 @@ class TestImporter(object):
_log.info('Adding test expectations lines to LayoutTests/TestExpectations.')
expectation_updater = WPTExpectationsUpdater(self.host)
expectation_updater.run(args=[])
message = 'Update test expectations and baselines.'
self.check_run(['git', 'commit', '-a', '-m', message])
self.git_cl.run(['upload', '-t', message, '--gerrit'])
def update_all_test_expectations_files(self, deleted_tests, renamed_tests):
"""Updates all test expectations files for tests that have been deleted or renamed."""
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment