[Perf] Port remaining results.failures usages to had_failures

Bug: catapult:#4229
Change-Id: I2c7f90eac3f99178ea7729f3bfa14a44120d621f
Reviewed-on: https://chromium-review.googlesource.com/940267
Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#539923}

tools/perf/benchmarks/blink_perf_unittest.py

@@ -42,7 +42,7 @@ class BlinkPerfTest(page_test_test_case.PageTestTestCase):
     results = self.RunMeasurement(measurement=self._measurement,
         ps=self._CreateStorySetForTestFile('append-child-measure-time.html'),
         options=self._options)
-    self.assertFalse(results.failures)
+    self.assertFalse(results.had_failures)
     self.assertEquals(len(results.FindAllTraceValues()), 1)
 
     frame_view_layouts = results.FindAllPageSpecificValuesNamed(
@@ -65,7 +65,7 @@ class BlinkPerfTest(page_test_test_case.PageTestTestCase):
         ps=self._CreateStorySetForTestFile(
             'color-changes-measure-frame-time.html'),
         options=self._options)
-    self.assertFalse(results.failures)
+    self.assertFalse(results.had_failures)
     self.assertEquals(len(results.FindAllTraceValues()), 1)
 
     frame_view_prepaints = results.FindAllPageSpecificValuesNamed(
@@ -89,7 +89,7 @@ class BlinkPerfTest(page_test_test_case.PageTestTestCase):
         ps=self._CreateStorySetForTestFile(
             'simple-html-measure-page-load-time.html'),
         options=self._options)
-    self.assertFalse(results.failures)
+    self.assertFalse(results.had_failures)
     self.assertEquals(len(results.FindAllTraceValues()), 1)
 
     create_child_frame = results.FindAllPageSpecificValuesNamed(

tools/perf/contrib/cluster_telemetry/repaint_unittest.py

@@ -43,7 +43,7 @@ class RepaintUnitTest(page_test_test_case.PageTestTestCase):
     ps.AddStory(TestRepaintPage(ps, ps.base_dir))
     measurement = smoothness.Smoothness()
     results = self.RunMeasurement(measurement, ps, options=self._options)
-    self.assertEquals(0, len(results.failures))
+    self.assertFalse(results.had_failures)
 
     frame_times = results.FindAllPageSpecificValuesNamed('frame_times')
     self.assertEquals(len(frame_times), 1)

tools/perf/contrib/oilpan/oilpan_gc_times_unittest.py

@@ -163,7 +163,7 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):
         'create_many_objects.html')
     measurement = oilpan_gc_times.OilpanGCTimesForSmoothness()
     results = self.RunMeasurement(measurement, ps, options=self._options)
-    self.assertEquals(0, len(results.failures))
+    self.assertFalse(results.had_failures)
 
     gc_events = []
     for gc_reason in self._GC_REASONS:
@@ -176,7 +176,7 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):
         'create_many_objects.html')
     measurement = oilpan_gc_times.OilpanGCTimesForBlinkPerf()
     results = self.RunMeasurement(measurement, ps, options=self._options)
-    self.assertEquals(0, len(results.failures))
+    self.assertFalse(results.had_failures)
 
     gc_events = []
     for gc_reason in self._GC_REASONS:

tools/perf/measurements/rasterize_and_record_micro_unittest.py

@@ -36,7 +36,7 @@ class RasterizeAndRecordMicroUnitTest(page_test_test_case.PageTestTestCase):
     except legacy_page_test.TestNotSupportedOnPlatformError as failure:
       logging.warning(str(failure))
       return
-    self.assertEquals(0, len(results.failures))
+    self.assertFalse(results.had_failures)
 
     rasterize_time = results.FindAllPageSpecificValuesNamed('rasterize_time')
     self.assertEquals(len(rasterize_time), 1)

tools/perf/measurements/smoothness_unittest.py

@@ -63,7 +63,7 @@ class SmoothnessUnitTest(page_test_test_case.PageTestTestCase):
     ps = self.CreateStorySetFromFileInUnittestDataDir('scrollable_page.html')
     measurement = smoothness.Smoothness()
     results = self.RunMeasurement(measurement, ps, options=self._options)
-    self.assertEquals(0, len(results.failures))
+    self.assertFalse(results.had_failures)
 
     frame_times = results.FindAllPageSpecificValuesNamed('frame_times')
     self.assertEquals(len(frame_times), 1)
@@ -95,7 +95,7 @@ class SmoothnessUnitTest(page_test_test_case.PageTestTestCase):
     ps = self.CreateStorySetFromFileInUnittestDataDir('scrollable_page.html')
     measurement = smoothness.Smoothness()
     results = self.RunMeasurement(measurement, ps, options=self._options)
-    self.assertEquals(0, len(results.failures))
+    self.assertFalse(results.had_failures)
 
     avg_surface_fps = results.FindAllPageSpecificValuesNamed('avg_surface_fps')
     self.assertEquals(1, len(avg_surface_fps))

tools/perf/measurements/thread_times_unittest.py

@@ -35,7 +35,7 @@ class ThreadTimesUnitTest(page_test_test_case.PageTestTestCase):
     measurement = thread_times.ThreadTimes()
     timeline_options = self._options
     results = self.RunMeasurement(measurement, ps, options=timeline_options)
-    self.assertFalse(len(results.failures), results.failures)
+    self.assertFalse(results.had_failures)
 
     for interval in timeline.IntervalNames:
       for category in timeline.TimelineThreadCategories.values():
@@ -48,7 +48,7 @@ class ThreadTimesUnitTest(page_test_test_case.PageTestTestCase):
     ps = self.CreateStorySetFromFileInUnittestDataDir('scrollable_page.html')
     measurement = thread_times.ThreadTimes(report_silk_details=True)
     results = self.RunMeasurement(measurement, ps, options=self._options)
-    self.assertEquals(0, len(results.failures))
+    self.assertFalse(results.had_failures)
 
     main_thread = 'renderer_main'
     expected_trace_categories = ['blink', 'cc', 'idle']

tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py

@@ -99,7 +99,7 @@ class V8DetachedContextAgeInGCTests(page_test_test_case.PageTestTestCase):
     page_set.AddStory(page)
     metric = v8_detached_context_age_in_gc.V8DetachedContextAgeInGC()
     results = self.RunMeasurement(metric, page_set, options=self._options)
-    self.assertEquals(0, len(results.failures), msg=str(results.failures))
+    self.assertFalse(results.had_failures)
     actual = _ActualValues(results)['V8_DetachedContextAgeInGC']
     self.assertLessEqual(0, actual.value)
     self.assertEqual('garbage_collections', actual.units)