Commit 65ff831d authored by Oystein Eftevaag's avatar Oystein Eftevaag Committed by Commit Bot

[Tracing sampling profiler] Disable on OS X 10.16

R=nyquist@chromium.org,ssid@chromium.org

Bug: 1098119
Change-Id: I12279236117ee69bc43110f1b63262afec629a69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264460Reviewed-by: default avatarssid <ssid@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782088}
parent 7e39f86c
......@@ -35,6 +35,10 @@
#include "base/android/reached_code_profiler.h"
#endif
#if defined(OS_MACOSX)
#include "base/mac/mac_util.h"
#endif
#if defined(OS_ANDROID) && BUILDFLAG(CAN_UNWIND_WITH_CFI_TABLE) && \
defined(OFFICIAL_BUILD)
#include <dlfcn.h>
......@@ -637,6 +641,14 @@ void TracingSamplerProfiler::StartTracing(
return;
#endif
#if defined(OS_MACOSX)
// TODO(https://crbug.com/1098119): Fix unwinding on OS X 10.16. The OS has
// moved all system libraries into the dyld shared cache and this seems to
// break the sampling profiler.
if (base::mac::IsOSLaterThan10_15_DontCallThis())
return;
#endif
base::StackSamplingProfiler::SamplingParams params;
params.samples_per_profile = std::numeric_limits<int>::max();
params.sampling_interval = base::TimeDelta::FromMilliseconds(50);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment