Account for dip scale mismatch in VR for control height.
In VR, we change the dip scale of the WebContents, but cannot properly change the dip scale of Java UI because doing so would require reinflating said java UI. This leads to problems when determining the offset applied by the top/bottom controls. RenderWidgetHostViewAndroid previously converted the shown ratio of the controls to pixel values using the dip scale of the WebContents, while ChromeFullscreenManager converted the control height to pixels using the Java UI dpr. It then treated a mismatch between these two values as the control container being visible, even if the shown ratio was 0. This CL changes the FullscreenManager to always apply fully-hidden control offsets while in VR since the controls will be hidden anyways. Bug: 793430 Change-Id: If18aa601ed51ea91cef6b83060972d216a8cd6a9 Reviewed-on: https://chromium-review.googlesource.com/818116 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#524430}
Showing
Please register or sign in to comment