Commit 6674c130 authored by Ewann's avatar Ewann Committed by Commit Bot

Adds persistent downloads's flag

- Adds persistent downloads's flag.

Bug: 1013072
Change-Id: Ic5db8f631d0740748807434fddb52ba1da5505f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852086
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712966}
parent 72048a94
...@@ -562,6 +562,10 @@ const flags_ui::FeatureEntry kFeatureEntries[] = { ...@@ -562,6 +562,10 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
flags_ui::kOsIos, flags_ui::kOsIos,
FEATURE_VALUE_TYPE( FEATURE_VALUE_TYPE(
autofill::features::kAutofillSaveCardDismissOnNavigation)}, autofill::features::kAutofillSaveCardDismissOnNavigation)},
{"enable-persistent-downloads",
flag_descriptions::kEnablePersistentDownloadsName,
flag_descriptions::kEnablePersistentDownloadsDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(web::features::kEnablePersistentDownloads)},
}; };
// Add all switches from experimental flags to |command_line|. // Add all switches from experimental flags to |command_line|.
......
...@@ -185,6 +185,10 @@ const char kEnableClipboardProviderTextSuggestionsName[] = ...@@ -185,6 +185,10 @@ const char kEnableClipboardProviderTextSuggestionsName[] =
const char kEnableClipboardProviderTextSuggestionsDescription[] = const char kEnableClipboardProviderTextSuggestionsDescription[] =
"Enable suggesting a search for text copied to the clipboard"; "Enable suggesting a search for text copied to the clipboard";
const char kEnablePersistentDownloadsName[] = "Enable persistent downloads";
const char kEnablePersistentDownloadsDescription[] =
"Enables the new, experimental implementation of persistent downloads";
const char kEnableSyncUSSPasswordsName[] = "Enable USS for passwords sync"; const char kEnableSyncUSSPasswordsName[] = "Enable USS for passwords sync";
const char kEnableSyncUSSPasswordsDescription[] = const char kEnableSyncUSSPasswordsDescription[] =
"Enables the new, experimental implementation of password sync"; "Enables the new, experimental implementation of password sync";
......
...@@ -153,6 +153,10 @@ extern const char kEnableClipboardProviderImageSuggestionsDescription[]; ...@@ -153,6 +153,10 @@ extern const char kEnableClipboardProviderImageSuggestionsDescription[];
extern const char kEnableClipboardProviderTextSuggestionsName[]; extern const char kEnableClipboardProviderTextSuggestionsName[];
extern const char kEnableClipboardProviderTextSuggestionsDescription[]; extern const char kEnableClipboardProviderTextSuggestionsDescription[];
// Title and description for the flag to enable persistent downloads.
extern const char kEnablePersistentDownloadsName[];
extern const char kEnablePersistentDownloadsDescription[];
extern const char kEnableSyncUSSPasswordsName[]; extern const char kEnableSyncUSSPasswordsName[];
extern const char kEnableSyncUSSPasswordsDescription[]; extern const char kEnableSyncUSSPasswordsDescription[];
......
...@@ -45,6 +45,9 @@ extern const base::Feature kUseWKWebViewLoading; ...@@ -45,6 +45,9 @@ extern const base::Feature kUseWKWebViewLoading;
// Feature flag to move -LogLoadStarted() to WebStateDidStartNavigation(). // Feature flag to move -LogLoadStarted() to WebStateDidStartNavigation().
extern const base::Feature kLogLoadStartedInDidStartNavigation; extern const base::Feature kLogLoadStartedInDidStartNavigation;
// Feature flag enabling persistent downloads.
extern const base::Feature kEnablePersistentDownloads;
// Use WKWebView.loading to update WebState::IsLoading. // Use WKWebView.loading to update WebState::IsLoading.
// TODO(crbug.com/1006012): Clean up this flag after experiment. // TODO(crbug.com/1006012): Clean up this flag after experiment.
bool UseWKWebViewLoading(); bool UseWKWebViewLoading();
......
...@@ -41,6 +41,9 @@ const base::Feature kUseWKWebViewLoading{"UseWKWebViewLoading", ...@@ -41,6 +41,9 @@ const base::Feature kUseWKWebViewLoading{"UseWKWebViewLoading",
const base::Feature kLogLoadStartedInDidStartNavigation{ const base::Feature kLogLoadStartedInDidStartNavigation{
"LogLoadStartedInDidStartNavigation", base::FEATURE_ENABLED_BY_DEFAULT}; "LogLoadStartedInDidStartNavigation", base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kEnablePersistentDownloads{
"EnablePersistentDownloads", base::FEATURE_DISABLED_BY_DEFAULT};
// The feature kUseWKWebViewLoading will change the CPM if // The feature kUseWKWebViewLoading will change the CPM if
// kLogLoadStartedInDidStartNavigation is not enabled, so // kLogLoadStartedInDidStartNavigation is not enabled, so
// kLogLoadStartedInDidStartNavigation is required. The feature flag // kLogLoadStartedInDidStartNavigation is required. The feature flag
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment