Google C++ style guide recomends nothrow move constructors

and generally applying noexcept where it make sense.
https://google.github.io/styleguide/cppguide.html#noexcept

Noexcept until recently didn't work with out of line default declarations.
This CL tests that now it compiles on all platforms by applying noexcept for
a few default move operations.

Since this CL is useful not only to test but to merge too, I suggest we merge it.

Discussion on noexcept:
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/cxx/ze4WJFg7RvU/6wU_9xltBgAJ

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If65a9da6dc803e4dbd03765656a6f122bcb8210e
Reviewed-on: https://chromium-review.googlesource.com/1046005Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Denis Yaroshevskiy <dyaroshev@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#557813}

components/policy/core/common/policy_map.cc

@@ -15,9 +15,8 @@ PolicyMap::Entry::Entry() = default;
 
 PolicyMap::Entry::~Entry() = default;
 
-PolicyMap::Entry::Entry(Entry&&) = default;
-
-PolicyMap::Entry& PolicyMap::Entry::operator=(Entry&&) = default;
+PolicyMap::Entry::Entry(Entry&&) noexcept = default;
+PolicyMap::Entry& PolicyMap::Entry::operator=(Entry&&) noexcept = default;
 
 PolicyMap::Entry PolicyMap::Entry::DeepCopy() const {
   Entry copy;

components/policy/core/common/policy_map.h

@@ -38,8 +38,8 @@ class POLICY_EXPORT PolicyMap {
     Entry();
     ~Entry();
 
-    Entry(Entry&&);
-    Entry& operator=(Entry&&);
+    Entry(Entry&&) noexcept;
+    Entry& operator=(Entry&&) noexcept;
 
     // Returns a copy of |this|.
     Entry DeepCopy() const;

components/previews/core/previews_black_list_item.cc

@@ -17,10 +17,10 @@ PreviewsBlackListItem::OptOutRecord::OptOutRecord(base::Time entry_time,
 
 PreviewsBlackListItem::OptOutRecord::~OptOutRecord() {}
 
-PreviewsBlackListItem::OptOutRecord::OptOutRecord(OptOutRecord&&) = default;
-
+PreviewsBlackListItem::OptOutRecord::OptOutRecord(OptOutRecord&&) noexcept =
+    default;
 PreviewsBlackListItem::OptOutRecord& PreviewsBlackListItem::OptOutRecord::
-operator=(OptOutRecord&&) = default;
+operator=(OptOutRecord&&) noexcept = default;
 
 bool PreviewsBlackListItem::OptOutRecord::operator<(
     const OptOutRecord& other) const {

components/previews/core/previews_black_list_item.h

@@ -53,8 +53,8 @@ class PreviewsBlackListItem {
    public:
     OptOutRecord(base::Time entry_time, bool opt_out);
     ~OptOutRecord();
-    OptOutRecord(OptOutRecord&&);
-    OptOutRecord& operator=(OptOutRecord&&);
+    OptOutRecord(OptOutRecord&&) noexcept;
+    OptOutRecord& operator=(OptOutRecord&&) noexcept;
 
     // Used to determine eviction priority.
     bool operator<(const OptOutRecord& other) const;

components/search_provider_logos/logo_common.cc

@@ -11,18 +11,25 @@ namespace search_provider_logos {
 const int64_t kMaxTimeToLiveMS = INT64_C(30 * 24 * 60 * 60 * 1000);  // 30 days
 
 LogoMetadata::LogoMetadata() = default;
-LogoMetadata::LogoMetadata(const LogoMetadata& other) = default;
+LogoMetadata::LogoMetadata(const LogoMetadata&) = default;
+LogoMetadata::LogoMetadata(LogoMetadata&&) noexcept = default;
+LogoMetadata& LogoMetadata::operator=(const LogoMetadata&) = default;
+LogoMetadata& LogoMetadata::operator=(LogoMetadata&&) noexcept = default;
 LogoMetadata::~LogoMetadata() = default;
 
 EncodedLogo::EncodedLogo() = default;
-EncodedLogo::EncodedLogo(const EncodedLogo& other) = default;
+EncodedLogo::EncodedLogo(const EncodedLogo&) = default;
+EncodedLogo::EncodedLogo(EncodedLogo&&) noexcept = default;
+EncodedLogo& EncodedLogo::operator=(const EncodedLogo&) = default;
+EncodedLogo& EncodedLogo::operator=(EncodedLogo&&) noexcept = default;
 EncodedLogo::~EncodedLogo() = default;
 
 Logo::Logo() = default;
 Logo::~Logo() = default;
 
 LogoCallbacks::LogoCallbacks() = default;
-LogoCallbacks::LogoCallbacks(LogoCallbacks&&) = default;
+LogoCallbacks::LogoCallbacks(LogoCallbacks&&) noexcept = default;
+LogoCallbacks& LogoCallbacks::operator=(LogoCallbacks&&) noexcept = default;
 LogoCallbacks::~LogoCallbacks() = default;
 
 }  // namespace search_provider_logos

components/search_provider_logos/logo_common.h

@@ -33,7 +33,10 @@ enum class LogoType {
 // serialize and deserialize that field.
 struct LogoMetadata {
   LogoMetadata();
-  LogoMetadata(const LogoMetadata& other);
+  LogoMetadata(const LogoMetadata&);
+  LogoMetadata(LogoMetadata&&) noexcept;
+  LogoMetadata& operator=(const LogoMetadata&);
+  LogoMetadata& operator=(LogoMetadata&&) noexcept;
   ~LogoMetadata();
 
   // For use by the client ----------------------------------------------------
@@ -116,7 +119,10 @@ enum class LogoCallbackReason {
 
 struct EncodedLogo {
   EncodedLogo();
-  EncodedLogo(const EncodedLogo& other);
+  EncodedLogo(const EncodedLogo&);
+  EncodedLogo(EncodedLogo&&) noexcept;
+  EncodedLogo& operator=(const EncodedLogo& other);
+  EncodedLogo& operator=(EncodedLogo&& other) noexcept;
   ~EncodedLogo();
 
   // The jpeg- or png-encoded image.
@@ -147,7 +153,8 @@ struct LogoCallbacks {
   LogoCallback on_fresh_decoded_logo_available;
 
   LogoCallbacks();
-  LogoCallbacks(LogoCallbacks&&);
+  LogoCallbacks(LogoCallbacks&&) noexcept;
+  LogoCallbacks& operator=(LogoCallbacks&&) noexcept;
   ~LogoCallbacks();
 };
 

components/viz/service/frame_sinks/video_capture/interprocess_frame_pool.cc

@@ -207,10 +207,10 @@ bool InterprocessFramePool::CanLogSharedMemoryFailure() {
 }
 
 InterprocessFramePool::PooledBuffer::PooledBuffer() = default;
-InterprocessFramePool::PooledBuffer::PooledBuffer(PooledBuffer&& other) =
-    default;
+InterprocessFramePool::PooledBuffer::PooledBuffer(
+    PooledBuffer&& other) noexcept = default;
 InterprocessFramePool::PooledBuffer& InterprocessFramePool::PooledBuffer::
-operator=(PooledBuffer&& other) = default;
+operator=(PooledBuffer&& other) noexcept = default;
 InterprocessFramePool::PooledBuffer::~PooledBuffer() = default;
 
 }  // namespace viz

components/viz/service/frame_sinks/video_capture/interprocess_frame_pool.h

@@ -72,8 +72,8 @@ class VIZ_SERVICE_EXPORT InterprocessFramePool {
     mojo::ScopedSharedBufferMapping mapping;
 
     PooledBuffer();
-    PooledBuffer(PooledBuffer&&);
-    PooledBuffer& operator=(PooledBuffer&&);
+    PooledBuffer(PooledBuffer&&) noexcept;
+    PooledBuffer& operator=(PooledBuffer&&) noexcept;
     ~PooledBuffer();
   };