Commit 66a51065 authored by Matt Menke's avatar Matt Menke Committed by Chromium LUCI CQ

Make SSLClientSocketVersionTest.CTIsRequiredByExpectCT with partitioning

Currently, the test fails when all ExpectCT partitioning options is
enabled, because its call to AddExpectCT() uses an empty
NetworkIsolationKey, while its other calls use a specific transient key.
This CL fixes the test to pass in the same transient key.

This CL doesn't modify the test to enable ExpectCT partitioning, since
that has to be done before the TransportSecurityState is constructed.

Bug: 969893
Change-Id: Ie36e8d0fc8c10028f57925d393309dd3e1658faa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595628Reviewed-by: default avatarEmily Stark <estark@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837684}
parent 48624d10
...@@ -4391,7 +4391,7 @@ TEST_P(SSLClientSocketVersionTest, CTIsRequiredByExpectCT) { ...@@ -4391,7 +4391,7 @@ TEST_P(SSLClientSocketVersionTest, CTIsRequiredByExpectCT) {
const base::Time expiry = current_time + base::TimeDelta::FromSeconds(1000); const base::Time expiry = current_time + base::TimeDelta::FromSeconds(1000);
transport_security_state_->AddExpectCT( transport_security_state_->AddExpectCT(
host_port_pair().host(), expiry, true /* enforce */, host_port_pair().host(), expiry, true /* enforce */,
GURL("https://example-report.test"), NetworkIsolationKey()); GURL("https://example-report.test"), network_isolation_key);
MockExpectCTReporter reporter; MockExpectCTReporter reporter;
transport_security_state_->SetExpectCTReporter(&reporter); transport_security_state_->SetExpectCTReporter(&reporter);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment