Commit 66aa0614 authored by Maksim Ivanov's avatar Maksim Ivanov Committed by Commit Bot

Fix use-after-move in //content/browser/cache_storage/legacy/

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I97c18726ba379e806047cbb09e33f2bcf14f7a77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382756
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: default avatarBen Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803110}
parent 9a69d42a
...@@ -1400,11 +1400,11 @@ void LegacyCacheStorage::GetSizeThenCloseAllCachesImpl(SizeCallback callback) { ...@@ -1400,11 +1400,11 @@ void LegacyCacheStorage::GetSizeThenCloseAllCachesImpl(SizeCallback callback) {
for (const auto& cache_metadata : cache_index_->ordered_cache_metadata()) { for (const auto& cache_metadata : cache_index_->ordered_cache_metadata()) {
auto cache_handle = GetLoadedCache(cache_metadata.name); auto cache_handle = GetLoadedCache(cache_metadata.name);
LegacyCacheStorageCache::From(cache_handle) LegacyCacheStorageCache* cache =
->GetSizeThenClose( LegacyCacheStorageCache::From(cache_handle);
base::BindOnce(&LegacyCacheStorage::SizeRetrievedFromCache, cache->GetSizeThenClose(base::BindOnce(
weak_factory_.GetWeakPtr(), std::move(cache_handle), &LegacyCacheStorage::SizeRetrievedFromCache, weak_factory_.GetWeakPtr(),
barrier_closure, accumulator_ptr)); std::move(cache_handle), barrier_closure, accumulator_ptr));
} }
for (const auto& cache_it : doomed_caches_) { for (const auto& cache_it : doomed_caches_) {
...@@ -1441,11 +1441,11 @@ void LegacyCacheStorage::SizeImpl(SizeCallback callback) { ...@@ -1441,11 +1441,11 @@ void LegacyCacheStorage::SizeImpl(SizeCallback callback) {
continue; continue;
} }
CacheStorageCacheHandle cache_handle = GetLoadedCache(cache_metadata.name); CacheStorageCacheHandle cache_handle = GetLoadedCache(cache_metadata.name);
LegacyCacheStorageCache::From(cache_handle) LegacyCacheStorageCache* cache =
->Size(base::BindOnce(&LegacyCacheStorage::SizeRetrievedFromCache, LegacyCacheStorageCache::From(cache_handle);
weak_factory_.GetWeakPtr(), cache->Size(base::BindOnce(
std::move(cache_handle), barrier_closure, &LegacyCacheStorage::SizeRetrievedFromCache, weak_factory_.GetWeakPtr(),
accumulator_ptr)); std::move(cache_handle), barrier_closure, accumulator_ptr));
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment