Commit 66b4aeec authored by tommycli@chromium.org's avatar tommycli@chromium.org

Componentize ComponentUpdater: Remove erroneous task runner DCHECK in DefaultComponentInstaller.

Removes an erroneous DCHECK added in this patch: https://codereview.chromium.org/385013002/

This DCHECK is erroneous, because the Install() function in DefaultComponentInstaller is actually called on a different task runner than the member task runner.

It's called from ComponentUnpacker::Install. ComponentUnpacker has a different task runner with a different sequence token, so it's erroneous to DCHECK it against the member task runner of DefaultComponentInstaller.

BUG=397264

Review URL: https://codereview.chromium.org/419103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285526 0039d316-1c4b-4281-b951-d872f2087c98
parent 5cb96bd8
...@@ -74,8 +74,6 @@ bool DefaultComponentInstaller::InstallHelper( ...@@ -74,8 +74,6 @@ bool DefaultComponentInstaller::InstallHelper(
bool DefaultComponentInstaller::Install(const base::DictionaryValue& manifest, bool DefaultComponentInstaller::Install(const base::DictionaryValue& manifest,
const base::FilePath& unpack_path) { const base::FilePath& unpack_path) {
DCHECK(task_runner_);
DCHECK(task_runner_->RunsTasksOnCurrentThread());
std::string manifest_version; std::string manifest_version;
manifest.GetStringASCII("version", &manifest_version); manifest.GetStringASCII("version", &manifest_version);
base::Version version(manifest_version.c_str()); base::Version version(manifest_version.c_str());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment