Commit 66b86f69 authored by Mikhail Khokhlov's avatar Mikhail Khokhlov Committed by Commit Bot

Turn Results Processor formatting on for two benchmarks

This CL turns on native handling of all output format for two benchmarks:
power.desktop and startup.mobile. This is an experiment to make sure that
Results Processor is ready to handle output formatting on all platforms.

Bug: 981349
Change-Id: I760f51b8daf2594655cd9a2b4d05bb0fb21e7a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841552
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: default avatarJuan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704125}
parent f79552a4
...@@ -131,11 +131,24 @@ def ProcessOptions(options, standalone=False): ...@@ -131,11 +131,24 @@ def ProcessOptions(options, standalone=False):
else: else:
chosen_formats = ['html'] chosen_formats = ['html']
# The following is a temporary hack to switch on native handling of output
# formats for two benchmarks. This is an experiment to make sure
# that Results Processor is ready to handle output on all platforms.
# TODO(crbug.com/981349): Remove this after experiment is finished (i.e.
# all formats are considered HANDLED_NATIVELY).
force_native = False
if 'positional_args' in options.__dict__ and options.positional_args:
benchmark_name = options.positional_args[0]
if benchmark_name in ['power.desktop', 'startup.mobile']:
force_native = True
logging.warning('Force native handling of output formats for %s',
benchmark_name)
options.output_formats = [] options.output_formats = []
for output_format in chosen_formats: for output_format in chosen_formats:
if output_format == 'none': if output_format == 'none':
continue continue
elif standalone or output_format in HANDLED_NATIVELY: elif standalone or output_format in HANDLED_NATIVELY or force_native:
options.output_formats.append(output_format) options.output_formats.append(output_format)
else: else:
options.legacy_output_formats.append(output_format) options.legacy_output_formats.append(output_format)
......
...@@ -56,6 +56,7 @@ def ProcessResults(options): ...@@ -56,6 +56,7 @@ def ProcessResults(options):
options.results_label) options.results_label)
for output_format in options.output_formats: for output_format in options.output_formats:
logging.info('Processing format: %s', output_format)
formatter = formatters.FORMATTERS[output_format] formatter = formatters.FORMATTERS[output_format]
if output_format in FORMATS_WITH_METRICS: if output_format in FORMATS_WITH_METRICS:
formatter.ProcessHistogramDicts(histogram_dicts, options) formatter.ProcessHistogramDicts(histogram_dicts, options)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment