Commit 66c9f33d authored by thakis's avatar thakis Committed by Commit bot

reflow comments in Source/bindings/modules/v8

BUG=563793

Review-Url: https://codereview.chromium.org/2387073002
Cr-Commit-Position: refs/heads/master@{#422795}
parent 363f57dd
...@@ -52,7 +52,8 @@ void installConditionalFeaturesForModules( ...@@ -52,7 +52,8 @@ void installConditionalFeaturesForModules(
originTrialContext->isFeatureEnabled("DurableStorage"))) { originTrialContext->isFeatureEnabled("DurableStorage"))) {
V8NavigatorPartial::installDurableStorage( V8NavigatorPartial::installDurableStorage(
isolate, world, v8::Local<v8::Object>(), prototypeObject, isolate, world, v8::Local<v8::Object>(), prototypeObject,
interfaceObject); // Need to specify interface object explicitly to avoid looping back here interfaceObject); // Need to specify interface object explicitly to
// avoid looping back here
} }
if (RuntimeEnabledFeatures::webBluetoothEnabled() || if (RuntimeEnabledFeatures::webBluetoothEnabled() ||
(originTrialContext && (originTrialContext &&
......
...@@ -42,8 +42,9 @@ v8::Local<v8::Value> SerializedScriptValueForModulesFactory::deserialize( ...@@ -42,8 +42,9 @@ v8::Local<v8::Value> SerializedScriptValueForModulesFactory::deserialize(
deserializer.setBlobInfoArray(blobInfo); deserializer.setBlobInfoArray(blobInfo);
return deserializer.deserialize(); return deserializer.deserialize();
} }
// deserialize() can run arbitrary script (e.g., setters), which could result in |this| being destroyed. // deserialize() can run arbitrary script (e.g., setters), which could result
// Holding a RefPtr ensures we are alive (along with our internal data) throughout the operation. // in |this| being destroyed. Holding a RefPtr ensures we are alive (along
// with our internal data) throughout the operation.
RefPtr<SerializedScriptValue> protect(value); RefPtr<SerializedScriptValue> protect(value);
String& data = value->data(); String& data = value->data();
if (!data.impl()) if (!data.impl())
......
...@@ -455,7 +455,8 @@ bool injectV8KeyIntoV8Value(v8::Isolate* isolate, ...@@ -455,7 +455,8 @@ bool injectV8KeyIntoV8Value(v8::Isolate* isolate,
ASSERT(keyPath.getType() == IDBKeyPath::StringType); ASSERT(keyPath.getType() == IDBKeyPath::StringType);
Vector<String> keyPathElements = parseKeyPath(keyPath.string()); Vector<String> keyPathElements = parseKeyPath(keyPath.string());
// The conbination of a key generator and an empty key path is forbidden by spec. // The conbination of a key generator and an empty key path is forbidden by
// spec.
if (!keyPathElements.size()) { if (!keyPathElements.size()) {
ASSERT_NOT_REACHED(); ASSERT_NOT_REACHED();
return false; return false;
...@@ -605,7 +606,8 @@ void assertPrimaryKeyValidOrInjectable(ScriptState* scriptState, ...@@ -605,7 +606,8 @@ void assertPrimaryKeyValidOrInjectable(ScriptState* scriptState,
ScriptValue keyValue = ScriptValue::from(scriptState, value->primaryKey()); ScriptValue keyValue = ScriptValue::from(scriptState, value->primaryKey());
ScriptValue scriptValue(scriptState, deserializeIDBValueData(isolate, value)); ScriptValue scriptValue(scriptState, deserializeIDBValueData(isolate, value));
// This assertion is about already persisted data, so allow experimental types. // This assertion is about already persisted data, so allow experimental
// types.
const bool allowExperimentalTypes = true; const bool allowExperimentalTypes = true;
TrackExceptionState exceptionState; TrackExceptionState exceptionState;
IDBKey* expectedKey = createIDBKeyFromValueAndKeyPath( IDBKey* expectedKey = createIDBKeyFromValueAndKeyPath(
......
...@@ -61,7 +61,8 @@ bool V8SQLStatementErrorCallback::handleEvent(SQLTransaction* transaction, ...@@ -61,7 +61,8 @@ bool V8SQLStatementErrorCallback::handleEvent(SQLTransaction* transaction,
exceptionCatcher.SetVerbose(true); exceptionCatcher.SetVerbose(true);
v8::Local<v8::Value> result; v8::Local<v8::Value> result;
// FIXME: This comment doesn't make much sense given what the code is actually doing. // FIXME: This comment doesn't make much sense given what the code is actually
// doing.
// //
// Step 6: If the error callback returns false, then move on to the next // Step 6: If the error callback returns false, then move on to the next
// statement, if any, or onto the next overall step otherwise. Otherwise, // statement, if any, or onto the next overall step otherwise. Otherwise,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment