Commit 66d1b2d8 authored by Etienne Bergeron's avatar Etienne Bergeron Committed by Commit Bot

Add a renderers background tracing scenario

This CL is adding a renderers specific tracing scenario.

The previous tracing scenario was BENCHMARK_IPC which is not given
enough details to make renderers traces actionnale. We are making a
specific scenario and will add the required category to debug
renderers issues.

R=gab@chromium.org, oysteine@chromium.org

Change-Id: I8e0dbce3f18a403de6f0f7bb4c63abf4a1b53f66
Reviewed-on: https://chromium-review.googlesource.com/c/1286770
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: default avataroysteine <oysteine@chromium.org>
Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600773}
parent 17a64867
......@@ -36,6 +36,7 @@ const char kConfigCategoryBenchmarkMemoryLight[] = "BENCHMARK_MEMORY_LIGHT";
const char kConfigCategoryBenchmarkExecutionMetric[] =
"BENCHMARK_EXECUTION_METRIC";
const char kConfigCategoryBenchmarkNavigation[] = "BENCHMARK_NAVIGATION";
const char kConfigCategoryBenchmarkRenderers[] = "BENCHMARK_RENDERERS";
const char kConfigCategoryBlinkStyle[] = "BLINK_STYLE";
} // namespace
......@@ -70,6 +71,8 @@ std::string BackgroundTracingConfigImpl::CategoryPresetToString(
return kConfigCategoryBenchmarkExecutionMetric;
case BackgroundTracingConfigImpl::BENCHMARK_NAVIGATION:
return kConfigCategoryBenchmarkNavigation;
case BackgroundTracingConfigImpl::BENCHMARK_RENDERERS:
return kConfigCategoryBenchmarkRenderers;
case BackgroundTracingConfigImpl::BLINK_STYLE:
return kConfigCategoryBlinkStyle;
case BackgroundTracingConfigImpl::CATEGORY_PRESET_UNSET:
......@@ -132,6 +135,11 @@ bool BackgroundTracingConfigImpl::StringToCategoryPreset(
return true;
}
if (category_preset_string == kConfigCategoryBenchmarkRenderers) {
*category_preset = BackgroundTracingConfigImpl::BENCHMARK_RENDERERS;
return true;
}
if (category_preset_string == kConfigCategoryBlinkStyle) {
*category_preset = BackgroundTracingConfigImpl::BLINK_STYLE;
return true;
......
......@@ -38,6 +38,7 @@ class CONTENT_EXPORT BackgroundTracingConfigImpl
BENCHMARK_MEMORY_LIGHT,
BENCHMARK_EXECUTION_METRIC,
BENCHMARK_NAVIGATION,
BENCHMARK_RENDERERS,
BLINK_STYLE
};
......
......@@ -289,6 +289,7 @@ TEST_F(BackgroundTracingConfigTest, ValidPreemptiveCategoryToString) {
BackgroundTracingConfigImpl::BENCHMARK_MEMORY_LIGHT,
BackgroundTracingConfigImpl::BENCHMARK_EXECUTION_METRIC,
BackgroundTracingConfigImpl::BENCHMARK_NAVIGATION,
BackgroundTracingConfigImpl::BENCHMARK_RENDERERS,
BackgroundTracingConfigImpl::BLINK_STYLE,
};
......@@ -302,6 +303,7 @@ TEST_F(BackgroundTracingConfigTest, ValidPreemptiveCategoryToString) {
"BENCHMARK_MEMORY_LIGHT",
"BENCHMARK_EXECUTION_METRIC",
"BENCHMARK_NAVIGATION",
"BENCHMARK_RENDERERS",
"BLINK_STYLE"};
for (size_t i = 0;
i <
......
......@@ -684,6 +684,16 @@ TraceConfig BackgroundTracingManagerImpl::GetConfigForCategoryPreset(
config.SetProcessFilterConfig(process_config);
return config;
}
case BackgroundTracingConfigImpl::CategoryPreset::BENCHMARK_RENDERERS:
return TraceConfig(
"benchmark,toplevel,ipc,base,ui,v8,task_scheduler,renderer,blink,"
"blink_gc,"
"disabled-by-default-v8.gc,"
"disabled-by-default-blink_gc,"
"disabled-by-default-renderer.scheduler,"
"disabled-by-default-task_scheduler_diagnostics,"
"disabled-by-default-system_stats,disabled-by-default-cpu_profiler",
record_mode);
case BackgroundTracingConfigImpl::CategoryPreset::BLINK_STYLE:
return TraceConfig("blink_style", record_mode);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment