Commit 670499d7 authored by Bartek Nowierski's avatar Bartek Nowierski Committed by Commit Bot

Use auto& instead of auto in the range loop

There are a couple reasons for this change:
1. Avoid copying a struct larger than a pointer.
2. If the pointer in the struct gets replaced by CheckedPtr with
   a non-trivial constructor, the compiler will complain.

See go/miracleptr for more details on the experimental CheckedPtr project.

Bug: 1080832
Change-Id: I5d0718a351af253bd3917bef87d417f9f0d71b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435033
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: default avatarAaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811485}
parent 5274e339
...@@ -1368,7 +1368,7 @@ void BrowserAccessibilityManager::OnAtomicUpdateFinished( ...@@ -1368,7 +1368,7 @@ void BrowserAccessibilityManager::OnAtomicUpdateFinished(
} }
// Calls OnDataChanged on newly created, reparented or changed nodes. // Calls OnDataChanged on newly created, reparented or changed nodes.
for (const auto change : changes) { for (const auto& change : changes) {
ui::AXNode* node = change.node; ui::AXNode* node = change.node;
BrowserAccessibility* wrapper = GetFromAXNode(node); BrowserAccessibility* wrapper = GetFromAXNode(node);
if (wrapper) { if (wrapper) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment