android: Fix Wrange-loop-analysis warnings.

Bug: 1039697
Change-Id: Ibcfdf5f2b6142c29b028fb65c43889ce27eeac83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068314
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743832}

chrome/browser/android/autofill_assistant/ui_controller_android.cc

@@ -1326,7 +1326,7 @@ void UiControllerAndroid::OnFormChanged(const FormProto* form) {
         CounterInputProto counter_input = input.counter();
 
         auto jcounters = Java_AssistantFormInput_createCounterList(env);
-        for (const CounterInputProto::Counter counter :
+        for (const CounterInputProto::Counter& counter :
              counter_input.counters()) {
           std::vector<int> allowed_values;
           for (int value : counter.allowed_values()) {
@@ -1367,7 +1367,7 @@ void UiControllerAndroid::OnFormChanged(const FormProto* form) {
         SelectionInputProto selection_input = input.selection();
 
         auto jchoices = Java_AssistantFormInput_createChoiceList(env);
-        for (const SelectionInputProto::Choice choice :
+        for (const SelectionInputProto::Choice& choice :
              selection_input.choices()) {
           Java_AssistantFormInput_addChoice(
               env, jchoices,

chrome/browser/android/chrome_backup_watcher.cc

@@ -27,7 +27,7 @@ ChromeBackupWatcher::ChromeBackupWatcher(Profile* profile) {
   registrar_.Init(profile->GetPrefs());
   base::RepeatingClosure callback =
       base::BindRepeating(&BackupPrefsChanged, java_watcher_);
-  for (const std::string pref_name : GetBackupPrefNames()) {
+  for (const std::string& pref_name : GetBackupPrefNames()) {
     registrar_.Add(pref_name, callback);
   }
 }

components/autofill_assistant/browser/script_precondition.cc

@@ -136,7 +136,7 @@ bool ScriptPrecondition::MatchParameters(const TriggerContext& context) const {
 
 bool ScriptPrecondition::MatchScriptStatus(
     const std::map<std::string, ScriptStatusProto>& executed_scripts) const {
-  for (const auto status_match : status_match_) {
+  for (const auto& status_match : status_match_) {
     auto status = SCRIPT_STATUS_NOT_RUN;
     auto iter = executed_scripts.find(status_match.script());
     if (iter != executed_scripts.end()) {