Add luci and test configurations for Win10 x64 Tests 1909.

Bring up win1909 to tests before rolling out to larger machine pool.

Bug: 990885
Change-Id: Id3900e8f04a386bd2e6fe81dee4799bc747cdfb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311124
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791064}

infra/config/generated/cr-buildbucket.cfg

@@ -7839,6 +7839,34 @@ buckets {
         }
       }
     }
+    builders {
+      name: "Win10 Tests x64 1909"
+      swarming_host: "chromium-swarm.appspot.com"
+      swarming_tags: "vpython:native-python-wrapper"
+      dimensions: "builder:Win10 Tests x64 1909"
+      dimensions: "cores:8"
+      dimensions: "cpu:x86-64"
+      dimensions: "os:Windows-10"
+      dimensions: "pool:luci.chromium.ci"
+      exe {
+        cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
+        cipd_version: "refs/heads/master"
+        cmd: "recipes"
+      }
+      properties: "{\"$kitchen\":{\"devshell\":true,\"git_auth\":true},\"mastername\":\"chromium.fyi\",\"recipe\":\"chromium\"}"
+      execution_timeout_secs: 36000
+      build_numbers: YES
+      service_account: "chromium-ci-builder@chops-service-accounts.iam.gserviceaccount.com"
+      resultdb {
+        enable: true
+        bq_exports {
+          project: "luci-resultdb"
+          dataset: "chromium"
+          table: "ci_test_results"
+          test_results {}
+        }
+      }
+    }
     builders {
       name: "Win10 x64 Debug (NVIDIA)"
       swarming_host: "chromium-swarm.appspot.com"

infra/config/generated/luci-milo.cfg

@@ -8301,6 +8301,10 @@ consoles {
     name: "buildbucket/luci.chromium.ci/Win10 Tests x64 1803"
     category: "win10|1803"
   }
+  builders {
+    name: "buildbucket/luci.chromium.ci/Win10 Tests x64 1909"
+    category: "win10|1909"
+  }
   builders {
     name: "buildbucket/luci.chromium.ci/win32-arm64-rel"
     category: "win32|arm64"

infra/config/generated/luci-scheduler.cfg

@@ -3946,6 +3946,20 @@ job {
     builder: "Win10 Tests x64 1803"
   }
 }
+job {
+  id: "Win10 Tests x64 1909"
+  realm: "ci"
+  acls {
+    role: TRIGGERER
+    granted_to: "chromium-ci-builder@chops-service-accounts.iam.gserviceaccount.com"
+  }
+  acl_sets: "ci"
+  buildbucket {
+    server: "cr-buildbucket.appspot.com"
+    bucket: "luci.chromium.ci"
+    builder: "Win10 Tests x64 1909"
+  }
+}
 job {
   id: "Win10 x64 Debug (NVIDIA)"
   realm: "ci"
@@ -7930,6 +7944,20 @@ job {
     builder: "Win10 Tests x64 1803"
   }
 }
+job {
+  id: "ci-Win10 Tests x64 1909"
+  realm: "ci"
+  acls {
+    role: TRIGGERER
+    granted_to: "chromium-ci-builder@chops-service-accounts.iam.gserviceaccount.com"
+  }
+  acl_sets: "ci"
+  buildbucket {
+    server: "cr-buildbucket.appspot.com"
+    bucket: "luci.chromium.ci"
+    builder: "Win10 Tests x64 1909"
+  }
+}
 job {
   id: "ci-Win10 x64 Debug (NVIDIA)"
   realm: "ci"
@@ -12510,6 +12538,26 @@ job {
   acl_sets: "ci-m85"
   noop {}
 }
+job {
+  id: "ci-m84-Win10 Tests x64 1909"
+  schedule: "triggered"
+  acls {
+    role: TRIGGERER
+    granted_to: "chromium-ci-builder@chops-service-accounts.iam.gserviceaccount.com"
+  }
+  acl_sets: "ci-m84"
+  noop {}
+}
+job {
+  id: "ci-m85-Win10 Tests x64 1909"
+  schedule: "triggered"
+  acls {
+    role: TRIGGERER
+    granted_to: "chromium-ci-builder@chops-service-accounts.iam.gserviceaccount.com"
+  }
+  acl_sets: "ci-m85"
+  noop {}
+}
 job {
   id: "ci-m84-Android WebView L (dbg)"
   schedule: "triggered"

infra/config/generators/scheduler-noop-jobs.star

@@ -40,10 +40,11 @@ _NON_BRANCHED_TESTERS = (
     # the branches
     'mac-osxbeta-rel',
 
-    # This tester is triggered by 'Win x64 Builder', but it is an FYI builder
+    # These testers are triggered by 'Win x64 Builder', but it is an FYI builder
     # and not mirrored by any branched try builders, so we do not need to run it
-    # on the branches
+    # on the branches (crbug/990885)
     'Win10 Tests x64 1803',
+    'Win10 Tests x64 1909',
 
     # These Android testers are triggered by 'Android arm Builder (dbg)', but we
     # don't have sufficient capacity of devices with older Android versions, so

infra/config/subprojects/chromium/master-only/ci.star

@@ -1941,6 +1941,17 @@ ci.fyi_windows_builder(
     triggered_by = ['ci/Win x64 Builder'],
 )
 
+ci.fyi_windows_builder(
+    name = 'Win10 Tests x64 1909',
+    console_view_entry = ci.console_view_entry(
+        category = 'win10|1909',
+    ),
+    goma_backend = None,
+    main_console_view = None,
+    os = os.WINDOWS_10,
+    triggered_by = ['ci/Win x64 Builder'],
+)
+
 ci.fyi_windows_builder(
     name = 'Win 10 Fast Ring',
     console_view_entry = ci.console_view_entry(

testing/buildbot/mixins.pyl

@@ -745,6 +745,13 @@
       },
     },
   },
+  'win10-1909': {
+    'swarming': {
+      'dimensions': {
+        'os': 'Windows-10-18363',
+      },
+    },
+  },
   # TODO(crbug.com/1087153): Remove this once the fleet is upgraded to 1909.
   'win10_1803_intel_hd_630': {
     'swarming': {

testing/buildbot/waterfalls.pyl

@@ -1894,6 +1894,16 @@
           'isolated_scripts': 'chromium_win_rel_isolated_scripts',
         },
       },
+      'Win10 Tests x64 1909': {
+        'mixins': [
+          'x86-64',
+          'win10-1909',
+        ],
+        'test_suites': {
+          'gtest_tests': 'chromium_win_gtests',
+          'isolated_scripts': 'chromium_win_rel_isolated_scripts',
+        },
+      },
       'android-code-coverage': {
         'mixins': [
           'bullhead',