Commit 673aad7b authored by ben@chromium.org's avatar ben@chromium.org

Fix unit test bustage by making sure ExtensionView::ViewHierarchyChanged calls...

Fix unit test bustage by making sure ExtensionView::ViewHierarchyChanged calls the base class impl first.

Fix compile bustage by not compiling windows-specific code on other platforms.

TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115912

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17172 0039d316-1c4b-4281-b951-d872f2087c98
parent 51b5cefa
...@@ -6,7 +6,9 @@ ...@@ -6,7 +6,9 @@
#include "chrome/browser/browsing_instance.h" #include "chrome/browser/browsing_instance.h"
#include "chrome/browser/extensions/extension_host.h" #include "chrome/browser/extensions/extension_host.h"
#if defined(OS_WIN)
#include "chrome/browser/extensions/extension_view.h" #include "chrome/browser/extensions/extension_view.h"
#endif
#include "chrome/browser/extensions/extensions_service.h" #include "chrome/browser/extensions/extensions_service.h"
#include "chrome/browser/profile.h" #include "chrome/browser/profile.h"
#include "chrome/browser/tab_contents/site_instance.h" #include "chrome/browser/tab_contents/site_instance.h"
...@@ -40,12 +42,14 @@ ExtensionProcessManager::~ExtensionProcessManager() { ...@@ -40,12 +42,14 @@ ExtensionProcessManager::~ExtensionProcessManager() {
delete *iter; delete *iter;
} }
#if defined(OS_WIN)
ExtensionView* ExtensionProcessManager::CreateView(Extension* extension, ExtensionView* ExtensionProcessManager::CreateView(Extension* extension,
const GURL& url, const GURL& url,
Browser* browser) { Browser* browser) {
return new ExtensionView( return new ExtensionView(
new ExtensionHost(extension, GetSiteInstanceForURL(url)), browser, url); new ExtensionHost(extension, GetSiteInstanceForURL(url)), browser, url);
} }
#endif
void ExtensionProcessManager::CreateBackgroundHost(Extension* extension, void ExtensionProcessManager::CreateBackgroundHost(Extension* extension,
const GURL& url) { const GURL& url) {
......
...@@ -14,7 +14,9 @@ class Browser; ...@@ -14,7 +14,9 @@ class Browser;
class BrowsingInstance; class BrowsingInstance;
class Extension; class Extension;
class ExtensionHost; class ExtensionHost;
#if defined(OS_WIN)
class ExtensionView; class ExtensionView;
#endif
class GURL; class GURL;
class Profile; class Profile;
class SiteInstance; class SiteInstance;
...@@ -26,11 +28,13 @@ class ExtensionProcessManager : public NotificationObserver { ...@@ -26,11 +28,13 @@ class ExtensionProcessManager : public NotificationObserver {
ExtensionProcessManager(Profile* profile); ExtensionProcessManager(Profile* profile);
~ExtensionProcessManager(); ~ExtensionProcessManager();
#if defined(OS_WIN)
// Creates a new ExtensionView, grouping it in the appropriate SiteInstance // Creates a new ExtensionView, grouping it in the appropriate SiteInstance
// (and therefore process) based on the URL and profile. // (and therefore process) based on the URL and profile.
ExtensionView* CreateView(Extension* extension, ExtensionView* CreateView(Extension* extension,
const GURL& url, const GURL& url,
Browser* browser); Browser* browser);
#endif
// Creates a new UI-less extension instance. Like CreateView, but not // Creates a new UI-less extension instance. Like CreateView, but not
// displayed anywhere. // displayed anywhere.
......
...@@ -83,6 +83,7 @@ void ExtensionView::DidContentsPreferredWidthChange(const int pref_width) { ...@@ -83,6 +83,7 @@ void ExtensionView::DidContentsPreferredWidthChange(const int pref_width) {
void ExtensionView::ViewHierarchyChanged(bool is_add, void ExtensionView::ViewHierarchyChanged(bool is_add,
views::View *parent, views::View *parent,
views::View *child) { views::View *child) {
NativeViewHost::ViewHierarchyChanged(is_add, parent, child);
if (is_add && GetWidget() && !initialized_) { if (is_add && GetWidget() && !initialized_) {
initialized_ = true; initialized_ = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment