Commit 674a1d16 authored by bsheedy's avatar bsheedy Committed by Commit Bot

Move 'file count' in resource_sizes

Moves the 'file count' metric generated by resource_sizes.py out of the
_Specifics group into its own _FileCount group. This is a workaround
for https://crbug.com/903970, where mixing units within a group causes
malformed data to be generated when using the HistogramSet format.

Bug: 892344, 892301
Change-Id: Icfd47567127d51f7ee703262c448c2619148cb10
Reviewed-on: https://chromium-review.googlesource.com/c/1330707Reviewed-by: default avatarEric Stevenson <estevenson@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607012}
parent 07fbe412
......@@ -528,7 +528,13 @@ def GenerateApkAnalysis(apk_filename, tool_prefix, out_dir,
apk_filename, arsc.GetNumEntries(), num_arsc_translations, out_dir))
yield ('Specifics', 'normalized apk size', normalized_apk_size, 'bytes')
yield ('Specifics', 'file count', len(apk_contents), 'zip entries')
# The "file count" metric cannot be grouped with any other metrics when the
# end result is going to be uploaded to the perf dashboard in the HistogramSet
# format due to mixed units (bytes vs. zip entries) causing malformed
# summaries to be generated.
# TODO(https://crbug.com/903970): Remove this workaround if unit mixing is
# ever supported.
yield ('FileCount', 'file count', len(apk_contents), 'zip entries')
if unknown_handler is not None:
for info in unknown.AllEntries():
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment