Commit 6750f6cb authored by Sreeja Kamishetty's avatar Sreeja Kamishetty Committed by Commit Bot

Fix failing RenderDocumentHostUserData tests with BFCache

This CL disables following tests which didn't consider caching:
- RenderDocumentHostUserDataTest.FailedNavigation
- RenderDocumentHostUserDataTest.CheckWithFrameCrashDuringNavigation

Bug: 1102629

TBR=arthursonzogni@chromium.org

Change-Id: I3dce29531399ae8dfae2e4c101e41298ba155843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367112
Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Reviewed-by: default avatarAlexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800112}
parent 73eb0851
......@@ -284,6 +284,11 @@ IN_PROC_BROWSER_TEST_F(RenderDocumentHostUserDataTest,
// current RFH (of old URL) not alive.
IN_PROC_BROWSER_TEST_F(RenderDocumentHostUserDataTest,
CheckWithFrameCrashDuringNavigation) {
// TODO(sreejakshetty): Investigate why the data is being deleted after crash
// when BackForwardCache is enabled.
DisableBackForwardCacheForTesting(shell()->web_contents(),
BackForwardCache::TEST_ASSUMES_NO_CACHING);
ASSERT_TRUE(embedded_test_server()->Start());
GURL url_a(embedded_test_server()->GetURL("a.com", "/title1.html"));
GURL url_b(embedded_test_server()->GetURL("b.com", "/title2.html"));
......@@ -683,6 +688,12 @@ IN_PROC_BROWSER_TEST_F(RenderDocumentHostUserDataTest, FailedNavigation) {
base::WeakPtr<Data> data = Data::GetForCurrentDocument(rfh_a)->GetWeakPtr();
EXPECT_TRUE(data);
// This test expects old RenderFrameHost to be deleted after navigating to an
// error page, disable back-forward cache to ensure that RenderFrameHost gets
// deleted.
DisableBackForwardCacheForTesting(shell()->web_contents(),
BackForwardCache::TEST_ASSUMES_NO_CACHING);
// 3) Browser-initiated navigation to an error page.
NavigationHandleObserver observer(shell()->web_contents(), error_url);
EXPECT_FALSE(NavigateToURL(shell(), error_url));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment