Commit 676d6880 authored by Annie Sullivan's avatar Annie Sullivan Committed by Commit Bot

Purposefully disable system health stories that shouldn't run on WebView.

These stories depend on tabs and/or omnibox. The fact that they don't
run on WebView is intentional, not a bug. So remove them from
expectations and clarify that they shouldn't run on WebView in the
code.

Bug: 865464,865466,865471,867568
Change-Id: I9bbd6a4a87aaa423bdf8d106d3de2d64cf6c8d52
Reviewed-on: https://chromium-review.googlesource.com/1174700
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: default avatarJuan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#583292}
parent 71cefa10
......@@ -174,11 +174,8 @@ crbug.com/839411 [ Win ] system_health.common_desktop/browse:social:twitter_infi
crbug.com/846022 [ Linux ] system_health.common_desktop/browse:social:twitter_infinite_scroll [ Skip ]
# Benchmark: system_health.common_mobile
crbug.com/865464 [ Android_Webview ] system_health.common_mobile/browse:chrome:omnibox [ Skip ]
crbug.com/714650 [ Android ] system_health.common_mobile/browse:news:globo [ Skip ]
crbug.com/865466 [ Android_Webview ] system_health.common_mobile/long_running:tools:gmail-background [ Skip ]
crbug.com/708300 [ Android ] system_health.common_mobile/browse:shopping:flipkart [ Skip ]
crbug.com/865471 [ Android_Webview ] system_health.common_mobile/browse:chrome:newtab [ Skip ]
crbug.com/738854 [ Nexus_5X ] system_health.common_mobile/load:tools:drive [ Skip ]
crbug.com/738854 [ Android_Webview ] system_health.common_mobile/load:tools:drive [ Skip ]
......
......@@ -38,6 +38,8 @@ class SearchOmniboxStory(system_health_story.SystemHealthStory):
URL = 'https://www.google.co.in'
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
TAGS = [story_tags.EMERGING_MARKET]
# WebView has no omnibox, so not supported.
WEBVIEW_NOT_SUPPORTED = True
def _DidLoadDocument(self, action_runner):
app_ui = action_runner.tab.browser.GetAppUi()
......@@ -72,6 +74,8 @@ class MobileNewTabPageStory(system_health_story.SystemHealthStory):
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
TAGS = [story_tags.EMERGING_MARKET]
# WebView has no tabs, so this story is not supported there.
WEBVIEW_NOT_SUPPORTED = True
def _DidLoadDocument(self, action_runner):
app_ui = action_runner.tab.browser.GetAppUi()
......
......@@ -97,6 +97,9 @@ class LongRunningGmailDesktopForegroundStory(_LongRunningGmailDesktopBase):
class LongRunningGmailMobileBackgroundStory(_LongRunningGmailMobileBase):
BACKGROUND = True
NAME = 'long_running:tools:gmail-background'
# This runs a gmail story in a background tab, and tabs aren't supported
# on WebView.
WEBVIEW_NOT_SUPPORTED = True
class LongRunningGmailDesktopBackgroundStory(_LongRunningGmailDesktopBase):
......
......@@ -22,6 +22,10 @@ class _SystemHealthSharedState(shared_page_state.SharedPageState):
"""
def CanRunOnBrowser(self, browser_info, story):
if (browser_info.browser_type.startswith('android-webview') and
story.WEBVIEW_NOT_SUPPORTED):
return False
if story.TAGS and story_tags.WEBGL in story.TAGS:
return browser_info.HasWebGLSupport()
return True
......@@ -56,6 +60,7 @@ class SystemHealthStory(page.Page):
SUPPORTED_PLATFORMS = platforms.ALL_PLATFORMS
TAGS = []
PLATFORM_SPECIFIC = False
WEBVIEW_NOT_SUPPORTED = False
def __init__(self, story_set, take_memory_measurement,
extra_browser_args=None):
......@@ -108,3 +113,4 @@ class SystemHealthStory(page.Page):
action_runner.tab.WaitForDocumentReadyStateToBeComplete()
self._DidLoadDocument(action_runner)
self._Measure(action_runner)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment