Record when text selection is in iframe

Bug: 1139864
Change-Id: I17686adaf4241202e400acb18f6c8fc8b6a83a7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513290
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824048}

chrome/browser/BUILD.gn

@@ -4029,6 +4029,7 @@ static_library("browser") {
       "//components/services/app_service/public/cpp:intents",
       "//components/services/app_service/public/cpp:preferred_apps",
       "//components/services/app_service/public/cpp:publisher",
+      "//components/shared_highlighting/core/common",
       "//components/soda:constants",
       "//components/ukm/content",
       "//components/web_modal",

chrome/browser/DEPS

@@ -242,6 +242,7 @@ include_rules = [
   "+components/safe_browsing",
   "+components/safe_search_api",
   "+components/schema_org",
+  "+components/shared_highlighting/core/common",
   "+components/search",
   "+components/search_engines",
   "+components/search_provider_logos",

chrome/browser/renderer_context_menu/copy_link_to_text_menu_observer.cc

@@ -10,6 +10,7 @@
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/renderer_context_menu/render_view_context_menu_proxy.h"
+#include "components/shared_highlighting/core/common/shared_highlighting_metrics.h"
 #include "content/public/browser/context_menu_params.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
@@ -71,6 +72,7 @@ void CopyLinkToTextMenuObserver::ExecuteCommand(int command_id) {
     return;
 
   if (main_frame != proxy_->GetWebContents()->GetFocusedFrame()) {
+    shared_highlighting::LogGenerateErrorIFrame();
     OnGeneratedSelector(std::make_unique<ui::DataTransferEndpoint>(
                             main_frame->GetLastCommittedOrigin()),
                         std::string());

chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/link_to_text/LinkToTextCoordinator.java

@@ -73,6 +73,7 @@ public class LinkToTextCoordinator extends EmptyTabObserver {
 
     public void requestSelector() {
         if (mTab.getWebContents().getMainFrame() != mTab.getWebContents().getFocusedFrame()) {
+            LinkToTextMetricsBridge.logGenerateErrorIFrame();
             onSelectorReady(INVALID_SELECTOR);
             return;
         }

chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/link_to_text/LinkToTextMetricsBridge.java

@@ -22,10 +22,15 @@ public class LinkToTextMetricsBridge {
         LinkToTextMetricsBridgeJni.get().logGenerateErrorTabCrash();
     }
 
+    public static void logGenerateErrorIFrame() {
+        LinkToTextMetricsBridgeJni.get().logGenerateErrorIFrame();
+    }
+
     @NativeMethods
     interface Natives {
         void logGenerateErrorTabHidden();
         void logGenerateErrorOmniboxNavigation();
         void logGenerateErrorTabCrash();
+        void logGenerateErrorIFrame();
     }
 }

chrome/browser/share/link_to_text_metrics_bridge.cc

@@ -19,3 +19,7 @@ static void JNI_LinkToTextMetricsBridge_LogGenerateErrorOmniboxNavigation(
 static void JNI_LinkToTextMetricsBridge_LogGenerateErrorTabCrash(JNIEnv* env) {
   shared_highlighting::LogGenerateErrorTabCrash();
 }
+
+static void JNI_LinkToTextMetricsBridge_LogGenerateErrorIFrame(JNIEnv* env) {
+  shared_highlighting::LogGenerateErrorIFrame();
+}

components/shared_highlighting/core/common/shared_highlighting_metrics.cc

@@ -66,4 +66,8 @@ void LogGenerateErrorOmniboxNavigation() {
 void LogGenerateErrorTabCrash() {
   LogLinkGenerationErrorReason(LinkGenerationError::kTabCrash);
 }
+
+void LogGenerateErrorIFrame() {
+  LogLinkGenerationErrorReason(LinkGenerationError::kIFrame);
+}
 }  // namespace shared_highlighting

components/shared_highlighting/core/common/shared_highlighting_metrics.h

@@ -28,7 +28,10 @@ enum class LinkGenerationError {
   // Catch-all bucket.
   kUnknown = 9,
 
-  kMaxValue = kUnknown
+  // Selection happened on iframe.
+  kIFrame = 10,
+
+  kMaxValue = kIFrame
 };
 
 // These values are persisted to logs. Entries should not be renumbered and
@@ -72,6 +75,10 @@ void LogGenerateErrorOmniboxNavigation();
 // Records when tab crashes before generation is complete.
 void LogGenerateErrorTabCrash();
 
+// Records when link generation was not completed because selection happened on
+// iframe.
+void LogGenerateErrorIFrame();
+
 }  // namespace shared_highlighting
 
 #endif  // COMPONENTS_SHARED_HIGHLIGHTING_CORE_COMMON_SHARED_HIGHLIGHTING_METRICS_H_

third_party/blink/renderer/core/page/scrolling/text_fragment_selector_generator.h

@@ -48,7 +48,9 @@ class CORE_EXPORT TextFragmentSelectorGenerator final
 
     kUnknown,
 
-    kMaxValue = kUnknown
+    kIFrame,
+
+    kMaxValue = kIFrame
   };
   explicit TextFragmentSelectorGenerator() = default;
 

tools/metrics/histograms/enums.xml

@@ -40909,6 +40909,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.-->
   <int value="7" label="Omnibox navigation"/>
   <int value="8" label="Tab crash"/>
   <int value="9" label="Unknown"/>
+  <int value="10" label="Iframe"/>
 </enum>
 
 <enum name="LinkMonitorFailureType">