Commit 679eab13 authored by Omar Morsi's avatar Omar Morsi Committed by Commit Bot

DeviceAttrs: Add TODOs to report error for unaffiliated users

Bug: 1056550
Change-Id: Idafa91e74cd7707632dbeaaaa0a27b448ae92719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416372Reviewed-by: default avatarMaksim Ivanov <emaxx@chromium.org>
Reviewed-by: default avatarPavol Marko <pmarko@chromium.org>
Commit-Queue: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#808800}
parent ff7c75cd
...@@ -10,6 +10,10 @@ ...@@ -10,6 +10,10 @@
namespace extensions { namespace extensions {
// Note: When updating this function, consider changing the way errors are
// returned.
// TODO(https://crbug.com/1056550): Return an error in case of unaffiliated user
// in enterprise.deviceAttributes API
class EnterpriseDeviceAttributesGetDirectoryDeviceIdFunction class EnterpriseDeviceAttributesGetDirectoryDeviceIdFunction
: public ExtensionFunction { : public ExtensionFunction {
public: public:
...@@ -25,6 +29,10 @@ class EnterpriseDeviceAttributesGetDirectoryDeviceIdFunction ...@@ -25,6 +29,10 @@ class EnterpriseDeviceAttributesGetDirectoryDeviceIdFunction
ENTERPRISE_DEVICEATTRIBUTES_GETDIRECTORYDEVICEID) ENTERPRISE_DEVICEATTRIBUTES_GETDIRECTORYDEVICEID)
}; };
// Note: When updating this function, consider changing the way errors are
// returned.
// TODO(https://crbug.com/1056550): Return an error in case of unaffiliated user
// in enterprise.deviceAttributes API
class EnterpriseDeviceAttributesGetDeviceSerialNumberFunction class EnterpriseDeviceAttributesGetDeviceSerialNumberFunction
: public ExtensionFunction { : public ExtensionFunction {
public: public:
...@@ -41,6 +49,10 @@ class EnterpriseDeviceAttributesGetDeviceSerialNumberFunction ...@@ -41,6 +49,10 @@ class EnterpriseDeviceAttributesGetDeviceSerialNumberFunction
ENTERPRISE_DEVICEATTRIBUTES_GETDEVICESERIALNUMBER) ENTERPRISE_DEVICEATTRIBUTES_GETDEVICESERIALNUMBER)
}; };
// Note: When updating this function, consider changing the way errors are
// returned.
// TODO(https://crbug.com/1056550): Return an error in case of unaffiliated user
// in enterprise.deviceAttributes API
class EnterpriseDeviceAttributesGetDeviceAssetIdFunction class EnterpriseDeviceAttributesGetDeviceAssetIdFunction
: public ExtensionFunction { : public ExtensionFunction {
public: public:
...@@ -56,6 +68,10 @@ class EnterpriseDeviceAttributesGetDeviceAssetIdFunction ...@@ -56,6 +68,10 @@ class EnterpriseDeviceAttributesGetDeviceAssetIdFunction
ENTERPRISE_DEVICEATTRIBUTES_GETDEVICEASSETID) ENTERPRISE_DEVICEATTRIBUTES_GETDEVICEASSETID)
}; };
// Note: When updating this function, consider changing the way errors are
// returned.
// TODO(https://crbug.com/1056550): Return an error in case of unaffiliated user
// in enterprise.deviceAttributes API
class EnterpriseDeviceAttributesGetDeviceAnnotatedLocationFunction class EnterpriseDeviceAttributesGetDeviceAnnotatedLocationFunction
: public ExtensionFunction { : public ExtensionFunction {
public: public:
...@@ -72,6 +88,10 @@ class EnterpriseDeviceAttributesGetDeviceAnnotatedLocationFunction ...@@ -72,6 +88,10 @@ class EnterpriseDeviceAttributesGetDeviceAnnotatedLocationFunction
ENTERPRISE_DEVICEATTRIBUTES_GETDEVICEANNOTATEDLOCATION) ENTERPRISE_DEVICEATTRIBUTES_GETDEVICEANNOTATEDLOCATION)
}; };
// Note: When updating this function, consider changing the way errors are
// returned.
// TODO(https://crbug.com/1056550): Return an error in case of unaffiliated user
// in enterprise.deviceAttributes API
class EnterpriseDeviceAttributesGetDeviceHostnameFunction class EnterpriseDeviceAttributesGetDeviceHostnameFunction
: public ExtensionFunction { : public ExtensionFunction {
public: public:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment