[Code health] Convert DevToolsTargetsUIHandler callback to repeating

Bug: 1152274
Change-Id: Idc567b91983adc94a968789c5599c1bfccfdb74b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583011
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835696}

chrome/browser/devtools/devtools_targets_ui.cc

@@ -305,12 +305,9 @@ void AdbTargetsUIHandler::DeviceListChanged(
 
 // DevToolsTargetsUIHandler ---------------------------------------------------
 
-DevToolsTargetsUIHandler::DevToolsTargetsUIHandler(
-    const std::string& source_id,
-    const Callback& callback)
-    : source_id_(source_id),
-      callback_(callback) {
-}
+DevToolsTargetsUIHandler::DevToolsTargetsUIHandler(const std::string& source_id,
+                                                   Callback callback)
+    : source_id_(source_id), callback_(std::move(callback)) {}
 
 DevToolsTargetsUIHandler::~DevToolsTargetsUIHandler() {
 }
@@ -318,7 +315,7 @@ DevToolsTargetsUIHandler::~DevToolsTargetsUIHandler() {
 // static
 std::unique_ptr<DevToolsTargetsUIHandler>
 DevToolsTargetsUIHandler::CreateForLocal(
-    const DevToolsTargetsUIHandler::Callback& callback,
+    DevToolsTargetsUIHandler::Callback callback,
     Profile* profile) {
   return std::unique_ptr<DevToolsTargetsUIHandler>(
       new LocalTargetsUIHandler(callback, profile));
@@ -327,7 +324,7 @@ DevToolsTargetsUIHandler::CreateForLocal(
 // static
 std::unique_ptr<DevToolsTargetsUIHandler>
 DevToolsTargetsUIHandler::CreateForAdb(
-    const DevToolsTargetsUIHandler::Callback& callback,
+    DevToolsTargetsUIHandler::Callback callback,
     Profile* profile) {
   return std::unique_ptr<DevToolsTargetsUIHandler>(
       new AdbTargetsUIHandler(callback, profile));

chrome/browser/devtools/devtools_targets_ui.h

@@ -22,21 +22,21 @@ class Profile;
 
 class DevToolsTargetsUIHandler {
  public:
-  typedef base::Callback<void(const std::string&,
-                              const base::ListValue&)> Callback;
+  typedef base::RepeatingCallback<void(const std::string&,
+                                       const base::ListValue&)>
+      Callback;
 
-  DevToolsTargetsUIHandler(const std::string& source_id,
-                           const Callback& callback);
+  DevToolsTargetsUIHandler(const std::string& source_id, Callback callback);
   virtual ~DevToolsTargetsUIHandler();
 
   std::string source_id() const { return source_id_; }
 
   static std::unique_ptr<DevToolsTargetsUIHandler> CreateForLocal(
-      const Callback& callback,
+      Callback callback,
       Profile* profile);
 
   static std::unique_ptr<DevToolsTargetsUIHandler> CreateForAdb(
-      const Callback& callback,
+      Callback callback,
       Profile* profile);
 
   scoped_refptr<content::DevToolsAgentHost> GetTarget(

chrome/browser/ui/webui/inspect_ui.cc

@@ -512,7 +512,7 @@ void InspectUI::StartListeningNotifications() {
   Profile* profile = Profile::FromWebUI(web_ui());
 
   DevToolsTargetsUIHandler::Callback callback =
-      base::Bind(&InspectUI::PopulateTargets, base::Unretained(this));
+      base::BindRepeating(&InspectUI::PopulateTargets, base::Unretained(this));
 
   PopulateAdditionalTargets(GetUiDevToolsTargets());