Skip to content

GitLab

T
tangled
Commit 67c6505b authored by Annie Sullivan's avatar Annie Sullivan Committed by Commit Bot
Browse files
Options

Always set input timestamp if available. 

This allows the developer to easily implement a threshold different from
the default 500ms, and brings the implementation into conformance with
the spec.

Bug: 1114793
Change-Id: I2b3ed36679f113576e4d301ab734270ae92ebb69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346793Reviewed-by: default avatarSteve Kobes <skobes@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796810}
parent 7c8462c5
Hide whitespace changes
Inline Side-by-side
Showing with 75 additions and 3 deletions
third_party/blink/renderer/core/layout/layout_shift_tracker.cc
View file @ 67c6505b
...@@ -485,9 +485,10 @@ void LayoutShiftTracker::SubmitPerformanceEntry(double score_delta, ...@@ -485,9 +485,10 @@ void LayoutShiftTracker::SubmitPerformanceEntry(double score_delta,
DCHECK(performance); DCHECK(performance);
double input_timestamp = double input_timestamp =
had_recent_input ? performance->MonotonicTimeToDOMHighResTimeStamp( most_recent_input_timestamp_initialized_
most_recent_input_timestamp_) ? performance->MonotonicTimeToDOMHighResTimeStamp(
: 0.0; most_recent_input_timestamp_)
: 0.0;
LayoutShift* entry = LayoutShift* entry =
LayoutShift::Create(performance->now(), score_delta, had_recent_input, LayoutShift::Create(performance->now(), score_delta, had_recent_input,
input_timestamp, CreateAttributionList()); input_timestamp, CreateAttributionList());
......
third_party/blink/web_tests/external/wpt/layout-instability/input-timestamp.html 0 → 100644
View file @ 67c6505b
<!DOCTYPE HTML>
<meta charset=utf-8>
<title>Layout Instability: observe timestamp after user input</title>
<body>
<style>
#myDiv {
position: relative;
width: 300px;
height: 100px;
}
/* Disable the button's focus ring, which otherwise expands its visual rect by
* 1px on all sides, triggering a layout shift event.
*/
#button {
outline: none;
}
</style>
<div id='myDiv'></div>
<button id='button'>Generate a 'click' event</button>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script src=/resources/testdriver.js></script>
<script src=/resources/testdriver-vendor.js></script>
<script src=resources/util.js></script>
<script src=/event-timing/resources/event-timing-test-utils.js></script>
<script>
let timeAfterClick;
promise_test(async t => {
assert_implements(window.LayoutShift, 'Layout Instability is not supported.');
// Wait for the initial render to complete.
await waitForAnimationFrames(2);
const startTime = performance.now();
return new Promise(resolve => {
const observer = new PerformanceObserver(
t.step_func(entryList => {
const endTime = performance.now();
assert_equals(entryList.getEntries().length, 1);
const entry = entryList.getEntries()[0];
assert_equals(entry.entryType, "layout-shift");
assert_equals(entry.name, "");
assert_greater_than_equal(entry.startTime, startTime);
assert_less_than_equal(entry.startTime, endTime);
assert_equals(entry.duration, 0.0);
// The layout shift value should be:
// 300 * (100 + 60) * (60 / maxDimension) / viewport size.
assert_equals(entry.value, computeExpectedScore(300 * (100 + 60), 60));
// We should see that there was a click input entry.
assert_equals(entry.hadRecentInput, false);
assert_greater_than_equal(timeAfterClick, entry.lastInputTime);
resolve();
})
);
observer.observe({ entryTypes: ['layout-shift'] });
// User input event
clickAndBlockMain('button').then(() => {
// 500ms delay
step_timeout(function() {
timeAfterClick = performance.now();
// Modify the position of the div.
document.getElementById('myDiv').style = "top: 60px";
}, 500);
});
});
}, 'Layout shift right after user input is observable via PerformanceObserver.');
</script>
</body>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment