Commit 67ce5cec authored by Gyuyoung Kim's avatar Gyuyoung Kim Committed by Commit Bot

Replace kCalendar[Clear|Today] with IDS_FOO

As a step to remove all uses of WebLocalizedString::kFooBar,
this CL replaces below ones with matched IDS_FOO.

  - WebLocalizedString::kCalendarClear
  - WebLocalizedString::kCalendarToday

Bug: 995644
Change-Id: I337cb55eea0399145ff8f3ece7677607f09cc46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817867
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Reviewed-by: default avatarTommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699324}
parent 87fab88a
...@@ -160,10 +160,6 @@ int ToMessageID(int resource_id) { ...@@ -160,10 +160,6 @@ int ToMessageID(int resource_id) {
return IDS_AX_MEDIA_TOUCHLESS_SEEK_ACTION; return IDS_AX_MEDIA_TOUCHLESS_SEEK_ACTION;
case WebLocalizedString::kAXMediaTouchLessVolumeAction: case WebLocalizedString::kAXMediaTouchLessVolumeAction:
return IDS_AX_MEDIA_TOUCHLESS_VOLUME_ACTION; return IDS_AX_MEDIA_TOUCHLESS_VOLUME_ACTION;
case WebLocalizedString::kCalendarClear:
return IDS_FORM_CALENDAR_CLEAR;
case WebLocalizedString::kCalendarToday:
return IDS_FORM_CALENDAR_TODAY;
case WebLocalizedString::kDetailsLabel: case WebLocalizedString::kDetailsLabel:
return IDS_DETAILS_WITHOUT_SUMMARY_LABEL; return IDS_DETAILS_WITHOUT_SUMMARY_LABEL;
case WebLocalizedString::kFileButtonNoFileSelectedLabel: case WebLocalizedString::kFileButtonNoFileSelectedLabel:
......
...@@ -414,6 +414,7 @@ jumbo_static_library("test_support") { ...@@ -414,6 +414,7 @@ jumbo_static_library("test_support") {
"//storage/common", "//storage/common",
"//testing/gmock", "//testing/gmock",
"//testing/gtest", "//testing/gtest",
"//third_party/blink/public/strings:strings_grit",
"//third_party/webrtc/api:libjingle_peerconnection_api", "//third_party/webrtc/api:libjingle_peerconnection_api",
"//third_party/webrtc/api:media_stream_interface", "//third_party/webrtc/api:media_stream_interface",
"//third_party/webrtc/api:rtc_stats_api", "//third_party/webrtc/api:rtc_stats_api",
......
...@@ -40,6 +40,7 @@ ...@@ -40,6 +40,7 @@
#include "third_party/blink/public/platform/web_string.h" #include "third_party/blink/public/platform/web_string.h"
#include "third_party/blink/public/platform/web_url.h" #include "third_party/blink/public/platform/web_url.h"
#include "third_party/blink/public/platform/web_url_loader_factory.h" #include "third_party/blink/public/platform/web_url_loader_factory.h"
#include "third_party/blink/public/strings/grit/blink_strings.h"
#include "third_party/blink/public/web/blink.h" #include "third_party/blink/public/web/blink.h"
#include "v8/include/v8.h" #include "v8/include/v8.h"
...@@ -230,9 +231,9 @@ blink::WebString TestBlinkWebUnitTestSupport::QueryLocalizedString( ...@@ -230,9 +231,9 @@ blink::WebString TestBlinkWebUnitTestSupport::QueryLocalizedString(
return WebString::FromASCII("<<OtherMonthLabel>>"); return WebString::FromASCII("<<OtherMonthLabel>>");
case blink::WebLocalizedString::kOtherWeekLabel: case blink::WebLocalizedString::kOtherWeekLabel:
return WebString::FromASCII("<<OtherWeekLabel>>"); return WebString::FromASCII("<<OtherWeekLabel>>");
case blink::WebLocalizedString::kCalendarClear: case IDS_FORM_CALENDAR_CLEAR:
return WebString::FromASCII("<<CalendarClear>>"); return WebString::FromASCII("<<CalendarClear>>");
case blink::WebLocalizedString::kCalendarToday: case IDS_FORM_CALENDAR_TODAY:
return WebString::FromASCII("<<CalendarToday>>"); return WebString::FromASCII("<<CalendarToday>>");
case blink::WebLocalizedString::kThisMonthButtonLabel: case blink::WebLocalizedString::kThisMonthButtonLabel:
return WebString::FromASCII("<<ThisMonthLabel>>"); return WebString::FromASCII("<<ThisMonthLabel>>");
......
...@@ -72,8 +72,6 @@ struct WebLocalizedString { ...@@ -72,8 +72,6 @@ struct WebLocalizedString {
kAXMediaTouchLessSeekAction, kAXMediaTouchLessSeekAction,
kAXMediaTouchLessVolumeAction, kAXMediaTouchLessVolumeAction,
kBlockedPluginText, kBlockedPluginText,
kCalendarClear,
kCalendarToday,
kDetailsLabel, kDetailsLabel,
kFileButtonNoFileSelectedLabel, kFileButtonNoFileSelectedLabel,
kInputElementAltText, kInputElementAltText,
......
...@@ -117,8 +117,7 @@ void DateTimeChooserImpl::WriteDocument(SharedBuffer* data) { ...@@ -117,8 +117,7 @@ void DateTimeChooserImpl::WriteDocument(SharedBuffer* data) {
other_date_label_string = other_date_label_string =
GetLocale().QueryString(WebLocalizedString::kOtherWeekLabel); GetLocale().QueryString(WebLocalizedString::kOtherWeekLabel);
} else { } else {
today_label_string = today_label_string = GetLocale().QueryString(IDS_FORM_CALENDAR_TODAY);
GetLocale().QueryString(WebLocalizedString::kCalendarToday);
other_date_label_string = other_date_label_string =
GetLocale().QueryString(WebLocalizedString::kOtherDateLabel); GetLocale().QueryString(WebLocalizedString::kOtherDateLabel);
} }
...@@ -155,8 +154,7 @@ void DateTimeChooserImpl::WriteDocument(SharedBuffer* data) { ...@@ -155,8 +154,7 @@ void DateTimeChooserImpl::WriteDocument(SharedBuffer* data) {
data); data);
AddProperty("locale", parameters_->locale.GetString(), data); AddProperty("locale", parameters_->locale.GetString(), data);
AddProperty("todayLabel", today_label_string, data); AddProperty("todayLabel", today_label_string, data);
AddProperty("clearLabel", AddProperty("clearLabel", GetLocale().QueryString(IDS_FORM_CALENDAR_CLEAR),
GetLocale().QueryString(WebLocalizedString::kCalendarClear),
data); data);
AddProperty("weekLabel", AddProperty("weekLabel",
GetLocale().QueryString(WebLocalizedString::kWeekNumberLabel), GetLocale().QueryString(WebLocalizedString::kWeekNumberLabel),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment