Commit 67e499b1 authored by Jonah Chin's avatar Jonah Chin Committed by Commit Bot

Fix regression caused by drawing accelerated content on SW canvas

The recent change introducing PaintImage::GetSwSkImage() caused a
regression that occurs when drawing accelerated resources on a software
canvas.

This is a quick fix to revert the culprit caller back to
PaintImage::GetSkImage(). This avoids the cost of multiple readbacks
that GetSwSkImage() incurs. A follow up change will introduce caching in
GetSwSkImage(), at which point we can use it again.

Bug: 1115686
Change-Id: I765f85acf2d53c7f379b4d5cffd86a1224be4318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358432Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Commit-Queue: Jonah Chin <jochin@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#798898}
parent 4b6e39ef
...@@ -67,10 +67,9 @@ ImageProvider::ScopedResult PlaybackImageProvider::GetRasterContent( ...@@ -67,10 +67,9 @@ ImageProvider::ScopedResult PlaybackImageProvider::GetRasterContent(
SkSize::Make(1.f, 1.f), draw_image.filter_quality(), SkSize::Make(1.f, 1.f), draw_image.filter_quality(),
true /* is_budgeted */)); true /* is_budgeted */));
} else { } else {
return ScopedResult( return ScopedResult(DecodedDrawImage(
DecodedDrawImage(paint_image.GetSwSkImage(), SkSize::Make(0, 0), paint_image.GetSkImage(), SkSize::Make(0, 0), SkSize::Make(1.f, 1.f),
SkSize::Make(1.f, 1.f), draw_image.filter_quality(), draw_image.filter_quality(), true /* is_budgeted */));
true /* is_budgeted */));
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment